Increase stack size in src/test/run-pass/spawn-stack-too-big.rs #16146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If a 64GB stack doesn't fail, I have to wonder if something else is going on. |
|
virtual memory? |
|
Hmm, it is timing out now, so I dropped the increase to only 1000x...if this is a change to increase virtual memory, I'm a little concerned that we won't be able to allocate all of it in a reasonable amount of time. |
This test should fail by creating a task which allocates too much stack space, but some recent change in Travis has caused it to succeed. Jack up the memory to 128Gb and see if that corrects it.
|
At 1Tb it times out, and 128Gb the allocation succeeds...rather than continuing to bisect my way toward the Fragilest Fix Award, I think I'll leave this to somebody more creative... |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2024
…barsky internal: Add minimal support for the 2024 edition CC rust-lang#16146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test should fail by creating a task which allocates too
much stack space, but some recent change in Travis has caused
it to succeed. Jack up the memory by a million times or so and
see if that corrects it.