Skip to content

Update icu_list dependency to 2.3 - #161287

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
robertbastian:23
Sep 1, 2026
Merged

Update icu_list dependency to 2.3#161287
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
robertbastian:23

Conversation

@robertbastian

@robertbastian robertbastian commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

This removes the icu_collections transitive dependency, and uses the smaller icu_locale_fallback instead of icu_locale.

r? manishearth

@rustbot

rustbot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustc_error_messages was changed

cc @TaKO8Ki

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @BoxyUwU

@rustbot rustbot added A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 18, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Manishearth
Manishearth approved these changes Aug 18, 2026
View reviewed changes

@Manishearth Manishearth left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me but I would like to hold off on updating this until next week

View changes since this review

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@robertbastian

robertbastian commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

I'll get there

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth commented Sep 1, 2026

Copy link
Copy Markdown
Member

@bors r+

Noting that the dependency list has been updated with many crates being removed and two being added. The two new crates are former parts of the removed crate, with the same licensing and original repo (ICU4X).

@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 80dc5df has been approved by Manishearth

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 1, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161287 - robertbastian:23, r=Manishearth
8441f66 
Update `icu_list` dependency to 2.3

This removes the `icu_collections` transitive dependency, and uses the smaller `icu_locale_fallback` instead of `icu_locale`.

r? manishearth
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 1, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 1, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161287 - robertbastian:23, r=Manishearth
3079b23 
Update `icu_list` dependency to 2.3

This removes the `icu_collections` transitive dependency, and uses the smaller `icu_locale_fallback` instead of `icu_locale`.

r? manishearth
This was referenced Sep 1, 2026
Closed
Merged
@Kobzol

Kobzol commented Sep 1, 2026

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 1, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
@bors
Auto merge of #161287 - robertbastian:23, r=<try>
6b4d1a6 
Update `icu_list` dependency to 2.3
rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
@bors
Auto merge of #162148 - JonathanBrouwer:rollup-Be980n8, r=JonathanBro…
5db7f4b 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #151618 (rustdoc: add `--print` option)
 - #161287 (Update `icu_list` dependency to 2.3)
 - #161767 (change DEFAULT_STACK_SIZE to be 32MB on s390x)
 - #161968 (Diverse offload fixes)
 - #161971 (Remove -Zsaturating-float-casts flag)
 - #162071 (Fix ICE of getting item name from RPITIT)
 - #161209 (Rework `next_power_of_two` to always be `1 << …`)
 - #162073 (Change some `Infallible` to `!` in std)
 - #162086 (Remove `gate_check` from `AttributeStability::Unstable`)
 - #162102 (`alloc` crate: shrink undocumented `unsafe` blocks)
 - #162110 (make it clear that Range cannot represent arbitrary ranges)
@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 6b4d1a6 (6b4d1a61833530df918334442a63f42f18079a2c)
Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6b4d1a6): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary -2.5%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 -2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 473.301s -> 475.524s (0.47%)
Artifact size: 400.69 MiB -> 400.50 MiB (-0.05%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 1, 2026
@rust-bors
rust-bors Bot merged commit fdfd0e0 into rust-lang:main Sep 1, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 1, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
@bors
Unrolled build for #161287 in rollup 162148
a6eb27e 
Rollup merge of #161287 - robertbastian:23, r=Manishearth

Update `icu_list` dependency to 2.3

This removes the `icu_collections` transitive dependency, and uses the smaller `icu_locale_fallback` instead of `icu_locale`.

r? manishearth
@robertbastian
robertbastian deleted the 23 branch September 2, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees

@Manishearth Manishearth

Labels

A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

6 participants

@robertbastian @rustbot @rust-log-analyzer @Manishearth @Kobzol @rust-timer