Skip to content

Improve powerpc-types.rs test #161191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Aug 17, 2026
Merged

Improve powerpc-types.rs test #161191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 55 additions & 40 deletions tests/assembly-llvm/asm/powerpc-types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// ignore-tidy-file-linelength (some revision //@ lines are over 100 chars long)

//@ add-minicore
//@ revisions: powerpc powerpc_altivec powerpc_vsx powerpc_power8 powerpc64 powerpc64_vsx powerpc64_power8 powerpc64le
//@ revisions: powerpc powerpc_altivec powerpc_vsx powerpc_power9 powerpc64 powerpc64_vsx powerpc64_power9 powerpc64le powerpc64le_power9
//@ assembly-output: emit-asm

//@[powerpc] compile-flags: --target powerpc-unknown-linux-gnu
//@[powerpc] needs-llvm-components: powerpc
//@[powerpc_altivec] compile-flags: --target powerpc-unknown-linux-gnu -C target-feature=+altivec --cfg altivec
Expand All @@ -11,25 +12,32 @@
//@[powerpc_vsx] compile-flags: --target powerpc-unknown-linux-gnu -C target-feature=+altivec,+vsx --cfg altivec --cfg vsx
//@[powerpc_vsx] needs-llvm-components: powerpc
//@[powerpc_vsx] filecheck-flags: --check-prefix altivec --check-prefix vsx
//@[powerpc_power8] compile-flags: --target powerpc-unknown-linux-gnu -C target-feature=+altivec,+vsx,+power8-vector --cfg altivec --cfg vsx --cfg power8
//@[powerpc_power8] needs-llvm-components: powerpc
//@[powerpc_power8] filecheck-flags: --check-prefix altivec --check-prefix vsx --check-prefix power8
//@[powerpc_power9] compile-flags: --target powerpc-unknown-linux-gnu -C target-feature=+altivec,+vsx,+power9-vector --cfg altivec --cfg vsx --cfg power9 --cfg power9be
//@[powerpc_power9] needs-llvm-components: powerpc
//@[powerpc_power9] filecheck-flags: --check-prefix altivec --check-prefix vsx --check-prefix power9 --check-prefix power9be

//@[powerpc64] compile-flags: --target powerpc64-unknown-linux-gnu --cfg altivec
//@[powerpc64] needs-llvm-components: powerpc
//@[powerpc64] filecheck-flags: --check-prefix altivec
//@[powerpc64_vsx] compile-flags: --target powerpc64-unknown-linux-gnu -C target-feature=+vsx --cfg powerpc64 --cfg altivec --cfg vsx
//@[powerpc64_vsx] needs-llvm-components: powerpc
//@[powerpc64_vsx] filecheck-flags: --check-prefix powerpc64 --check-prefix altivec --check-prefix vsx
//@[powerpc64_power8] compile-flags: --target powerpc64-unknown-linux-gnu -C target-feature=+vsx,+power8-vector --cfg powerpc64 --cfg altivec --cfg vsx --cfg power8
//@[powerpc64_power8] needs-llvm-components: powerpc
//@[powerpc64_power8] filecheck-flags: --check-prefix powerpc64 --check-prefix altivec --check-prefix vsx --check-prefix power8
//@[powerpc64le] compile-flags: --target powerpc64le-unknown-linux-gnu --cfg powerpc64 --cfg altivec --cfg vsx --cfg power8
//@[powerpc64_power9] compile-flags: --target powerpc64-unknown-linux-gnu -C target-feature=+vsx,+power9-vector --cfg powerpc64 --cfg altivec --cfg vsx --cfg power9 --cfg power9be
//@[powerpc64_power9] needs-llvm-components: powerpc
//@[powerpc64_power9] filecheck-flags: --check-prefix powerpc64 --check-prefix altivec --check-prefix vsx --check-prefix power9 --check-prefix=power9be

//@[powerpc64le] compile-flags: --target powerpc64le-unknown-linux-gnu --cfg powerpc64 --cfg altivec --cfg vsx
//@[powerpc64le] needs-llvm-components: powerpc
//@[powerpc64le] filecheck-flags: --check-prefix powerpc64 --check-prefix altivec --check-prefix vsx --check-prefix power8
//@ compile-flags: -Zmerge-functions=disabled -O
//@ compile-flags: --check-cfg=cfg(altivec,vsx,power8)
//@[powerpc64le] filecheck-flags: --check-prefix powerpc64 --check-prefix altivec --check-prefix vsx
//@[powerpc64le_power9] compile-flags: --target powerpc64le-unknown-linux-gnu -C target-feature=+power9-vector --cfg powerpc64 --cfg altivec --cfg vsx --cfg power9
//@[powerpc64le_power9] needs-llvm-components: powerpc
//@[powerpc64le_power9] filecheck-flags: --check-prefix powerpc64 --check-prefix altivec --check-prefix vsx --check-prefix power9

#![feature(no_core)]
//@ compile-flags: -Zmerge-functions=disabled -Copt-level=3
//@ compile-flags: --check-cfg=cfg(altivec,vsx,power9,power9be)

#![feature(no_core, f16)]
#![cfg_attr(vsx, feature(f128))]
#![crate_type = "rlib"]
#![no_core]
#![allow(asm_sub_register, non_camel_case_types, unused_imports)]
Expand All @@ -48,41 +56,44 @@ compile_error!("altivec cfg and target feature mismatch");
#[cfg_attr(vsx, cfg(not(target_feature = "vsx")))]
#[cfg_attr(not(vsx), cfg(target_feature = "vsx"))]
compile_error!("vsx cfg and target feature mismatch");
#[cfg_attr(power8, cfg(not(target_feature = "power8-vector")))]
#[cfg_attr(not(power8), cfg(target_feature = "power8-vector"))]
compile_error!("power8-vector cfg and target feature mismatch");

// Check floating point scalars are put in the right vector lane. This uses power8 for consistent
#[cfg_attr(power9, cfg(not(target_feature = "power9-vector")))]
#[cfg_attr(not(power9), cfg(target_feature = "power9-vector"))]
compile_error!("power9-vector cfg and target feature mismatch");
#[cfg_attr(power9be, cfg(not(all(target_feature = "power9-vector", target_endian = "big"))))]
#[cfg_attr(not(power9be), cfg(all(target_feature = "power9-vector", target_endian = "big")))]
compile_error!("power9be cfg and target feature mismatch");

// Check floating point scalars are put in the right vector lane. This uses power9 for consistent
// assembly between powerpc64le and big-endian powerpc/powerpc64.

// power8-LABEL: f32_to_f64:
// power8: .cfi_startproc
// power8-NEXT: xscvdpspn [[#INPUT:]], 1
// powerpc64le-NEXT: vmrgow [[#INPUT - 32]], [[#INPUT - 32]], [[#INPUT - 32]]
// power8-NEXT: #APP
// power8-NEXT: xscvspdp 1, [[#INPUT]]
// power8-NEXT: #NO_APP
// power8-NEXT: blr
#[cfg(power8)]
// power9-LABEL: f32_to_f64:
// power9: .cfi_startproc
// power9-NEXT: xscvdpspn [[#INPUT:]], 1
// powerpc64le_power9-NEXT: vmrgow [[#INPUT - 32]], [[#INPUT - 32]], [[#INPUT - 32]]
// power9-NEXT: #APP
// power9-NEXT: xscvspdp 1, [[#INPUT]]
// power9-NEXT: #NO_APP
// power9-NEXT: blr
#[cfg(power9)]
#[unsafe(no_mangle)]
pub fn f32_to_f64(x: f32) -> f64 {
pub extern "C" fn f32_to_f64(x: f32) -> f64 {
let res;
unsafe {
asm!("xscvspdp {}, {}", out(vsreg) res, in(vsreg) x, options(pure, nostack, nomem));
};
res
}

// power8-LABEL: f64_to_f32:
// power8: .cfi_startproc
// power8-NEXT: #APP
// power8-NEXT: xscvdpsp [[#OUTPUT:]], 1
// power8-NEXT: #NO_APP
// power8-NEXT: xscvspdpn 1, [[#OUTPUT]]
// power8-NEXT: blr
#[cfg(power8)]
// power9-LABEL: f64_to_f32:
// power9: .cfi_startproc
// power9-NEXT: #APP
// power9-NEXT: xscvdpsp [[#OUTPUT:]], 1
// power9-NEXT: #NO_APP
// power9-NEXT: xscvspdpn 1, [[#OUTPUT]]
// power9-NEXT: blr
#[cfg(power9)]
#[unsafe(no_mangle)]
pub fn f64_to_f32(x: f64) -> f32 {
pub extern "C" fn f64_to_f32(x: f64) -> f32 {
let res;
unsafe {
asm!("xscvdpsp {}, {}", out(vsreg) res, in(vsreg) x, options(pure, nostack, nomem));
Expand All @@ -92,18 +103,22 @@ pub fn f64_to_f32(x: f64) -> f32 {

macro_rules! check { ($func:ident, $ty:ty, $class:ident, $mov:literal) => {
#[unsafe(no_mangle)]
pub unsafe fn $func(x: $ty) -> $ty {
// FIXME(f128): Replace `&$ty` with `$ty` once
// https://github.com/llvm/llvm-project/issues/213355 is fixed.
Comment on lines +106 to +107

@folkertdev folkertdev Aug 16, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc our target maintainers @daltenty @gilamn5tr @amy-kwan in general, but also specifically for

That looks like it should be straightforward to fix?

View changes since the review

@beetrees beetrees Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM fix PR: llvm/llvm-project#216613

pub unsafe fn $func(x: &$ty) -> $ty {
let y;
asm!(concat!($mov," {}, {}"), out($class) y, in($class) x);
asm!(concat!($mov," {}, {}"), out($class) y, in($class) *x);
y
}
};}

macro_rules! check_reg { ($func:ident, $ty:ty, $rego:tt, $regc:tt, $mov:literal) => {
#[unsafe(no_mangle)]
pub unsafe fn $func(x: $ty) -> $ty {
// FIXME(f128): Replace `&$ty` with `$ty` once
// https://github.com/llvm/llvm-project/issues/213355 is fixed.
pub unsafe fn $func(x: &$ty) -> $ty {
let y;
asm!(concat!($mov, " ", $rego, ", ", $rego), lateout($regc) y, in($regc) x);
asm!(concat!($mov, " ", $rego, ", ", $rego), lateout($regc) y, in($regc) *x);
y
}
};}
Expand Down
Loading