Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making raw source display better #16066

Closed
wants to merge 1 commit into from

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Jul 29, 2014

Summary of changes:

  • Make the code fill up the full width of the page (no massive whitespace on the left)
  • Move the code down to make it not intersect the logo
  • Set a min-width and remove the max-width so that the code doesn't scroll internally, but instead scrolls the page, meaning horizontal scroll bars are always available
  • Set overflow to actually overflow, just to be sure

Fixes #15891

two-screen
wide-screen

@lilyball
Copy link
Contributor

What does the page look like once you start typing in the search field? Does it still look correct?

Do you have a live version of this somewhere?

@Gankra
Copy link
Contributor Author

Gankra commented Jul 29, 2014

@kballard: Unfortunately, I can't build Rust tonight. I've only tested these changes by editing the css via Firefox's inspect element utility. Unfortunately doing this at all (even if I just inject an empty style tag) seems to break the search feature completely. So, inconclusive for now, I'm afraid.

I can do a build in the morning, though. Is the output of docs completely statically hostable? If so I can host the build, too.

@lilyball
Copy link
Contributor

@gankro AFAIK the output of docs is statically hostable. I haven't actually experimented with that myself though, but it's supposed to work over file:// just as well as it does http://.

@Gankra
Copy link
Contributor Author

Gankra commented Jul 29, 2014

@kballard: great, I should hopefully have it up by noon tomorrow.

@Gankra
Copy link
Contributor Author

Gankra commented Jul 29, 2014

@alexcrichton
Copy link
Member

Can you copy the description of the PR into the commit message as well? The commit message is often looked at more than the PR message (for historical purposes)

* Make the code fill up the full width of the page (no massive whitespace on the left)
* Move the code down to make it not intersect the logo
* Set a min-width and remove the max-width so that the code doesn't scroll internally, but instead scrolls the page, meaning horizontal scroll bars are always available
* Set overflow to actually overflow, just to be sure

Fixes rust-lang#15891
@Gankra
Copy link
Contributor Author

Gankra commented Jul 29, 2014

@alexcrichton done

@lilyball
Copy link
Contributor

LGTM

@Gankra Gankra deleted the code-display-fix branch August 18, 2014 19:38
notriddle added a commit to notriddle/rust that referenced this pull request Dec 29, 2022
When added in 7669f04 / rust-lang#16066, the page
itself was set to scroll. Now it's set so that the `example-wrap` is
scrolling inside the page, so the overflow setting for the content is
irrelevant.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 30, 2022
…-overflow, r=GuillaumeGomez

rustdoc: remove redundant CSS `.source .content { overflow: visible }`

When added in 7669f04 / rust-lang#16066, the page itself was set to scroll. Now it's set so that the `example-wrap` is scrolling inside the page, so the overflow setting for the content is irrelevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source code browser horizontal scroll bar is hard to find
4 participants