Skip to content

tidy: Update Python version requirements to 3.10 #160429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Aug 8, 2026
Merged

tidy: Update Python version requirements to 3.10 #160429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tools/tidy/config/requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# requirements.in This is the source file for our pinned version requirements
# file "requirements.txt" To regenerate that file, pip-tools is required
# (`python -m pip install pip-tools==7.4.1`). Once installed, run: `pip-compile
# (`python -m pip install pip-tools==7.5.3`). Once installed, run: `pip-compile

@marcoieni marcoieni Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to update the version, otherwise the header of requirements.txt was changing to:

#    pip-compile --cert=None --client-cert=None --generate-hashes --index-url=None --pip-args=None --strip-extras src/tools/tidy/config/requirements.in

you can verify by running:

docker run --rm \
  -v "$PWD":/workspace \
  -w /workspace \
  python:3.10-slim \
  bash -c '
    python -m pip install --no-cache-dir \
      pip-tools==7.4.1 \
      &&
    pip-compile --generate-hashes --strip-extras \
      src/tools/tidy/config/requirements.in
  '

I didn't select the latest (7.6.0) because it has a bug and requires pinning more stuff.

View changes since the review

# --generate-hashes --strip-extras src/tools/tidy/config/requirements.in`
#
# Note: this generation step should be run with the oldest supported python
# version (currently 3.9) to ensure backward compatibility
# version (currently 3.10) to ensure backward compatibility

ruff==0.4.9
clang-format==18.1.7
2 changes: 1 addition & 1 deletion src/tools/tidy/config/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.9
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --generate-hashes --strip-extras src/tools/tidy/config/requirements.in
Expand Down
5 changes: 2 additions & 3 deletions src/tools/tidy/src/extra_checks/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ mod rustdoc_js;
#[cfg(test)]
mod tests;

const MIN_PY_REV: (u32, u32) = (3, 9);
const MIN_PY_REV_STR: &str = "≥3.9";
const MIN_PY_REV: (u32, u32) = (3, 10);
const MIN_PY_REV_STR: &str = "≥3.10";

/// Path to find the python executable within a virtual environment
#[cfg(target_os = "windows")]
Expand Down Expand Up @@ -568,7 +568,6 @@ fn create_venv_at_path(path: &Path) -> Result<(), Error> {
"python3.12",
"python3.11",
"python3.10",
"python3.9",

@marcoieni marcoieni Aug 3, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was removed in the previous EOL bump: #126448

View changes since the review

"python3",
"python",
"python3.14",
Expand Down
Loading