update ambiguous_glob_imported_trait lint explanation and example. - #160354
Merged
rust-bors[bot] merged 1 commit intoAug 26, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @ShoyuVanilla. Use Why was this reviewer chosen?The reviewer was selected based on:
|
LorrensP-2158466
force-pushed
the
amb-import-trait-update
branch
from
August 1, 2026 19:40
729e069 to
1ea66a6
Compare
petrochenkov
reviewed
Aug 2, 2026
LorrensP-2158466
force-pushed
the
amb-import-trait-update
branch
from
August 2, 2026 16:11
1ea66a6 to
b6edc07
Compare
Contributor
Author
|
It has been 3 weeks so I'l reroll, @rustbot reroll |
ShoyuVanilla
approved these changes
Aug 26, 2026
Member
There was a problem hiding this comment.
Sorry, I meant to review this PR, but it somehow slipped through the cracks 😢
Make sense to me. Thanks!
@bors r+ rollup
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
Author
Oh no problem! I didn't want to push, I understand that reviewing takes a lot of energy/time. Thanks for the quick response! |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
…uwer Rollup of 7 pull requests Successful merges: - #161433 (Overhaul `rustc_middle::query`) - #158370 (rewrite never type documentation) - #160354 (update `ambiguous_glob_imported_trait` lint explanation and example.) - #161447 (Construct paramenvs from an iterator) - #161707 (pattern_type: make print format match the current syntax) - #161773 (Update WASI targets to wasi-sdk-34) - #161807 (bootstrap: skip StdarchVerify when remote testing is enabled)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
Rollup merge of #160354 - LorrensP-2158466:amb-import-trait-update, r=ShoyuVanilla update `ambiguous_glob_imported_trait` lint explanation and example. In the tracking issue for the `ambiguous_glob_imported_trait` #152822 someone reported that the explanation is lacking/confusing since #159599. Explanation and example are extended in this pr.
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 27, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#161433 (Overhaul `rustc_middle::query`) - rust-lang/rust#158370 (rewrite never type documentation) - rust-lang/rust#160354 (update `ambiguous_glob_imported_trait` lint explanation and example.) - rust-lang/rust#161447 (Construct paramenvs from an iterator) - rust-lang/rust#161707 (pattern_type: make print format match the current syntax) - rust-lang/rust#161773 (Update WASI targets to wasi-sdk-34) - rust-lang/rust#161807 (bootstrap: skip StdarchVerify when remote testing is enabled)
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 28, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#161433 (Overhaul `rustc_middle::query`) - rust-lang/rust#158370 (rewrite never type documentation) - rust-lang/rust#160354 (update `ambiguous_glob_imported_trait` lint explanation and example.) - rust-lang/rust#161447 (Construct paramenvs from an iterator) - rust-lang/rust#161707 (pattern_type: make print format match the current syntax) - rust-lang/rust#161773 (Update WASI targets to wasi-sdk-34) - rust-lang/rust#161807 (bootstrap: skip StdarchVerify when remote testing is enabled)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the tracking issue for the
ambiguous_glob_imported_trait#152822 someone reported that the explanation is lacking/confusing since #159599.Explanation and example are extended in this pr.