No more tests/ui/issues!

tests/ui/README.md

@@ -770,10 +770,6 @@ Tests for the `{std,core}::intrinsics`, internal implementation detail.
 
 Tests for I/O related behaviour, covering stdout/stderr handling and error propagation.
 
-## `tests/ui/issues/`: Tests directly related to GitHub issues
-
-**FIXME (#133895)**: Random collection of regression tests and tests for issues, tests in this directory should be audited and rehomed.
-
 ## `tests/ui/iterators/`
 
 These tests revolve around anything to do with iterators, e.g. mismatched types.

tests/ui/issues/issue-37291/auxiliary/lib.rs → tests/ui/coherence/auxiliary/cross-crate-specialization-check.rs

@@ -1,3 +1,5 @@
+//! Auxiliary file for <https://github.com/rust-lang/rust/issues/37291>.
+
 #![crate_type = "lib"]
 
 use std::ops::Mul;

tests/ui/coherence/cross-crate-specialization-check.rs

@@ -0,0 +1,24 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/37291>.
+//!
+//! The problem was that the starting environment for a specialization
+//! check was not including the where-clauses from the impl when attempting
+//! to normalize the impl's trait-ref, so things like `<C as Foo>::Item`
+//! could not resolve, since the `C: Foo` trait bound was not included in
+//! the environment.
+
+//@ aux-build:cross-crate-specialization-check.rs
+//@ run-pass
+
+#![allow(unused_imports)]
+
+extern crate cross_crate_specialization_check;
+
+use cross_crate_specialization_check::{CV, WrapperB, WrapperC};
+
+fn main() {
+    let a = WrapperC(CV);
+    let b = WrapperC(CV);
+    if false {
+        let _ = a * b;
+    }
+}

tests/ui/crate-loading/missing-target-no-std-error.rs

@@ -0,0 +1,15 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/49851>.
+//! Test compiling for a target which is not installed with `no_std`
+//! results in a helpful error message.
+//~^^^ ERROR can't find crate for `core`
+
+//@ compile-flags: --target thumbv7em-none-eabihf
+//@ needs-llvm-components: arm
+//@ ignore-backends: gcc
+#![deny(unsafe_code)]
+#![deny(warnings)]
+#![no_std]
+
+extern crate cortex_m;
+
+fn main() {}

tests/ui/cross-crate/auxiliary/cross-crate-array-len.rs

@@ -0,0 +1,2 @@
+//! Auxiliary file for <https://github.com/rust-lang/rust/issues/38875>.
+pub const FOO: usize = *&0;

tests/ui/cross-crate/cross-crate-array-len.rs

@@ -0,0 +1,11 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/38875>.
+//! This used to check `constant evaluation error` span doesn't point
+//! on nothing when const is defined in another crate.
+//@ aux-build:cross-crate-array-len.rs
+//@ check-pass
+
+extern crate cross_crate_array_len;
+
+fn main() {
+    let test_x = [0; cross_crate_array_len::FOO];
+}

tests/ui/deref/option-result-as_deref.rs

@@ -0,0 +1,12 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/50264>.
+
+fn main() {
+    let _m = &Some(42).as_deref();
+//~^ ERROR the method
+    let _e = &mut Some(42).as_deref_mut();
+//~^ ERROR the method
+    let _o = &Ok(42).as_deref();
+//~^ ERROR the method
+    let _w = &mut Ok(42).as_deref_mut();
+//~^ ERROR the method
+}

tests/ui/deref/option-result-as_deref.stderr

@@ -0,0 +1,39 @@
+error[E0599]: the method `as_deref` exists for enum `Option<{integer}>`, but its trait bounds were not satisfied
+  --> $DIR/option-result-as_deref.rs:4:24
+   |
+LL |     let _m = &Some(42).as_deref();
+   |                        ^^^^^^^^
+   |
+   = note: the following trait bounds were not satisfied:
+           `{integer}: Deref`
+
+error[E0599]: the method `as_deref_mut` exists for enum `Option<{integer}>`, but its trait bounds were not satisfied
+  --> $DIR/option-result-as_deref.rs:6:28
+   |
+LL |     let _e = &mut Some(42).as_deref_mut();
+   |                            ^^^^^^^^^^^^
+   |
+   = note: the following trait bounds were not satisfied:
+           `{integer}: Deref`
+
+error[E0599]: the method `as_deref` exists for enum `Result<{integer}, _>`, but its trait bounds were not satisfied
+  --> $DIR/option-result-as_deref.rs:8:22
+   |
+LL |     let _o = &Ok(42).as_deref();
+   |                      ^^^^^^^^
+   |
+   = note: the following trait bounds were not satisfied:
+           `{integer}: Deref`
+
+error[E0599]: the method `as_deref_mut` exists for enum `Result<{integer}, _>`, but its trait bounds were not satisfied
+  --> $DIR/option-result-as_deref.rs:10:26
+   |
+LL |     let _w = &mut Ok(42).as_deref_mut();
+   |                          ^^^^^^^^^^^^
+   |
+   = note: the following trait bounds were not satisfied:
+           `{integer}: Deref`
+
+error: aborting due to 4 previous errors
+
+For more information about this error, try `rustc --explain E0599`.

tests/ui/issues/issue-41652/auxiliary/issue-41652-b.rs → tests/ui/error-emitter/auxiliary/no-method-empty-span.rs

@@ -1,3 +1,5 @@
+//! Auxiliary file for <https://github.com/rust-lang/rust/issues/41652>.
+
 pub trait Tr {
     // Note: The function needs to be declared over multiple lines to reproduce
     // the crash. DO NOT reformat.

tests/ui/error-emitter/no-method-empty-span.rs

@@ -0,0 +1,17 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/41652>.
+//! This used to ICE on empty string indexing internally, which came from
+//! empty code span in error message, when method cannot be found.
+//@ aux-build:no-method-empty-span.rs
+
+extern crate no_method_empty_span;
+
+struct S;
+
+impl no_method_empty_span::Tr for S {
+    fn f() {
+        3.f()
+        //~^ ERROR can't call method `f` on ambiguous numeric type `{integer}`
+    }
+}
+
+fn main() {}

tests/ui/issues/issue-41652/issue-41652.stderr → tests/ui/error-emitter/no-method-empty-span.stderr

@@ -1,5 +1,5 @@
 error[E0689]: can't call method `f` on ambiguous numeric type `{integer}`
-  --> $DIR/issue-41652.rs:9:11
+  --> $DIR/no-method-empty-span.rs:12:11
    |
 LL |         3.f()
    |           ^

tests/ui/issues/issue-50865-private-impl-trait/auxiliary/lib.rs → tests/ui/impl-trait/auxiliary/reachable-private-fn-codegen.rs

@@ -1,3 +1,4 @@
+//! Auxiliary file for <https://github.com/rust-lang/rust/issues/50865>.
 //@ revisions: default miropt
 //@[miropt]compile-flags: -Z mir-opt-level=3
 // ~^ This flag is for #77668, it used to be ICE.

tests/ui/impl-trait/reachable-private-fn-codegen.rs

@@ -0,0 +1,16 @@
+//! Regression test for <https://github.com/rust-lang/rust/issues/50865>.
+//! When using generics or specifying the type directly, this example
+//! codegens `foo` internally. However, when using a private `impl Trait`
+//! function which references another private item, `foo` (in this case)
+//! wouldn't be codegenned until main.rs used `bar`, as with impl Trait
+//! it is not cast to `fn()` automatically to satisfy e.g.
+//! `fn foo() -> fn() { ... }`.
+//@ run-pass
+//@ aux-build:reachable-private-fn-codegen.rs
+
+
+extern crate reachable_private_fn_codegen;
+
+fn main() {
+    reachable_private_fn_codegen::bar(()); // Error won't happen if bar is called from same crate
+}