Skip to content

[perf] move attrs out of rustc_hir #159870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mejrs wants to merge 2 commits into from
Closed

[perf] move attrs out of rustc_hir #159870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50acd9f
move stuff
mejrs Jul 24, 2026
539d4a6
fix everything
mejrs Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3708,6 +3708,24 @@ dependencies = [
"thin-vec",
]

[[package]]
name = "rustc_attr_ir"
version = "0.0.0"
dependencies = [
"rustc_abi",
"rustc_ast",
"rustc_ast_pretty",
"rustc_data_structures",
"rustc_error_messages",
"rustc_macros",
"rustc_serialize",
"rustc_span",
"rustc_target",
"smallvec",
"thin-vec",
"tracing",
]

[[package]]
name = "rustc_attr_parsing"
version = "0.0.0"
Expand Down Expand Up @@ -4085,7 +4103,7 @@ dependencies = [
"rustc_abi",
"rustc_arena",
"rustc_ast",
"rustc_ast_pretty",
"rustc_attr_ir",
"rustc_data_structures",
"rustc_error_messages",
"rustc_errors",
Expand All @@ -4097,8 +4115,6 @@ dependencies = [
"rustc_serialize",
"rustc_span",
"rustc_target",
"smallvec",
"thin-vec",
"tracing",
]

Expand Down
7 changes: 3 additions & 4 deletions compiler/rustc_ast_lowering/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2276,7 +2276,8 @@ impl<'hir> LoweringContext<'_, 'hir> {
let hir_id = self.lower_node_id(param.id);
let param_attrs = &param.attrs;
let param_span = param.span();
let param = hir::GenericParam {
self.lower_attrs(hir_id, param_attrs, param_span, Target::from_generic_param(&param));
hir::GenericParam {
hir_id,
def_id: self.local_def_id(param.id),
name,
Expand All @@ -2285,9 +2286,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
kind,
colon_span: param.colon_span.map(|s| self.lower_span(s)),
source,
};
self.lower_attrs(hir_id, param_attrs, param_span, Target::from_generic_param(&param));
param
}
}

fn lower_generic_param_kind(
Expand Down
20 changes: 20 additions & 0 deletions compiler/rustc_attr_ir/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
[package]
name = "rustc_attr_ir"
version = "0.0.0"
edition = "2024"

[dependencies]
# tidy-alphabetical-start
rustc_abi = { path = "../rustc_abi" }
rustc_ast = { path = "../rustc_ast" }
rustc_ast_pretty = { path = "../rustc_ast_pretty" }
rustc_data_structures = { path = "../rustc_data_structures" }
rustc_error_messages = { path = "../rustc_error_messages" }
rustc_macros = { path = "../rustc_macros" }
rustc_serialize = { path = "../rustc_serialize" }
rustc_span = { path = "../rustc_span" }
rustc_target = { path = "../rustc_target" }
smallvec = { version = "1.8.1", features = ["union", "may_dangle"] }
thin-vec = "0.2.18"
tracing = "0.1"
# tidy-alphabetical-end
Loading
Loading