Skip to content

Use dylib build in distcheck - #159847

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:distcheck-shared
Jul 24, 2026
Merged

Use dylib build in distcheck#159847
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:distcheck-shared

Conversation

@nikic

@nikic nikic commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

This reduces disk usage, and thus avoids the distcheck job running out of disk space.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 24, 2026
@nikic

nikic commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=x86_64-gnu-distcheck

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 24, 2026
Use dylib build in distcheck


try-job: x86_64-gnu-distcheck
@nikic
nikic marked this pull request as ready for review July 24, 2026 18:22
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 24, 2026
@rustbot

rustbot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, marcoieni

@rust-bors

rust-bors Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: d35299c (d35299c508333496160ae148947ff35b2a275d8d)
Base parent: 29e68fe (29e68fe2295f8fc2feb52b8cb0b61a055842fdcf)

@Kobzol

Kobzol commented Jul 24, 2026

Copy link
Copy Markdown
Member

@bors r+ p=1 note="unblock CI"

@rust-bors

rust-bors Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1a4a07e has been approved by Kobzol

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 24, 2026
Use dylib build in distcheck

This reduces disk usage, and thus avoids the distcheck job running out of disk space.
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 24, 2026
@rust-bors

rust-bors Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 464b339 failed: CI. Failed job:

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-msvc-ext2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Kobzol

Kobzol commented Jul 24, 2026

Copy link
Copy Markdown
Member

@bors retry spurious error

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2026
@rust-bors

This comment has been minimized.

jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 24, 2026
Use dylib build in distcheck

This reduces disk usage, and thus avoids the distcheck job running out of disk space.
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 24, 2026
@rust-bors

rust-bors Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: Kobzol
Duration: 3h 28m 17s
Pushing da86f4d to main...

@rust-bors
rust-bors Bot merged commit da86f4d into rust-lang:main Jul 24, 2026
15 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 29e68fe (parent) -> da86f4d (this PR)

Test differences

Show 1 test diff

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard da86f4d0726be475afbbffe40cb2f65741c51ad3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc-core-tests: 26m 19s -> 8m 5s (-69.3%)
  2. dist-apple-various: 1h 19m -> 2h 3m (+55.3%)
  3. pr-check-1: 45m 56s -> 21m 22s (-53.5%)
  4. x86_64-gnu-llvm-22-1: 47m 28s -> 1h 12m (+51.9%)
  5. x86_64-gnu: 2h 41m -> 1h 30m (-44.2%)
  6. x86_64-gnu-miri: 1h 54m -> 1h 4m (-43.8%)
  7. x86_64-gnu-gcc: 1h 26m -> 50m 19s (-42.1%)
  8. x86_64-rust-for-linux: 1h 17m -> 44m 39s (-42.1%)
  9. dist-android: 20m 41s -> 28m 45s (+39.0%)
  10. dist-aarch64-linux: 2h 4m -> 2h 50m (+37.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (da86f4d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.104s -> 489.287s (0.24%)
Artifact size: 387.69 MiB -> 387.73 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants