Attribute documentation for cfg_attr, path, feature, doc, should_panic, expect, ignore, and used#159798
Attribute documentation for cfg_attr, path, feature, doc, should_panic, expect, ignore, and used#159798kantnero wants to merge 3 commits into
Conversation
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…c, expect, ignore, and used Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>
d5001d5 to
34f55b4
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Meta note: Instead of trying to add docs for more and more attributes at once in one PR, I think it would be more helpful & generally better to split your efforts into several smaller PRs going forward which each contain a small set of related attributes / just one attribute instead of a large mixed bag. That would make it a lot easier for reviewers since they wouldn't have to wade through 100 comments like in #158664 and context-switch constantly within the same PR. Consequently, it would mean your PRs can get merged a lot faster. Re. you closing #158664 I guess that was due to git / GitHub issues? In case it wasn't though, I want to say that it makes it harder to follow the progress & discussions for specific attributes since they're now spread across several PRs (one has 100 comments as I've already mentioned), esp. since there's no link from the old to the new PR. In any case, thanks for working on this! |
|
@fmease Initially sent the PR in twos, but I created each one before the last had merged, every new PR ended up showing the previous PR's changes too, not just its own. Diffs got confusing, so I just merged them into one PR against main instead. Going forward I'll wait for each one to merge before opening the next. |
Documents the cfg_attr, path, feature, doc, should_panic, expect, ignore, and used
Part of #157604
r? @GuillaumeGomez
cc @fmease @traviscross