optimization: don't look for diagnostic/canonical items without rustc_attrs enabled#159732
Open
mejrs wants to merge 1 commit into
Open
optimization: don't look for diagnostic/canonical items without rustc_attrs enabled#159732mejrs wants to merge 1 commit into
mejrs wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-author
Contributor
Author
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
optimization: don't look for diagnostic/canonical items without rustc_attrs enabled
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (a7e10cb): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.502s -> 488.835s (-0.14%) |
rustbot
removed
the
S-waiting-on-perf
Contributor
Author
|
Looks like this somewhat undid the (small) regression in #159344 (comment) cc @Urgau r? @nnethercote Do you think this is worthwhile? |
mejrs
marked this pull request as ready for review
July 22, 2026 20:13
rustbot
added
S-waiting-on-review
nnethercote
approved these changes
Jul 23, 2026
Contributor
There was a problem hiding this comment.
Looks like this somewhat undid the (small) regression in #159344 (comment) cc @Urgau
That PR slightly regressed large-workspace and externs. This PR slightly improves unused-warnings, which is a stress test with a bazillion warnings that is not representative of real-world code. Having said that, this change is trivial, so it's not like we're paying any cost. I'll let you decide if you want to merge it.
Contributor
|
@bors delegate=mejrs |
Contributor
|
✌️ @mejrs, you can now approve this pull request! If @nnethercote told you to " |
nnethercote
added
S-waiting-on-author
Contributor
Author
|
let's do it @bors r=nnethercote |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
optimization: don't look for diagnostic/canonical items without rustc_attrs enabled
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 742eacd failed: CI. Failed job:
|
Member
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 24, 2026
…cote optimization: don't look for diagnostic/canonical items without rustc_attrs enabled
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 24, 2026
…cote optimization: don't look for diagnostic/canonical items without rustc_attrs enabled
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
Rollup of 17 pull requests Successful merges: - #158168 (Added implementation on `set_permissions_nofollow` for all primary platforms) - #138618 (Support using const pointers in asm `const` operand) - #157962 (Function item should not be used as const arg) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159411 ([rustdoc] Correctly handle output options with --show-coverage) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159809 (Avoid `#[target_features]`) - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 25, 2026
…cote optimization: don't look for diagnostic/canonical items without rustc_attrs enabled
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 25, 2026
Rollup of 16 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Function item should not be used as const arg) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159411 ([rustdoc] Correctly handle output options with --show-coverage) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159809 (Avoid `#[target_features]`) - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 25, 2026
…cote optimization: don't look for diagnostic/canonical items without rustc_attrs enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.