Increase depth for float infer var fallback hack by adwinwhite · Pull Request #159646 · rust-lang/rust

adwinwhite · 2026-07-21T09:08:19Z

View all comments

Fixes rust-lang/trait-system-refactor-initiative#280

With this, the fallback hack works again in bevy-shaders@0.1.0 and bevy-multi@0.1.0.

Also added perf optimizations to the proof tree visitor.

r? @ShoyuVanilla
cc @lcnr

rustbot · 2026-07-21T09:08:23Z

changes to inspect_obligations.rs

cc @lcnr

lcnr · 2026-07-21T09:15:33Z

        // Avoid hang from exponentially growing proof trees (see `cycle-modulo-ambig-aliases.rs`).
-        // 3 is more than enough for all occurrences in practice (a.k.a. `Into`).
-        InspectConfig { max_depth: 3 }
+        // 4 is more than enough for all occurrences in practice (a.k.a. `Into`).


saying "more than enough" while it's really exactly enough feels questionable 🤣

NestedObligationsForSelfTy uses max_depth: 5 🤔 maybe have a free constant MAX_DEPTH_FOR_OBLIGATIONS_VISITORS in this module. I would use the same comment as in that other visitor/put the comment on that constant

View changes since the review

lcnr

we can also use pending_obligations_potentially_referencing_sub_root before visiting any of them

View changes since this review

lcnr · 2026-07-21T09:16:22Z

please start a perf run after the nits :>

rustbot · 2026-07-22T03:36:26Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

adwinwhite · 2026-07-22T03:36:43Z

@bors try @rust-timer queue

Increase depth for float infer var fallback hack

adwinwhite · 2026-07-22T03:37:46Z

@bors try cancel

rust-bors · 2026-07-22T03:37:49Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/29888896422

adwinwhite · 2026-07-22T03:40:15Z

@bors try @rust-timer queue

Increase depth for float infer var fallback hack

rust-bors · 2026-07-22T05:44:55Z

☀️ Try build successful (CI)
Build commit: 99b59f8 (99b59f8fba71d921443a3eabc97ef72f063bbcf9)
Base parent: b9ee8d8 (b9ee8d8bcb1e4c7905a183a37e6d984c4b9a8468)

rust-timer · 2026-07-22T06:25:13Z

Finished benchmarking commit (99b59f8): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.0%	[-5.0%, -5.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 486.905s -> 486.578s (-0.07%)
Artifact size: 387.85 MiB -> 387.87 MiB (0.00%)

lcnr · 2026-07-22T08:29:55Z

@bors r+ rollup

rust-bors · 2026-07-22T08:29:58Z

📌 Commit 490b344 has been approved by lcnr

It is now in the queue for this repository.

ShoyuVanilla

Though I'm late for the party but looks good to me as well 😅

View changes since this review

@ShoyuVanilla

Increase depth for float infer var fallback hack Fixes rust-lang/trait-system-refactor-initiative#280 With this, the fallback hack works again in `bevy-shaders@0.1.0` and `bevy-multi@0.1.0`. Also added perf optimizations to the proof tree visitor. r? @ShoyuVanilla cc @lcnr

@ShoyuVanilla

Increase depth for float infer var fallback hack Fixes rust-lang/trait-system-refactor-initiative#280 With this, the fallback hack works again in `bevy-shaders@0.1.0` and `bevy-multi@0.1.0`. Also added perf optimizations to the proof tree visitor. r? @ShoyuVanilla cc @lcnr

…uwer Rollup of 8 pull requests Successful merges: - #159712 (Subtree sync for rustc_codegen_cranelift) - #155697 (Stabilize c-variadic function definitions) - #159285 (Simplify `apply_effects_in_range`) - #159607 (test: update riscv32e-registers.rs for LLVM 24 MC diagnostic changes) - #159659 (Move `Limit` out of `rustc_hir`) - #159451 (Remove config cloning in compiletest) - #159646 (Increase depth for float infer var fallback hack) - #159705 (bootstrap: Prefer `cfg!(not(test))` when skipping code paths during unit tests)

@ShoyuVanilla

Increase depth for float infer var fallback hack Fixes rust-lang/trait-system-refactor-initiative#280 With this, the fallback hack works again in `bevy-shaders@0.1.0` and `bevy-multi@0.1.0`. Also added perf optimizations to the proof tree visitor. r? @ShoyuVanilla cc @lcnr

…uwer Rollup of 12 pull requests Successful merges: - #159712 (Subtree sync for rustc_codegen_cranelift) - #155697 (Stabilize c-variadic function definitions) - #159285 (Simplify `apply_effects_in_range`) - #159596 (unify the AST repr of type const and const RHS) - #159607 (test: update riscv32e-registers.rs for LLVM 24 MC diagnostic changes) - #159659 (Move `Limit` out of `rustc_hir`) - #159707 (fix error when a dangling ref in a ManuallyDrop is used in a pattern) - #158479 (Reject static item as direct const generic arg) - #158738 (next_trait_solver: Recover from GCE const exprs) - #159451 (Remove config cloning in compiletest) - #159646 (Increase depth for float infer var fallback hack) - #159705 (bootstrap: Prefer `cfg!(not(test))` when skipping code paths during unit tests)

…uwer Rollup of 11 pull requests Successful merges: - #159712 (Subtree sync for rustc_codegen_cranelift) - #155697 (Stabilize c-variadic function definitions) - #159285 (Simplify `apply_effects_in_range`) - #159596 (unify the AST repr of type const and const RHS) - #159607 (test: update riscv32e-registers.rs for LLVM 24 MC diagnostic changes) - #159659 (Move `Limit` out of `rustc_hir`) - #159707 (fix error when a dangling ref in a ManuallyDrop is used in a pattern) - #158738 (next_trait_solver: Recover from GCE const exprs) - #159451 (Remove config cloning in compiletest) - #159646 (Increase depth for float infer var fallback hack) - #159705 (bootstrap: Prefer `cfg!(not(test))` when skipping code paths during unit tests)

@ShoyuVanilla

Rollup merge of #159646 - adwinwhite:fix-f16-hack, r=lcnr Increase depth for float infer var fallback hack Fixes rust-lang/trait-system-refactor-initiative#280 With this, the fallback hack works again in `bevy-shaders@0.1.0` and `bevy-multi@0.1.0`. Also added perf optimizations to the proof tree visitor. r? @ShoyuVanilla cc @lcnr

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#159712 (Subtree sync for rustc_codegen_cranelift) - rust-lang/rust#155697 (Stabilize c-variadic function definitions) - rust-lang/rust#159285 (Simplify `apply_effects_in_range`) - rust-lang/rust#159596 (unify the AST repr of type const and const RHS) - rust-lang/rust#159607 (test: update riscv32e-registers.rs for LLVM 24 MC diagnostic changes) - rust-lang/rust#159659 (Move `Limit` out of `rustc_hir`) - rust-lang/rust#159707 (fix error when a dangling ref in a ManuallyDrop is used in a pattern) - rust-lang/rust#158738 (next_trait_solver: Recover from GCE const exprs) - rust-lang/rust#159451 (Remove config cloning in compiletest) - rust-lang/rust#159646 (Increase depth for float infer var fallback hack) - rust-lang/rust#159705 (bootstrap: Prefer `cfg!(not(test))` when skipping code paths during unit tests)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 21, 2026

rustbot assigned ShoyuVanilla Jul 21, 2026

lcnr reviewed Jul 21, 2026

View reviewed changes

adwinwhite force-pushed the fix-f16-hack branch from 37fe576 to fc32333 Compare July 22, 2026 03:36

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2026

rust-bors Bot pushed a commit that referenced this pull request Jul 22, 2026

Auto merge of #159646 - adwinwhite:fix-f16-hack, r=<try>

007fb26

Increase depth for float infer var fallback hack

This comment was marked as outdated.

Sign in to view

increase depth for float fallback hack visitor

490b344

adwinwhite force-pushed the fix-f16-hack branch from fc32333 to 490b344 Compare July 22, 2026 03:39

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 22, 2026

Auto merge of #159646 - adwinwhite:fix-f16-hack, r=<try>

99b59f8

Increase depth for float infer var fallback hack

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2026

ShoyuVanilla approved these changes Jul 22, 2026

View reviewed changes

JonathanBrouwer mentioned this pull request Jul 22, 2026

Rollup of 4 pull requests #159709

Closed

JonathanBrouwer mentioned this pull request Jul 22, 2026

Rollup of 8 pull requests #159715

Closed

JonathanBrouwer mentioned this pull request Jul 22, 2026

Rollup of 12 pull requests #159723

Closed

JonathanBrouwer mentioned this pull request Jul 22, 2026

Rollup of 11 pull requests #159728

Merged

rust-bors Bot merged commit 0159af3 into rust-lang:main Jul 22, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 22, 2026

lcnr mentioned this pull request Jul 24, 2026

Stabilize the next-generation trait solver rust-lang/rust-project-goals#113

Open

8 tasks

Uh oh!

Uh oh!

Conversation

adwinwhite commented Jul 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 21, 2026

Uh oh!

lcnr Jul 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr commented Jul 21, 2026

Uh oh!

rustbot commented Jul 22, 2026

Uh oh!

adwinwhite commented Jul 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

adwinwhite commented Jul 22, 2026

Uh oh!

rust-bors Bot commented Jul 22, 2026

Uh oh!

adwinwhite commented Jul 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 22, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 22, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lcnr commented Jul 22, 2026

Uh oh!

rust-bors Bot commented Jul 22, 2026

Uh oh!

ShoyuVanilla left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adwinwhite commented Jul 21, 2026 •

edited by rustbot

Loading

lcnr Jul 21, 2026 •

edited by rustbot

Loading

lcnr left a comment •

edited by rustbot

Loading

ShoyuVanilla left a comment •

edited by rustbot

Loading