Skip to content

make rustdoc::bare_urls strip trailing periods from url#159505

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
uselessgoddess:fix/issue-159480
Jul 21, 2026
Merged

make rustdoc::bare_urls strip trailing periods from url#159505
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
uselessgoddess:fix/issue-159480

Conversation

@uselessgoddess

@uselessgoddess uselessgoddess commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Fixes #159480

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 18, 2026
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @lolbinarycat (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 8 candidates
  • Random selection from GuillaumeGomez, lolbinarycat, notriddle

@lolbinarycat lolbinarycat changed the title fix base_urls with periods make rustdoc::bare_urls strip trailing periods from url Jul 20, 2026
@lolbinarycat

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8a07fcc has been approved by lolbinarycat

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
…=lolbinarycat

make rustdoc::bare_urls strip trailing periods from url

Fixes rust-lang#159480
rust-bors Bot pushed a commit that referenced this pull request Jul 21, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #159582 (Sync from portable simd 2026 07 20)
 - #157270 (ergonomic_clones_dotuse_capture_by_ref: Capture upvar by ref for `.use` in non-move closures)
 - #158496 (Move `check_rustc_pub_transparent` into the attribute parser)
 - #158547 (Move `std::io::buffered` to `alloc::io`)
 - #159505 (make rustdoc::bare_urls strip trailing periods from url)
 - #159578 (Extract coroutine closure helper functions)
 - #159613 (Set the rustc lib path for unstable-book-gen)
rust-bors Bot pushed a commit that referenced this pull request Jul 21, 2026
Rollup of 14 pull requests

Successful merges:

 - #159307 (Improve cross-namespace name diagnostics)
 - #159543 (Remove extra semicolons in parsing item lists)
 - #157270 (ergonomic_clones_dotuse_capture_by_ref: Capture upvar by ref for `.use` in non-move closures)
 - #158496 (Move `check_rustc_pub_transparent` into the attribute parser)
 - #158547 (Move `std::io::buffered` to `alloc::io`)
 - #158808 (Filter host libstdc++ ABI flag in rustc_llvm cross builds)
 - #159362 (Add regression test for #120328)
 - #159472 (Support creating float constants in rustc_public mir)
 - #159505 (make rustdoc::bare_urls strip trailing periods from url)
 - #159568 (Suggest close compiler options)
 - #159578 (Extract coroutine closure helper functions)
 - #159601 (Make `TokenTreeCursor` private)
 - #159613 (Set the rustc lib path for unstable-book-gen)
 - #159616 (Clarify the comment about stage1/stage2 discrepancy in input-stats test)
@rust-bors
rust-bors Bot merged commit 652b5ed into rust-lang:main Jul 21, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 21, 2026
rust-timer added a commit that referenced this pull request Jul 21, 2026
Rollup merge of #159505 - uselessgoddess:fix/issue-159480, r=lolbinarycat

make rustdoc::bare_urls strip trailing periods from url

Fixes #159480
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jul 22, 2026
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#159307 (Improve cross-namespace name diagnostics)
 - rust-lang/rust#159543 (Remove extra semicolons in parsing item lists)
 - rust-lang/rust#157270 (ergonomic_clones_dotuse_capture_by_ref: Capture upvar by ref for `.use` in non-move closures)
 - rust-lang/rust#158496 (Move `check_rustc_pub_transparent` into the attribute parser)
 - rust-lang/rust#158547 (Move `std::io::buffered` to `alloc::io`)
 - rust-lang/rust#158808 (Filter host libstdc++ ABI flag in rustc_llvm cross builds)
 - rust-lang/rust#159362 (Add regression test for rust-lang/rust#120328)
 - rust-lang/rust#159472 (Support creating float constants in rustc_public mir)
 - rust-lang/rust#159505 (make rustdoc::bare_urls strip trailing periods from url)
 - rust-lang/rust#159568 (Suggest close compiler options)
 - rust-lang/rust#159578 (Extract coroutine closure helper functions)
 - rust-lang/rust#159601 (Make `TokenTreeCursor` private)
 - rust-lang/rust#159613 (Set the rustc lib path for unstable-book-gen)
 - rust-lang/rust#159616 (Clarify the comment about stage1/stage2 discrepancy in input-stats test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc::bare_urls includes trailing . in the detected URL

3 participants