Skip to content

Next steps for FnDef binder changes (instantiate most FnDef binders) - #159403

Open
addiesh wants to merge 41 commits into
rust-lang:mainfrom
addiesh:call-me-turbofishmael
Open

Next steps for FnDef binder changes (instantiate most FnDef binders)#159403
addiesh wants to merge 41 commits into
rust-lang:mainfrom
addiesh:call-me-turbofishmael

Conversation

@addiesh

@addiesh addiesh commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

View all comments

This change is a part of the ongoing effort to clean up binder/turbofishing behavior in the compiler (#156581).

This PR instantiates binders that were previously created via ty::Binder::dummy() with meaningfully bound vars.

r? oli-obk

Call me Turbofishmael.
Some years ago- never mind how long precisely-
having little or no money in my purse,
and nothing particular to interest me in C++,
I thought I would sail about a little and see the rusty part of the world.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 16, 2026
@rustbot

rustbot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@addiesh
addiesh force-pushed the call-me-turbofishmael branch 3 times, most recently from 014b214 to d780036 Compare July 16, 2026 19:40
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh

addiesh commented Jul 16, 2026

Copy link
Copy Markdown
Author

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)
Click to see the possible cause of the failure (guessed by this bot)

what happened during the rebase??? lemme rollback and try see what broke

@addiesh
addiesh force-pushed the call-me-turbofishmael branch from d780036 to 6e740ba Compare July 16, 2026 20:10
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 330681e to 83e428c Compare July 17, 2026 15:14
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh addiesh mentioned this pull request Jul 17, 2026
Open
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 83e428c to 9fb9767 Compare July 17, 2026 17:18
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 9fb9767 to 3920a9e Compare July 17, 2026 22:34
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 5373d53 to f118249 Compare July 20, 2026 15:15
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from f118249 to 6aeb29e Compare July 20, 2026 15:28
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 6aeb29e to ac8e8e5 Compare July 20, 2026 15:33
@addiesh
addiesh marked this pull request as ready for review July 20, 2026 15:48
zakrad and others added 18 commits July 28, 2026 20:27
@zakrad addie.sh
Add regression test for fn-ptr coercion normalization ICE
f3b14f3 
Coercing the fn item `bar` to a fn pointer while `Foo::value` holds the
associated-type projection `<<T as Func>::Ret as Id>::Assoc` used to ICE
during normalization ("maybe try to call `try_normalize_erasing_regions`
instead"). It now reports the ordinary `u32: Id` trait-bound error instead
of crashing.
@GuillaumeGomez addie.sh
Update browser-ui-test version to 0.25.0
0768bd9
@GuillaumeGomez addie.sh
Add missing "clipboard-read" permission
c716238
@nnethercote addie.sh
Improve consistency of proc macro attribute error messages
bf116a2
@nnethercote addie.sh
Improve consistency of rustc_abi attribute error messages
31e4019
@nnethercote addie.sh
Improve consistency of rustc_const_stable attribute error messages
c70f76a
@nnethercote addie.sh
Improve consistency of diagnostic::on_const attribute error messages
8be13e4
@nnethercote addie.sh
Improve consistency of test/bench attribute error messages
845600c 
The carets should ideally point to the path, not the entire attribute,
but that's hard to achieve with the current code structure.
@nnethercote addie.sh
Improve consistency of unsafe attribute error messages
57b38a4 
The carets already point to just the attribute path, which is what we
want.
@chenyukang addie.sh
Add regression test for generic associated function suggestions
63805c3
@chenyukang addie.sh
Use value syntax for associated function suggestions
83dd3ce
@renovate-bot addie.sh
Update Rust crate tracing-subscriber to v0.3.23 [SECURITY]
d2615b6
@RalfJung addie.sh
sanitize_standard_fds: clarify macos comment
c81b591
@marcoieni addie.sh
use unstable features when updating dependencies
7c11383
@RalfJung addie.sh
miri ui tests: don't run native tests on stage 0
9e3d23a
@ehuss addie.sh
Switch cargo assignments to weihanglo
24a1d51
@ehuss addie.sh
Update assignment for docs
a0bed95 
I'm updating the docs to point to lang-docs instead of just myself.
addie.sh
Next steps for FnDef binder changes (instantiate most FnDef binders)
1047fdb
@rustbot

rustbot commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

rustc-dev-guide is developed in its own repository. If possible, consider making this change to rust-lang/rustc-dev-guide instead.

cc @BoxyUwU, @tshepang

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

Some changes occurred in GUI tests.

cc @GuillaumeGomez

Some changes occurred to diagnostic attributes.

cc @mejrs

changes to the core type system

cc @lcnr

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@oli-obk oli-obk

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like perf-regression Performance regression. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.