Skip to content

Gate tests/debuginfo/function-call.rs on min GDB 15.1#159401

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jieyouxu:jieyouxu/test/function-call
Jul 17, 2026
Merged

Gate tests/debuginfo/function-call.rs on min GDB 15.1#159401
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jieyouxu:jieyouxu/test/function-call

Conversation

@jieyouxu

@jieyouxu jieyouxu commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary

See #159073, this test has been flaky with

/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script:11: Error in sourced command file:
Couldn't write extended state status: Bad address.

on linux CI jobs under various environments and hosts/targets. I tried running this under GDB 15.1 locally (WSL, x86_64-unknown-linux-gnu) but could not reproduce. CI typically uses GDB 12.1 with Ubuntu 22.04. So gate this test with min GDB 15.1 which prevents it from running in CI to workaround the flakiness but still allow running it locally under GDB >= 15.1.

It's possible there's a genuine problem here, but this looks like a deep debugging rabbit hole so let's not run this test in CI for now to not have the frequent flakiness. Revert this PR if we figure out where the problem lies.

Additional context

Also asked in #t-compiler > `tests/debuginfo/function-call.rs` + gdb recently flaky.

See RUST-159073, this test has been flaky with

```
/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script:11: Error in sourced command file:
Couldn't write extended state status: Bad address.
```

on linux CI jobs under various environments and hosts/targets. I tried
running this under GDB 15.1 locally (WSL, `x86_64-unknown-linux-gnu`)
but could not reproduce. CI typically uses GDB 12.1 with Ubuntu 22.04.
So gate this test with min GDB 15.1 which prevents it from running in CI
to workaround the flakiness but still allow running it locally under
GDB >= 15.1.

It's *possible* there's a genuine problem here.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 16, 2026
@rustbot

rustbot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 17 candidates

@workingjubilee workingjubilee changed the title Gate tests/deubinfo/function-call.rs on min GDB 15.1 Gate tests/debuginfo/function-call.rs on min GDB 15.1 Jul 16, 2026
@workingjubilee

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 810a7aa has been approved by workingjubilee

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 17, 2026
…ll, r=workingjubilee

Gate `tests/debuginfo/function-call.rs` on min GDB 15.1

## Summary

See rust-lang#159073, this test has been flaky with

```
/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script:11: Error in sourced command file:
Couldn't write extended state status: Bad address.
```

on linux CI jobs under various environments and hosts/targets. I tried running this under GDB 15.1 locally (WSL, `x86_64-unknown-linux-gnu`) but could not reproduce. CI typically uses GDB 12.1 with Ubuntu 22.04. So gate this test with min GDB 15.1 which prevents it from running in CI to workaround the flakiness but still allow running it locally under GDB >= 15.1.

It's *possible* there's a genuine problem here, but this looks like a deep debugging rabbit hole so let's not run this test in CI for now to not have the frequent flakiness. Revert this PR if we figure out where the problem lies.

## Additional context

Also asked in [#t-compiler > &rust-lang#96;tests/debuginfo/function-call.rs&rust-lang#96; + gdb recently flaky](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60tests.2Fdebuginfo.2Ffunction-call.2Ers.60.20.2B.20gdb.20recently.20flaky/with/611111005).
rust-bors Bot pushed a commit that referenced this pull request Jul 17, 2026
Rollup of 10 pull requests

Successful merges:

 - #156977 (interpret: properly check for inhabitedness of nested references)
 - #159365 (fix: point at method call chain when a return-position `impl Trait` assoc type diverges)
 - #159402 (Clarify safety requirements for SIMD shl/shr and masked load/store)
 - #159410 (rustdoc: remove old `--emit` types)
 - #159302 (Implement `Debug` helpers via `Cell`)
 - #159386 (add a fallback for `fmuladdf*`)
 - #159391 (Update tests for LLVM 23)
 - #159400 (Update books)
 - #159401 (Gate `tests/debuginfo/function-call.rs` on min GDB 15.1)
 - #159404 ([aarch64][win] Pass oversized c-variadic args indirectly on Arm64EC)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 17, 2026
…ll, r=workingjubilee

Gate `tests/debuginfo/function-call.rs` on min GDB 15.1

## Summary

See rust-lang#159073, this test has been flaky with

```
/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script:11: Error in sourced command file:
Couldn't write extended state status: Bad address.
```

on linux CI jobs under various environments and hosts/targets. I tried running this under GDB 15.1 locally (WSL, `x86_64-unknown-linux-gnu`) but could not reproduce. CI typically uses GDB 12.1 with Ubuntu 22.04. So gate this test with min GDB 15.1 which prevents it from running in CI to workaround the flakiness but still allow running it locally under GDB >= 15.1.

It's *possible* there's a genuine problem here, but this looks like a deep debugging rabbit hole so let's not run this test in CI for now to not have the frequent flakiness. Revert this PR if we figure out where the problem lies.

## Additional context

Also asked in [#t-compiler > &rust-lang#96;tests/debuginfo/function-call.rs&rust-lang#96; + gdb recently flaky](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60tests.2Fdebuginfo.2Ffunction-call.2Ers.60.20.2B.20gdb.20recently.20flaky/with/611111005).
rust-bors Bot pushed a commit that referenced this pull request Jul 17, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - #159365 (fix: point at method call chain when a return-position `impl Trait` assoc type diverges)
 - #159402 (Clarify safety requirements for SIMD shl/shr and masked load/store)
 - #159410 (rustdoc: remove old `--emit` types)
 - #159302 (Implement `Debug` helpers via `Cell`)
 - #159386 (add a fallback for `fmuladdf*`)
 - #159391 (Update tests for LLVM 23)
 - #159400 (Update books)
 - #159401 (Gate `tests/debuginfo/function-call.rs` on min GDB 15.1)
 - #159404 ([aarch64][win] Pass oversized c-variadic args indirectly on Arm64EC)
 - #159405 (Manually implement Clone for GrowableBitSet)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 17, 2026
…ll, r=workingjubilee

Gate `tests/debuginfo/function-call.rs` on min GDB 15.1

## Summary

See rust-lang#159073, this test has been flaky with

```
/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script:11: Error in sourced command file:
Couldn't write extended state status: Bad address.
```

on linux CI jobs under various environments and hosts/targets. I tried running this under GDB 15.1 locally (WSL, `x86_64-unknown-linux-gnu`) but could not reproduce. CI typically uses GDB 12.1 with Ubuntu 22.04. So gate this test with min GDB 15.1 which prevents it from running in CI to workaround the flakiness but still allow running it locally under GDB >= 15.1.

It's *possible* there's a genuine problem here, but this looks like a deep debugging rabbit hole so let's not run this test in CI for now to not have the frequent flakiness. Revert this PR if we figure out where the problem lies.

## Additional context

Also asked in [#t-compiler > &rust-lang#96;tests/debuginfo/function-call.rs&rust-lang#96; + gdb recently flaky](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60tests.2Fdebuginfo.2Ffunction-call.2Ers.60.20.2B.20gdb.20recently.20flaky/with/611111005).
rust-bors Bot pushed a commit that referenced this pull request Jul 17, 2026
…uwer

Rollup of 16 pull requests

Successful merges:

 - #150732 (Convert `-Ctarget-cpu` into a target-modifier for AVR, AMDGCN and NVPTX )
 - #159301 (Update Enzyme to handle LLVM23)
 - #159365 (fix: point at method call chain when a return-position `impl Trait` assoc type diverges)
 - #159402 (Clarify safety requirements for SIMD shl/shr and masked load/store)
 - #159410 (rustdoc: remove old `--emit` types)
 - #158398 (Comment about empty run_passes, fixup of #158040)
 - #158843 (Fix ICE in `write_interface` when the interface file can't be written)
 - #159302 (Implement `Debug` helpers via `Cell`)
 - #159332 (Honor field-level lint attributes in non_snake_case)
 - #159386 (add a fallback for `fmuladdf*`)
 - #159391 (Update tests for LLVM 23)
 - #159400 (Update books)
 - #159401 (Gate `tests/debuginfo/function-call.rs` on min GDB 15.1)
 - #159404 ([aarch64][win] Pass oversized c-variadic args indirectly on Arm64EC)
 - #159405 (Manually implement Clone for GrowableBitSet)
 - #159415 (rustdoc: rename the doc parts metadata params)
rust-bors Bot pushed a commit that referenced this pull request Jul 17, 2026
…uwer

Rollup of 17 pull requests

Successful merges:

 - #159301 (Update Enzyme to handle LLVM23)
 - #159365 (fix: point at method call chain when a return-position `impl Trait` assoc type diverges)
 - #159402 (Clarify safety requirements for SIMD shl/shr and masked load/store)
 - #159408 (rustc_data_structures: Expand documentation for rustc jobserver APIs)
 - #159410 (rustdoc: remove old `--emit` types)
 - #158398 (Comment about empty run_passes, fixup of #158040)
 - #158843 (Fix ICE in `write_interface` when the interface file can't be written)
 - #159302 (Implement `Debug` helpers via `Cell`)
 - #159332 (Honor field-level lint attributes in non_snake_case)
 - #159340 (Rename `errors.rs` file to `diagnostics.rs` (14/N))
 - #159386 (add a fallback for `fmuladdf*`)
 - #159391 (Update tests for LLVM 23)
 - #159400 (Update books)
 - #159401 (Gate `tests/debuginfo/function-call.rs` on min GDB 15.1)
 - #159404 ([aarch64][win] Pass oversized c-variadic args indirectly on Arm64EC)
 - #159405 (Manually implement Clone for GrowableBitSet)
 - #159415 (rustdoc: rename the doc parts metadata params)
@rust-bors
rust-bors Bot merged commit d9e09f7 into rust-lang:main Jul 17, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 17, 2026
rust-timer added a commit that referenced this pull request Jul 17, 2026
Rollup merge of #159401 - jieyouxu:jieyouxu/test/function-call, r=workingjubilee

Gate `tests/debuginfo/function-call.rs` on min GDB 15.1

## Summary

See #159073, this test has been flaky with

```
/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script:11: Error in sourced command file:
Couldn't write extended state status: Bad address.
```

on linux CI jobs under various environments and hosts/targets. I tried running this under GDB 15.1 locally (WSL, `x86_64-unknown-linux-gnu`) but could not reproduce. CI typically uses GDB 12.1 with Ubuntu 22.04. So gate this test with min GDB 15.1 which prevents it from running in CI to workaround the flakiness but still allow running it locally under GDB >= 15.1.

It's *possible* there's a genuine problem here, but this looks like a deep debugging rabbit hole so let's not run this test in CI for now to not have the frequent flakiness. Revert this PR if we figure out where the problem lies.

## Additional context

Also asked in [#t-compiler > `tests/debuginfo/function-call.rs` + gdb recently flaky](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60tests.2Fdebuginfo.2Ffunction-call.2Ers.60.20.2B.20gdb.20recently.20flaky/with/611111005).
@theemathas theemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 18, 2026
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 18, 2026
@jieyouxu
jieyouxu deleted the jieyouxu/test/function-call branch July 18, 2026 05:10
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.99.0, 1.98.0 Jul 18, 2026
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 18, 2026
rust-bors Bot pushed a commit that referenced this pull request Jul 18, 2026
…crum

[beta] backports



This backports:

* resolve: fix effective visibilities for items in ambiguous glob sets #159039
* Revert extension of -1 for None-like tags rust-lang/rust #159047
* Gate tests/debuginfo/function-call.rs on min GDB 15.1 #159401

and also bumps to the just-released 1.97.1 compiler.

r? me
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Jul 23, 2026
…uwer

Rollup of 17 pull requests

Successful merges:

 - rust-lang/rust#159301 (Update Enzyme to handle LLVM23)
 - rust-lang/rust#159365 (fix: point at method call chain when a return-position `impl Trait` assoc type diverges)
 - rust-lang/rust#159402 (Clarify safety requirements for SIMD shl/shr and masked load/store)
 - rust-lang/rust#159408 (rustc_data_structures: Expand documentation for rustc jobserver APIs)
 - rust-lang/rust#159410 (rustdoc: remove old `--emit` types)
 - rust-lang/rust#158398 (Comment about empty run_passes, fixup of rust-lang/rust#158040)
 - rust-lang/rust#158843 (Fix ICE in `write_interface` when the interface file can't be written)
 - rust-lang/rust#159302 (Implement `Debug` helpers via `Cell`)
 - rust-lang/rust#159332 (Honor field-level lint attributes in non_snake_case)
 - rust-lang/rust#159340 (Rename `errors.rs` file to `diagnostics.rs` (14/N))
 - rust-lang/rust#159386 (add a fallback for `fmuladdf*`)
 - rust-lang/rust#159391 (Update tests for LLVM 23)
 - rust-lang/rust#159400 (Update books)
 - rust-lang/rust#159401 (Gate `tests/debuginfo/function-call.rs` on min GDB 15.1)
 - rust-lang/rust#159404 ([aarch64][win] Pass oversized c-variadic args indirectly on Arm64EC)
 - rust-lang/rust#159405 (Manually implement Clone for GrowableBitSet)
 - rust-lang/rust#159415 (rustdoc: rename the doc parts metadata params)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants