Fix decoding attributes of `SyntheticCoroutineBody` by JonathanBrouwer · Pull Request #159085 · rust-lang/rust

JonathanBrouwer · 2026-07-10T13:41:28Z

Fixes #156905 by returning an empty list of attributes for SyntheticCoroutineBody when its attributes are decoded

rustbot · 2026-07-10T13:41:33Z

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 20 candidates

kn1g78 · 2026-07-10T13:52:22Z

+                            .get(self, parent_id)
+                            .expect("no encoded attributes for a structure or variant")
+                    }
+                    DefPathData::SyntheticCoroutineBody => {


Could we add a regression test for this?

This fixes an ICE while decoding attributes of an external SyntheticCoroutineBody, but the PR currently has no test
covering that cross-crate path. A Miri regression test would likely be the closest match for #156905, since it
exercises find_attr! / attrs_for_def.

View changes since the review

A regression test would be great yeah, I think taking the test from quiode@dd72b0b makes sense, I'll do that

JonathanBrouwer · 2026-07-10T14:28:44Z

@rustbot author

rustbot · 2026-07-10T14:28:48Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-07-26T10:58:40Z

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

rustbot · 2026-07-26T10:58:42Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

RalfJung · 2026-07-26T11:05:45Z

+//@normalize-stderr-test: "/rustc-dev/[^/]*/" -> "/rustc-dev/$HASH/"
+
+// Miri ICE when encountering a `SyntheticCoroutineBody` from an external crate (see
+// `closure_ice_lib` for details). Calling the async closure triggers the ICE.


I hope we don't ICE any more? Why all this error normalization in a "pass" test?

View changes since the review

The description still says "triggers", that should be "triggered" maybe? Also maybe link the issue.

Sounds reasonable, fixed

JonathanBrouwer · 2026-07-26T11:45:17Z

@RalfJung how about this?
@rustbot ready

RalfJung · 2026-07-26T11:49:32Z

That's great, thanks :)

Co-authored-by: Dominik Schwaiger <mail@dominik-schwaiger.ch>

folkertdev · 2026-07-26T22:33:11Z

@bors r+

rust-bors · 2026-07-26T22:33:14Z

📌 Commit e12d28f has been approved by folkertdev

It is now in the queue for this repository.

…, r=folkertdev Fix decoding attributes of `SyntheticCoroutineBody` Fixes rust-lang#156905 by returning an empty list of attributes for `SyntheticCoroutineBody` when its attributes are decoded

…uwer Rollup of 8 pull requests Successful merges: - #159085 (Fix decoding attributes of `SyntheticCoroutineBody`) - #159554 (feat: Update method signature of int_from_ascii) - #159637 (Some place analysis tweaks) - #159961 (sanitize_standard_fds: Miri supports poll now) - #159967 (rustc_target: callconv: mips64: Return structs with single f128 in FPRs) - #159253 (Add suggestions for using `#[export_name]` instead of `#[link_name]` on static) - #159840 (Fix opaque type ICE in late lints under the next-generation trait solver) - #159956 (Fix observable intermediate state in `thread::add_spawn_hook`)

rust-bors · 2026-07-27T03:01:46Z

⌛ Testing commit e12d28f with merge d1cf67d...

Workflow: https://github.com/rust-lang/rust/actions/runs/30233565748

Fix decoding attributes of `SyntheticCoroutineBody` Fixes #156905 by returning an empty list of attributes for `SyntheticCoroutineBody` when its attributes are decoded

jhpratt · 2026-07-27T03:05:02Z

@bors yield

rust-bors · 2026-07-27T03:05:06Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/30233565748

The next pull request likely to be tested is #159085.

…uwer Rollup of 8 pull requests Successful merges: - #159085 (Fix decoding attributes of `SyntheticCoroutineBody`) - #159554 (feat: Update method signature of int_from_ascii) - #159637 (Some place analysis tweaks) - #159961 (sanitize_standard_fds: Miri supports poll now) - #159967 (rustc_target: callconv: mips64: Return structs with single f128 in FPRs) - #159253 (Add suggestions for using `#[export_name]` instead of `#[link_name]` on static) - #159840 (Fix opaque type ICE in late lints under the next-generation trait solver) - #159956 (Fix observable intermediate state in `thread::add_spawn_hook`)

…, r=folkertdev Fix decoding attributes of `SyntheticCoroutineBody` Fixes rust-lang#156905 by returning an empty list of attributes for `SyntheticCoroutineBody` when its attributes are decoded

…uwer Rollup of 14 pull requests Successful merges: - #158417 (Avoid ICE when cfg_eval recovers no item from derive input) - #159085 (Fix decoding attributes of `SyntheticCoroutineBody`) - #159554 (feat: Update method signature of int_from_ascii) - #159637 (Some place analysis tweaks) - #159649 (Normalize region obligations before regionck) - #159961 (sanitize_standard_fds: Miri supports poll now) - #159967 (rustc_target: callconv: mips64: Return structs with single f128 in FPRs) - #159253 (Add suggestions for using `#[export_name]` instead of `#[link_name]` on static) - #159804 (Expand docs for fs::metadata and fs::symlink_metadata) - #159821 (Update expect message using the recommended style in binary_heap module) - #159840 (Fix opaque type ICE in late lints under the next-generation trait solver) - #159956 (Fix observable intermediate state in `thread::add_spawn_hook`) - #159991 (std: make send_process_group_signal unsupported on VxWorks) - #159996 (Detect when a macro without exclamation mark uses square brackets)

Rollup merge of #159085 - JonathanBrouwer:fix-def-path-attrs, r=folkertdev Fix decoding attributes of `SyntheticCoroutineBody` Fixes #156905 by returning an empty list of attributes for `SyntheticCoroutineBody` when its attributes are decoded

…uwer Rollup of 14 pull requests Successful merges: - rust-lang/rust#158417 (Avoid ICE when cfg_eval recovers no item from derive input) - rust-lang/rust#159085 (Fix decoding attributes of `SyntheticCoroutineBody`) - rust-lang/rust#159554 (feat: Update method signature of int_from_ascii) - rust-lang/rust#159637 (Some place analysis tweaks) - rust-lang/rust#159649 (Normalize region obligations before regionck) - rust-lang/rust#159961 (sanitize_standard_fds: Miri supports poll now) - rust-lang/rust#159967 (rustc_target: callconv: mips64: Return structs with single f128 in FPRs) - rust-lang/rust#159253 (Add suggestions for using `#[export_name]` instead of `#[link_name]` on static) - rust-lang/rust#159804 (Expand docs for fs::metadata and fs::symlink_metadata) - rust-lang/rust#159821 (Update expect message using the recommended style in binary_heap module) - rust-lang/rust#159840 (Fix opaque type ICE in late lints under the next-generation trait solver) - rust-lang/rust#159956 (Fix observable intermediate state in `thread::add_spawn_hook`) - rust-lang/rust#159991 (std: make send_process_group_signal unsupported on VxWorks) - rust-lang/rust#159996 (Detect when a macro without exclamation mark uses square brackets)

rustbot assigned folkertdev Jul 10, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 10, 2026

kn1g78 reviewed Jul 10, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2026

JonathanBrouwer force-pushed the fix-def-path-attrs branch from ddab93f to d5c5473 Compare July 26, 2026 10:58

RalfJung reviewed Jul 26, 2026

View reviewed changes

Comment thread src/tools/miri/tests/deps/Cargo.toml Outdated

RalfJung reviewed Jul 26, 2026

View reviewed changes

Fix decoding attributes of SyntheticCoroutineBody

8bf37ce

JonathanBrouwer force-pushed the fix-def-path-attrs branch 2 times, most recently from bd9cacd to 768a041 Compare July 26, 2026 11:14

RalfJung reviewed Jul 26, 2026

View reviewed changes

Comment thread src/tools/miri/tests/pass-dep/cross_crate_async_closure_ice.rs

Comment thread src/tools/miri/tests/deps/cross-crate-items/src/lib.rs Outdated

JonathanBrouwer force-pushed the fix-def-path-attrs branch 2 times, most recently from a29dcd5 to 9f85877 Compare July 26, 2026 11:45

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 26, 2026

JonathanBrouwer force-pushed the fix-def-path-attrs branch from 9f85877 to 9fa75e3 Compare July 26, 2026 12:05

Add regression test

e12d28f

Co-authored-by: Dominik Schwaiger <mail@dominik-schwaiger.ch>

JonathanBrouwer force-pushed the fix-def-path-attrs branch from 9fa75e3 to e12d28f Compare July 26, 2026 12:06

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 26, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2026

JonathanBrouwer mentioned this pull request Jul 27, 2026

Rollup of 8 pull requests #159985

Closed

This was referenced Jul 27, 2026

Rollup of 15 pull requests #160002

Closed

Rollup of 14 pull requests #160003

Merged

rust-bors Bot merged commit e3a5100 into rust-lang:main Jul 27, 2026
13 of 14 checks passed

rustbot added this to the 1.99.0 milestone Jul 27, 2026

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jul 10, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 10, 2026

Uh oh!

kn1g78 Jul 10, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented Jul 10, 2026

Uh oh!

rustbot commented Jul 10, 2026

Uh oh!

rustbot commented Jul 26, 2026

Uh oh!

rustbot commented Jul 26, 2026

Uh oh!

Uh oh!

RalfJung Jul 26, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

folkertdev Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 26, 2026

Uh oh!

RalfJung commented Jul 26, 2026

Uh oh!

folkertdev commented Jul 26, 2026

Uh oh!

rust-bors Bot commented Jul 26, 2026

Uh oh!

rust-bors Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jul 27, 2026

Uh oh!

rust-bors Bot commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JonathanBrouwer commented Jul 10, 2026 •

edited by rustbot

Loading

kn1g78 Jul 10, 2026 •

edited by rustbot

Loading

RalfJung Jul 26, 2026 •

edited by rustbot

Loading

rust-bors Bot commented Jul 27, 2026 •

edited

Loading