Skip to content

delegation: add constraints to new generic args#158905

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-forgotten-constraints
Jul 8, 2026
Merged

delegation: add constraints to new generic args#158905
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-forgotten-constraints

Conversation

@aerooneqq

@aerooneqq aerooneqq commented Jul 7, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Constraints were not added to new generic args which caused them to be missing from HIR and this produced ICE.

Fixes #158812. Part of #118212.
r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2026
@petrochenkov petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Jul 7, 2026
@petrochenkov

petrochenkov commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 66beceb has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jul 7, 2026
@m-ou-se
Rollup merge of rust-lang#158905 - aerooneqq:delegation-forgotten-con…
973614a 
…straints, r=petrochenkov

delegation: add constraints to new generic args

Constraints were not added to new generic args which caused them to be missing from HIR and this produced ICE.

Fixes rust-lang#158812. Part of rust-lang#118212.
r? @petrochenkov
@m-ou-se m-ou-se mentioned this pull request Jul 7, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@bors
Auto merge of #158906 - m-ou-se:rollup-3mLH5iB, r=m-ou-se
69e9856 
Rollup of 8 pull requests

Successful merges:

 - #156968 (diagnostics: suggest generic_const_args for const ops)
 - #158617 (allow mGCA const arguments to fall back to anon consts)
 - #158690 (delegation: support mapping of all arguments with `Self` type)
 - #158696 (Rename some `body_id` to `body_def_id`)
 - #158333 (Fix typetree generation for differentiated functions)
 - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - #158905 (delegation: add constraints to new generic args)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158905 - aerooneqq:delegation-forgotten-con…
75c6569 
…straints, r=petrochenkov

delegation: add constraints to new generic args

Constraints were not added to new generic args which caused them to be missing from HIR and this produced ICE.

Fixes rust-lang#158812. Part of rust-lang#118212.
r? @petrochenkov
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158905 - aerooneqq:delegation-forgotten-con…
455971c 
…straints, r=petrochenkov

delegation: add constraints to new generic args

Constraints were not added to new generic args which caused them to be missing from HIR and this produced ICE.

Fixes rust-lang#158812. Part of rust-lang#118212.
r? @petrochenkov
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 7, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@bors
Auto merge of #158911 - JonathanBrouwer:rollup-RXBIXmN, r=JonathanBro…
12fe3a4 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
 - #158617 (allow mGCA const arguments to fall back to anon consts)
 - #158621 (disallow `extern "custom"` on wasm and spirv targets)
 - #158690 (delegation: support mapping of all arguments with `Self` type)
 - #158696 (Rename some `body_id` to `body_def_id`)
 - #158333 (Fix typetree generation for differentiated functions)
 - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - #158791 (Avoid unused braces lint for macro generated arguments)
 - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - #158889 (tests: catch up with LLVM returning f128 on the stack)
 - #158905 (delegation: add constraints to new generic args)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158905 - aerooneqq:delegation-forgotten-con…
fddf020 
…straints, r=petrochenkov

delegation: add constraints to new generic args

Constraints were not added to new generic args which caused them to be missing from HIR and this produced ICE.

Fixes rust-lang#158812. Part of rust-lang#118212.
r? @petrochenkov
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 7, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@bors
Auto merge of #158923 - JonathanBrouwer:rollup-HAAKMUz, r=JonathanBro…
e38cd22 
…uwer

Rollup of 18 pull requests

Successful merges:

 - #157385 (Enable Enzyme on x86_64-apple)
 - #157561 (rustdoc: do not include extra stuff in span)
 - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
 - #158617 (allow mGCA const arguments to fall back to anon consts)
 - #158621 (disallow `extern "custom"` on wasm and spirv targets)
 - #158690 (delegation: support mapping of all arguments with `Self` type)
 - #158696 (Rename some `body_id` to `body_def_id`)
 - #158697 (Fixes for QNX SDP 8)
 - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
 - #157801 (Rewrite safety requirements for `Allocator` impls)
 - #158333 (Fix typetree generation for differentiated functions)
 - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
 - #158791 (Avoid unused braces lint for macro generated arguments)
 - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - #158841 (Avoid final override ICE for RPITIT associated types)
 - #158889 (tests: catch up with LLVM returning f128 on the stack)
 - #158905 (delegation: add constraints to new generic args)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 7, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@bors
Auto merge of #158924 - JonathanBrouwer:rollup-rCVjim4, r=JonathanBro…
76fcc1c 
…uwer

Rollup of 19 pull requests

Successful merges:

 - #156016 (view-types: store view types in the AST)
 - #157385 (Enable Enzyme on x86_64-apple)
 - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
 - #158621 (disallow `extern "custom"` on wasm and spirv targets)
 - #158690 (delegation: support mapping of all arguments with `Self` type)
 - #158696 (Rename some `body_id` to `body_def_id`)
 - #158697 (Fixes for QNX SDP 8)
 - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
 - #157801 (Rewrite safety requirements for `Allocator` impls)
 - #158085 (rustdoc: Fix sidebar heading order)
 - #158333 (Fix typetree generation for differentiated functions)
 - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
 - #158791 (Avoid unused braces lint for macro generated arguments)
 - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - #158841 (Avoid final override ICE for RPITIT associated types)
 - #158889 (tests: catch up with LLVM returning f128 on the stack)
 - #158905 (delegation: add constraints to new generic args)
 - #158922 (tests: clean up over-constraint on LLVM feature count)

Failed merges:

 - #158617 (allow mGCA const arguments to fall back to anon consts)
@rust-bors
rust-bors Bot merged commit 6669db3 into rust-lang:main Jul 8, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 8, 2026
rust-timer added a commit that referenced this pull request Jul 8, 2026
@rust-timer
Unrolled build for #158905
a07d1c1 
Rollup merge of #158905 - aerooneqq:delegation-forgotten-constraints, r=petrochenkov

delegation: add constraints to new generic args

Constraints were not added to new generic args which caused them to be missing from HIR and this produced ICE.

Fixes #158812. Part of #118212.
r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

[ICE]: ID HirId(DefId( .. )) not encountered when visiting item HIR

3 participants

@aerooneqq @petrochenkov @rustbot