Skip to content

Emit llvm dereferenceable in more cases on newer LLVM versions #158863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
WaffleLapkin wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

Emit llvm dereferenceable in more cases on newer LLVM versions #158863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions compiler/rustc_codegen_llvm/src/abi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,11 @@ fn get_attrs<'ll>(this: &ArgAttributes, cx: &CodegenCx<'ll, '_>) -> SmallVec<[&'
// Only apply remaining attributes when optimizing
if cx.sess().opts.optimize != config::OptLevel::No {
let deref = this.pointee_size.bytes();
// dereferenceable in LLVM currently implies nofree, so only emit dereferenceable if nofree
// Prior to <https://github.com/llvm/llvm-project/pull/204795> dereferenceable in LLVM
// implied nofree, so only emit dereferenceable on older versions of LLVM if nofree
// is also set.
if deref != 0 && regular.contains(ArgAttribute::NoFree) {
let llvm_version = crate::llvm_util::get_version();
if deref != 0 && (llvm_version >= (23, 0, 0) || regular.contains(ArgAttribute::NoFree)) {
if regular.contains(ArgAttribute::NonNull) {
attrs.push(llvm::CreateDereferenceableAttr(cx.llcx, deref));
} else {
Expand Down
Loading