Skip to content

tidy: Use empty_alternate = true for triagebot mention glob check #158838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Jul 6, 2026
Merged

tidy: Use empty_alternate = true for triagebot mention glob check #158838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/tools/tidy/src/triagebot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,12 @@ pub fn check(path: &Path, tidy_ctx: TidyCtx) {
// The full-path doesn't exists, maybe it's a glob, let's add it to the glob set builder
// to be checked against all the file and directories in the repository.
let trimmed_path = clean_path.trim_end_matches('/');
builder.add(globset::Glob::new(&format!("{trimmed_path}{{,/*}}")).unwrap());
builder.add(
globset::GlobBuilder::new(&format!("{trimmed_path}{{,/*}}"))
.empty_alternates(true)
.build()
.unwrap(),
);
glob_entries.push(clean_path.to_string());
} else if is_in_submodule(Path::new(clean_path)) {
check.error(format!(
Expand Down
Loading