improve diagnostic suggestion when matching struct variants with tuple#158748
Merged
rust-bors[bot] merged 1 commit intoJul 18, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @hanna-kruppe (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
hanna-kruppe
requested changes
Jul 12, 2026
Contributor
There was a problem hiding this comment.
Thanks, this new suggestion is a big improvement.
I have some concerns about adding even more case distinctions and parameters to report_unexpected_variant_res as it's already very unwieldy. But I don't see a way to avoid that without a much larger refactoring, so I've limited my suggestions to the code this PR adds/touches.
There's also one more thing to improve about the suggestion and some more tests I'd like to see.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
hanna-kruppe
approved these changes
Jul 17, 2026
…e syntax - update `report_unexpected_variant_res` to suggest using proper struct usage instead of stating that fields are being ignored. - add edge test cases in `tests/ui/parser/recover/recover-from-bad-variant.rs`
Snxhit
force-pushed
the
fix-struct-variant-suggestion
branch
from
July 17, 2026 17:33
0ab4103 to
e8ddb78
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 17, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158544 (Move `std::io::Read` to `alloc::io`) - #158668 (`DeeplyNormalize` and `normalize_with_depth_to` take `Unnormalized<T>` as input) - #157514 ([tiny] Use multipart suggestion for finding ident when literal was expected in attr) - #158748 (improve diagnostic suggestion when matching struct variants with tuple) - #159463 (triagebot: tweak wording for miri changes message) Failed merges: - #158916 (Emit all borrowck errors at the end of borrowck)
rust-timer
added a commit
that referenced
this pull request
Jul 18, 2026
Rollup merge of #158748 - Snxhit:fix-struct-variant-suggestion, r=hanna-kruppe improve diagnostic suggestion when matching struct variants with tuple fixes #158641 changes: passed `sub_pats` from `resolve_pat_tuple_struct` into `report_unexpected_variant_res`, match user's variable names to struct fields, fix suggestion name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #158641
changes:
passed
sub_patsfromresolve_pat_tuple_structintoreport_unexpected_variant_res, match user's variable names to struct fields, fix suggestion name.