-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
trait solver: account for universes from replace_bound_vars #158362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rust-bors
merged 3 commits into
rust-lang:main
from
Dnreikronos:trait_solver/placeholder_universe_bounds
Jul 24, 2026
+54
−1
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
tests/ui/assumptions_on_binders/placeholder-assumptions-issue-157840.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| //@ compile-flags: -Znext-solver=globally -Zassumptions-on-binders | ||
|
|
||
| trait Trait<T> {} | ||
|
|
||
| trait Proj<'a> { | ||
| type Assoc; | ||
| } | ||
|
|
||
| fn foo<'a, T>() | ||
| where | ||
| T: Proj<'a, Assoc = fn(<T as Proj>::Assoc)>, | ||
| (): Trait<<T as Proj<'a>>::Assoc>, | ||
| //~^ ERROR the trait bound `(): Trait<fn(for<'a> fn(<T as Proj<'a>>::Assoc))>` is not satisfied | ||
| { | ||
| } | ||
|
|
||
| fn main() {} |
14 changes: 14 additions & 0 deletions
14
tests/ui/assumptions_on_binders/placeholder-assumptions-issue-157840.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| error[E0277]: the trait bound `(): Trait<fn(for<'a> fn(<T as Proj<'a>>::Assoc))>` is not satisfied | ||
| --> $DIR/placeholder-assumptions-issue-157840.rs:12:9 | ||
| | | ||
| LL | (): Trait<<T as Proj<'a>>::Assoc>, | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Trait<fn(for<'a> fn(<T as Proj<'a>>::Assoc))>` is not implemented for `()` | ||
| | | ||
| help: consider extending the `where` clause, but there might be an alternative better way to express this requirement | ||
| | | ||
| LL | (): Trait<<T as Proj<'a>>::Assoc>, (): Trait<fn(for<'a> fn(<T as Proj<'a>>::Assoc))> | ||
| | +++++++++++++++++++++++++++++++++++++++++++++++++ | ||
|
|
||
| error: aborting due to 1 previous error | ||
|
|
||
| For more information about this error, try `rustc --explain E0277`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there an example that required this? the fixme above about "should deal with all placeholders created inside of the query directly" is actually what -Zassumptions-on-binders is implementing so ideally this would actually be wholly unnecessary under -Zassumptions-on-binders 🤔
If this change isn't necessary for the
replace_bound_varsfix can we drop it from this PR so I can r+ it :3View changes since the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, there wasn't a separate example requiring this btw. i added it defensively since
compute_query_response_instantiation_valuesalso creates universes, but it isn't part of thereplace_bound_varsfailure path.imo you're right, this bookkeeping doesn't belong here under
-Zassumptions-on-binders. i've dropped it, and fyi the issue-157840 ui test still passes. ltm if you think the remaining fix needs anything else :)