Skip to content

Move derive tests into their dedicated folder #157527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 2 commits into from
Jun 25, 2026
Merged

Move derive tests into their dedicated folder #157527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1403bc
Move derive tests out of tests/ui/issues
danieljofficial Jun 5, 2026
68f9f5a
add issue links and bless
danieljofficial Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/ui/issues/issue-28561.rs → tests/ui/derives/derive-compound-arities.rs
View file
Open in desktop

@Kivooeo Kivooeo Jun 9, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sugg: derive-compound-arities

View changes since the review

@danieljofficial danieljofficial Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//! Regression test for https://github.com/rust-lang/rust/issues/28561
//@ check-pass
#[derive(Debug, Default, Eq, Hash, Ord, PartialEq, PartialOrd, Clone, Copy)]
struct Array<T> {
Expand Down
1 change: 1 addition & 0 deletions tests/ui/issues/issue-33571.rs → ...ive-error-identifies-unsafe-trait-name.rs
View file
Open in desktop
Comment thread
Kivooeo marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//! Regression test for https://github.com/rust-lang/rust/issues/33571
#[derive(Clone,
Sync, //~ ERROR cannot find derive macro `Sync` in this scope
//~| ERROR cannot find derive macro `Sync` in this scope
Expand Down
8 changes: 4 additions & 4 deletions tests/ui/issues/issue-33571.stderr → ...error-identifies-unsafe-trait-name.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
error: cannot find derive macro `Sync` in this scope
--> $DIR/issue-33571.rs:2:10
--> $DIR/derive-error-identifies-unsafe-trait-name.rs:3:10
|
LL | Sync,
| ^^^^
|
note: unsafe traits like `Sync` should be implemented explicitly
--> $DIR/issue-33571.rs:2:10
--> $DIR/derive-error-identifies-unsafe-trait-name.rs:3:10
|
LL | Sync,
| ^^^^

error: cannot find derive macro `Sync` in this scope
--> $DIR/issue-33571.rs:2:10
--> $DIR/derive-error-identifies-unsafe-trait-name.rs:3:10
|
LL | Sync,
| ^^^^
|
note: unsafe traits like `Sync` should be implemented explicitly
--> $DIR/issue-33571.rs:2:10
--> $DIR/derive-error-identifies-unsafe-trait-name.rs:3:10
|
LL | Sync,
| ^^^^
Expand Down
1 change: 1 addition & 0 deletions tests/ui/issues/issue-27340.rs → ...ives/derived-trait-requires-field-impl.rs
View file
Open in desktop

@Kivooeo Kivooeo Jun 9, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: this test checks that we can't use non-clone type inside struct that claims to be clone, which is not possible in rust because it requires to all fields to be clone

so i'm quite unsure about this name

View changes since the review

@danieljofficial danieljofficial Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was fixated on tuples, I wrongly assumed it was tied to the cause of the error. The test has evolved past the original intention. How does derived-trait-requires-field-impl sound ?

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//! Regression test for https://github.com/rust-lang/rust/issues/27340
struct Foo;
#[derive(Copy, Clone)]
struct Bar(Foo);
Expand Down
4 changes: 2 additions & 2 deletions tests/ui/issues/issue-27340.stderr → .../derived-trait-requires-field-impl.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
error[E0204]: the trait `Copy` cannot be implemented for this type
--> $DIR/issue-27340.rs:3:8
--> $DIR/derived-trait-requires-field-impl.rs:4:8
|
LL | #[derive(Copy, Clone)]
| ---- in this derive macro expansion
LL | struct Bar(Foo);
| ^^^ --- this field does not implement `Copy`

error[E0277]: the trait bound `Foo: Clone` is not satisfied
--> $DIR/issue-27340.rs:3:12
--> $DIR/derived-trait-requires-field-impl.rs:4:12
|
LL | #[derive(Copy, Clone)]
| ----- in this derive macro expansion
Expand Down
3 changes: 1 addition & 2 deletions tests/ui/derives/hash-on-compound-types.rs
View file
Open in desktop

@Kivooeo Kivooeo Jun 9, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sugg: not array field but compound types

View changes since the review

@danieljofficial danieljofficial Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, will make the change

Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//! Regression test for <https://github.com/rust-lang/rust/issues/21402>.

//! Regression test for https://github.com/rust-lang/rust/issues/21402
//@ check-pass
#![allow(dead_code)]

Expand Down
1 change: 1 addition & 0 deletions tests/ui/issues/issue-32324.rs → ...erived-copy-with-associated-type-field.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//! Regression test for https://github.com/rust-lang/rust/issues/32324
//@ check-pass
#![allow(dead_code)]

Expand Down
1 change: 1 addition & 0 deletions tests/ui/issues/issue-46101.rs → ...ives/no-ice-on-path-style-derive-macro.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//! Regression test for https://github.com/rust-lang/rust/issues/46101
trait Foo {}
#[derive(Foo::Anything)] //~ ERROR cannot find
//~| ERROR cannot find
Expand Down
4 changes: 2 additions & 2 deletions tests/ui/issues/issue-46101.stderr → .../no-ice-on-path-style-derive-macro.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error[E0433]: cannot find derive macro `Anything` in trait `Foo`
--> $DIR/issue-46101.rs:2:10
--> $DIR/no-ice-on-path-style-derive-macro.rs:3:10
|
LL | #[derive(Foo::Anything)]
| ^^^^^^^^^^^^^ a derive macro can't exist within a trait

error[E0433]: cannot find derive macro `Anything` in trait `Foo`
--> $DIR/issue-46101.rs:2:10
--> $DIR/no-ice-on-path-style-derive-macro.rs:3:10
|
LL | #[derive(Foo::Anything)]
| ^^^^^^^^^^^^^ a derive macro can't exist within a trait
Expand Down
1 change: 1 addition & 0 deletions tests/ui/issues/issue-32292.rs → ...unused-variable-warning-on-derive-hash.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//! Regression test for https://github.com/rust-lang/rust/issues/32292
//@ run-pass
#![deny(warnings)]

Expand Down
Loading