Skip to content

Relax test requirements for consistency #157300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Jun 8, 2026
Merged

Relax test requirements for consistency #157300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/ui/lint/rfc-2383-lint-reason/force_warn_expected_lints_fulfilled.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@
//@ compile-flags: --force-warn unused_variables
//@ compile-flags: --force-warn unused_mut
//@ check-pass
//@ ignore-parallel-frontend `note`s on different source lines

fn expect_early_pass_lint() {
#[expect(while_true)]
while true {
//~^ WARNING denote infinite loops with `loop { ... }` [while_true]
//~| NOTE requested on the command line with `--force-warn while-true`
//~| HELP use `loop`
println!("I never stop")
}
Expand All @@ -17,7 +16,6 @@ fn expect_early_pass_lint() {
fn check_specific_lint() {
let x = 2;
//~^ WARNING unused variable: `x` [unused_variables]
//~| NOTE requested on the command line with `--force-warn unused-variables`
//~| HELP if this is intentional, prefix it with an underscore
}

Expand All @@ -29,7 +27,6 @@ fn check_multiple_lints_with_lint_group() {

let mut what_does_the_fox_say = "*ding* *deng* *dung*";
//~^ WARNING variable does not need to be mutable [unused_mut]
//~| NOTE requested on the command line with `--force-warn unused-mut`
//~| HELP remove this `mut`

println!("The fox says: {what_does_the_fox_say}");
Expand Down
8 changes: 4 additions & 4 deletions tests/ui/lint/rfc-2383-lint-reason/force_warn_expected_lints_fulfilled.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ LL | while true {
= note: requested on the command line with `--force-warn while-true`

warning: unused variable: `x`
--> $DIR/force_warn_expected_lints_fulfilled.rs:18:9
--> $DIR/force_warn_expected_lints_fulfilled.rs:17:9
|
LL | let x = 2;
| ^ help: if this is intentional, prefix it with an underscore: `_x`
|
= note: requested on the command line with `--force-warn unused-variables`

warning: variable does not need to be mutable
--> $DIR/force_warn_expected_lints_fulfilled.rs:30:9
--> $DIR/force_warn_expected_lints_fulfilled.rs:28:9
|
LL | let mut what_does_the_fox_say = "*ding* *deng* *dung*";
| ----^^^^^^^^^^^^^^^^^^^^^
Expand All @@ -25,13 +25,13 @@ LL | let mut what_does_the_fox_say = "*ding* *deng* *dung*";
= note: requested on the command line with `--force-warn unused-mut`

warning: unused variable: `fox_name`
--> $DIR/force_warn_expected_lints_fulfilled.rs:26:9
--> $DIR/force_warn_expected_lints_fulfilled.rs:24:9
|
LL | let fox_name = "Sir Nibbles";
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_fox_name`

warning: unused variable: `this_should_fulfill_the_expectation`
--> $DIR/force_warn_expected_lints_fulfilled.rs:41:9
--> $DIR/force_warn_expected_lints_fulfilled.rs:38:9
|
LL | let this_should_fulfill_the_expectation = "The `#[allow]` has no power here";
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_this_should_fulfill_the_expectation`
Expand Down
Loading