-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
borrowck: avoid ICE describing fields on generic params #157230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rust-bors
merged 2 commits into
rust-lang:main
from
pbkx:issue-155344-borrowck-field-param
Jun 11, 2026
+68
−3
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
tests/ui/borrowck/borrowck-describe-field-generic-param-owned-box.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // Regression test for #155344. | ||
| // Borrowck diagnostics should not ICE when describing a field access on a generic parameter. | ||
|
|
||
| //@ edition: 2024 | ||
|
|
||
| #![crate_type = "lib"] | ||
| #![feature(no_core, lang_items)] | ||
| #![no_core] | ||
|
|
||
| #[lang = "pointee_sized"] | ||
| pub trait PointeeSized {} | ||
|
|
||
| #[lang = "meta_sized"] | ||
| pub trait MetaSized: PointeeSized {} | ||
|
|
||
| #[lang = "sized"] | ||
| pub trait Sized: MetaSized {} | ||
|
|
||
| #[lang = "legacy_receiver"] | ||
| pub trait LegacyReceiver {} | ||
|
|
||
| impl<T: PointeeSized> LegacyReceiver for &T {} | ||
| impl<T: PointeeSized> LegacyReceiver for &mut T {} | ||
|
|
||
| #[lang = "copy"] | ||
| pub trait Copy {} | ||
|
|
||
| impl Copy for *mut () {} | ||
|
|
||
| #[lang = "drop"] | ||
| pub trait Drop { | ||
| fn drop(&mut self); | ||
| } | ||
|
|
||
| unsafe extern "C" { | ||
| fn free(_: *mut ()); | ||
| } | ||
|
|
||
| unsafe fn transmute<T, U>(_: T) -> U { | ||
| loop {} | ||
| } | ||
|
|
||
| #[repr(transparent)] | ||
| pub struct NonNull<T: ?Sized>(pub *const T); | ||
|
|
||
| #[lang = "owned_box"] | ||
| pub struct Box<T: ?Sized, A = ()>(NonNull<T>, A); | ||
|
|
||
| impl<T: ?Sized, A> Drop for Box<T, A> { | ||
| fn drop(&mut self) { | ||
| unsafe { | ||
| free(transmute::<NonNull<T>, *mut _>(self.0)); | ||
| //~^ ERROR cannot move out of `self.0` which is behind a mutable reference | ||
| } | ||
| } | ||
| } |
9 changes: 9 additions & 0 deletions
9
tests/ui/borrowck/borrowck-describe-field-generic-param-owned-box.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| error[E0507]: cannot move out of `self.0` which is behind a mutable reference | ||
| --> $DIR/borrowck-describe-field-generic-param-owned-box.rs:52:50 | ||
| | | ||
| LL | free(transmute::<NonNull<T>, *mut _>(self.0)); | ||
| | ^^^^^^ move occurs because `self.0` has type `NonNull<T>`, which does not implement the `Copy` trait | ||
|
|
||
| error: aborting due to 1 previous error | ||
|
|
||
| For more information about this error, try `rustc --explain E0507`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding a comment to explain this surprising case?