Skip to content

[AIX] Sync compiler and std with libc changes - #156991

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
amy-kwan:amy-kwan/aix-libc-changes
May 29, 2026
Merged

[AIX] Sync compiler and std with libc changes#156991
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
amy-kwan:amy-kwan/aix-libc-changes

Conversation

@amy-kwan

Copy link
Copy Markdown
Contributor

This patch updates the compiler and std code to match recent libc updates affecting AIX targets. In particular:

  • Fix libc::loadquery to use *mut c_void instead of *mut u8, which is aligned with the expected FFI signature.
  • Replace st_*time stat fields with the newer st_atim, st_mtim, st_ctim fields across AIX-specific filesystem code.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 26, 2026
@rustbot

rustbot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates

This patch updates the compiler and std code to match recent libc updates
affecting AIX targets. In particular:

- Fix `libc::loadquery` to use `*mut c_void` instead of `*mut u8`,
  which is aligned with the expected FFI signature.
- Replace `st_*time` stat fields with the newer `st_atim`, `st_mtim`, `st_ctim`
  fields across AIX-specific filesystem code.

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
r? me @bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 73cbdcc has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 29, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request May 29, 2026
…, r=JohnTitor

[AIX] Sync compiler and std with libc changes

This patch updates the compiler and std code to match recent libc updates affecting AIX targets. In particular:

- Fix `libc::loadquery` to use `*mut c_void` instead of `*mut u8`, which is aligned with the expected FFI signature.
- Replace `st_*time` stat fields with the newer `st_atim`, `st_mtim`, `st_ctim` fields across AIX-specific filesystem code.
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
Rollup of 10 pull requests

Successful merges:

 - #157050 (Couple of changes to help with moving LTO to the link phase)
 - #148345 (add inline to copy_within)
 - #156931 (Add splitting caveats to `{read,write}_volatile`)
 - #156980 (Add frame pointer annotations to the module)
 - #156991 ([AIX] Sync compiler and std with libc changes)
 - #157008 (Avoid some symbol interning)
 - #157038 (android: implement file locking by calling flock)
 - #157071 (Fix `cfg` typo in rustdoc book)
 - #157080 (Fix typo in Rustdoc release notes)
 - #157084 (Clean up error reporting for impl Drop enum casts)
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #156867 (Stop needing an alloca for `catch_unwind`)
 - #157050 (Couple of changes to help with moving LTO to the link phase)
 - #148345 (add inline to copy_within)
 - #156931 (Add splitting caveats to `{read,write}_volatile`)
 - #156980 (Add frame pointer annotations to the module)
 - #156991 ([AIX] Sync compiler and std with libc changes)
 - #157008 (Avoid some symbol interning)
 - #157038 (android: implement file locking by calling flock)
 - #157071 (Fix `cfg` typo in rustdoc book)
 - #157080 (Fix typo in Rustdoc release notes)
 - #157084 (Clean up error reporting for impl Drop enum casts)
 - #157091 (Remove minicore ping for myself)
rust-bors Bot pushed a commit that referenced this pull request May 29, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #156867 (Stop needing an alloca for `catch_unwind`)
 - #157050 (Couple of changes to help with moving LTO to the link phase)
 - #148345 (add inline to copy_within)
 - #156931 (Add splitting caveats to `{read,write}_volatile`)
 - #156980 (Add frame pointer annotations to the module)
 - #156991 ([AIX] Sync compiler and std with libc changes)
 - #157008 (Avoid some symbol interning)
 - #157038 (android: implement file locking by calling flock)
 - #157071 (Fix `cfg` typo in rustdoc book)
 - #157080 (Fix typo in Rustdoc release notes)
 - #157084 (Clean up error reporting for impl Drop enum casts)
 - #157091 (Remove minicore ping for myself)
@rust-bors
rust-bors Bot merged commit 2d83eca into rust-lang:main May 29, 2026
12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone May 29, 2026
rust-timer added a commit that referenced this pull request May 29, 2026
Rollup merge of #156991 - amy-kwan:amy-kwan/aix-libc-changes, r=JohnTitor

[AIX] Sync compiler and std with libc changes

This patch updates the compiler and std code to match recent libc updates affecting AIX targets. In particular:

- Fix `libc::loadquery` to use `*mut c_void` instead of `*mut u8`, which is aligned with the expected FFI signature.
- Replace `st_*time` stat fields with the newer `st_atim`, `st_mtim`, `st_ctim` fields across AIX-specific filesystem code.
phraakture pushed a commit to phraakture/miri that referenced this pull request May 30, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#156867 (Stop needing an alloca for `catch_unwind`)
 - rust-lang/rust#157050 (Couple of changes to help with moving LTO to the link phase)
 - rust-lang/rust#148345 (add inline to copy_within)
 - rust-lang/rust#156931 (Add splitting caveats to `{read,write}_volatile`)
 - rust-lang/rust#156980 (Add frame pointer annotations to the module)
 - rust-lang/rust#156991 ([AIX] Sync compiler and std with libc changes)
 - rust-lang/rust#157008 (Avoid some symbol interning)
 - rust-lang/rust#157038 (android: implement file locking by calling flock)
 - rust-lang/rust#157071 (Fix `cfg` typo in rustdoc book)
 - rust-lang/rust#157080 (Fix typo in Rustdoc release notes)
 - rust-lang/rust#157084 (Clean up error reporting for impl Drop enum casts)
 - rust-lang/rust#157091 (Remove minicore ping for myself)
@amy-kwan

amy-kwan commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot label +stable-nominated

Would be ideal for 1.97, as we cannot build on the AIX target without this patch.

Just realized the message below and that I'm not able to nominate this myself.

@rustbot

rustbot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Error: Label stable-nominated can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@amy-kwan

Copy link
Copy Markdown
Contributor Author

Hi @JohnTitor - is it possible to nominate this PR for stable?

@Mark-Simulacrum Mark-Simulacrum added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Jul 14, 2026

@workingjubilee workingjubilee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've only heard back from a few people on libs/compiler but I would be surprised if this was backported, sorry. We already have built the artifacts and this would require a rebuild for a tier 3 platform. If it had been nominated for beta after its merge (so, "almost any time in June", basically), I expect we would have simply agreed to backport as minor patches like this one are easy to just say "sure, why not" about for beta.

@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

stable backport declined as per compiler team on Zulip.

@rustbot rustbot removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Jul 15, 2026
@amy-kwan

Copy link
Copy Markdown
Contributor Author

We've only heard back from a few people on libs/compiler but I would be surprised if this was backported, sorry. We already have built the artifacts and this would require a rebuild for a tier 3 platform. If it had been nominated for beta after its merge (so, "almost any time in June", basically), I expect we would have simply agreed to backport as minor patches like this one are easy to just say "sure, why not" about for beta.

Thanks! That makes sense and understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants