[AIX] Sync compiler and std with libc changes - #156991
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This patch updates the compiler and std code to match recent libc updates affecting AIX targets. In particular: - Fix `libc::loadquery` to use `*mut c_void` instead of `*mut u8`, which is aligned with the expected FFI signature. - Replace `st_*time` stat fields with the newer `st_atim`, `st_mtim`, `st_ctim` fields across AIX-specific filesystem code.
…, r=JohnTitor [AIX] Sync compiler and std with libc changes This patch updates the compiler and std code to match recent libc updates affecting AIX targets. In particular: - Fix `libc::loadquery` to use `*mut c_void` instead of `*mut u8`, which is aligned with the expected FFI signature. - Replace `st_*time` stat fields with the newer `st_atim`, `st_mtim`, `st_ctim` fields across AIX-specific filesystem code.
Rollup of 10 pull requests Successful merges: - #157050 (Couple of changes to help with moving LTO to the link phase) - #148345 (add inline to copy_within) - #156931 (Add splitting caveats to `{read,write}_volatile`) - #156980 (Add frame pointer annotations to the module) - #156991 ([AIX] Sync compiler and std with libc changes) - #157008 (Avoid some symbol interning) - #157038 (android: implement file locking by calling flock) - #157071 (Fix `cfg` typo in rustdoc book) - #157080 (Fix typo in Rustdoc release notes) - #157084 (Clean up error reporting for impl Drop enum casts)
…uwer Rollup of 12 pull requests Successful merges: - #156867 (Stop needing an alloca for `catch_unwind`) - #157050 (Couple of changes to help with moving LTO to the link phase) - #148345 (add inline to copy_within) - #156931 (Add splitting caveats to `{read,write}_volatile`) - #156980 (Add frame pointer annotations to the module) - #156991 ([AIX] Sync compiler and std with libc changes) - #157008 (Avoid some symbol interning) - #157038 (android: implement file locking by calling flock) - #157071 (Fix `cfg` typo in rustdoc book) - #157080 (Fix typo in Rustdoc release notes) - #157084 (Clean up error reporting for impl Drop enum casts) - #157091 (Remove minicore ping for myself)
…uwer Rollup of 12 pull requests Successful merges: - #156867 (Stop needing an alloca for `catch_unwind`) - #157050 (Couple of changes to help with moving LTO to the link phase) - #148345 (add inline to copy_within) - #156931 (Add splitting caveats to `{read,write}_volatile`) - #156980 (Add frame pointer annotations to the module) - #156991 ([AIX] Sync compiler and std with libc changes) - #157008 (Avoid some symbol interning) - #157038 (android: implement file locking by calling flock) - #157071 (Fix `cfg` typo in rustdoc book) - #157080 (Fix typo in Rustdoc release notes) - #157084 (Clean up error reporting for impl Drop enum casts) - #157091 (Remove minicore ping for myself)
Rollup merge of #156991 - amy-kwan:amy-kwan/aix-libc-changes, r=JohnTitor [AIX] Sync compiler and std with libc changes This patch updates the compiler and std code to match recent libc updates affecting AIX targets. In particular: - Fix `libc::loadquery` to use `*mut c_void` instead of `*mut u8`, which is aligned with the expected FFI signature. - Replace `st_*time` stat fields with the newer `st_atim`, `st_mtim`, `st_ctim` fields across AIX-specific filesystem code.
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#156867 (Stop needing an alloca for `catch_unwind`) - rust-lang/rust#157050 (Couple of changes to help with moving LTO to the link phase) - rust-lang/rust#148345 (add inline to copy_within) - rust-lang/rust#156931 (Add splitting caveats to `{read,write}_volatile`) - rust-lang/rust#156980 (Add frame pointer annotations to the module) - rust-lang/rust#156991 ([AIX] Sync compiler and std with libc changes) - rust-lang/rust#157008 (Avoid some symbol interning) - rust-lang/rust#157038 (android: implement file locking by calling flock) - rust-lang/rust#157071 (Fix `cfg` typo in rustdoc book) - rust-lang/rust#157080 (Fix typo in Rustdoc release notes) - rust-lang/rust#157084 (Clean up error reporting for impl Drop enum casts) - rust-lang/rust#157091 (Remove minicore ping for myself)
|
@rustbot label +stable-nominated
Just realized the message below and that I'm not able to nominate this myself. |
|
Error: Label stable-nominated can only be set by Rust team members Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
|
Hi @JohnTitor - is it possible to nominate this PR for stable? |
There was a problem hiding this comment.
We've only heard back from a few people on libs/compiler but I would be surprised if this was backported, sorry. We already have built the artifacts and this would require a rebuild for a tier 3 platform. If it had been nominated for beta after its merge (so, "almost any time in June", basically), I expect we would have simply agreed to backport as minor patches like this one are easy to just say "sure, why not" about for beta.
|
stable backport declined as per compiler team on Zulip. |
Thanks! That makes sense and understood. |
This patch updates the compiler and std code to match recent libc updates affecting AIX targets. In particular:
libc::loadqueryto use*mut c_voidinstead of*mut u8, which is aligned with the expected FFI signature.st_*timestat fields with the newerst_atim,st_mtim,st_ctimfields across AIX-specific filesystem code.