Skip to content

Split Components iterator to prefixed and non-prefixed versions and optimize Components for non-prefix path based platforms #156496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asder8215 wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Split Components iterator to prefixed and non-prefixed versions and optimize Components for non-prefix path based platforms #156496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
60ae269
Redesigned Components iterator to use front and back indexing instead…
asder8215 May 5, 2026
8fe668f
Refactored some code, check subslice in fast path of Components Equal…
asder8215 May 13, 2026
4acc8b9
Optimized finding first separator in the front and back direction usi…
asder8215 May 16, 2026
48d7a40
Renamed advanced_* functions to normalize_*, refactored code inside t…
asder8215 May 17, 2026
24722fe
Removed trim_trailing_sep function inside Path::components and used C…
asder8215 May 17, 2026
e73d25b
Improve performance of compare_components function using what was don…
asder8215 May 21, 2026
8ef6a66
Separated consume_first_component function into consume_first_compone…
asder8215 Jun 3, 2026
c7e0b5f
Fast path check first component if both are Some(_), do byte by byte …
asder8215 Jun 4, 2026
27c0097
Removed #[inline] on Components methods + refactored code/comments to…
asder8215 Jun 22, 2026
d4696fa
Optimize Path/PathBuf PartialEq trait implementation by using OsStr b…
asder8215 Jul 8, 2026
df7c550
Implement Components iterator with a subslicing approach, add a fast …
asder8215 Jul 16, 2026
006de5e
Simplify Path PartialEq to just use Components PartialEq, optimize Pa…
asder8215 Aug 21, 2026
d0b7c95
Optimize Components::next, Components::next_back with using a bit mor…
asder8215 Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
488 changes: 45 additions & 443 deletions library/std/src/path.rs
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions library/std/src/sys/path/cygwin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ pub const fn is_verbatim_sep(b: u8) -> bool {

pub use super::windows_prefix::parse_prefix;

pub const HAS_PREFIXES: bool = true;

unsafe extern "C" {
// Doc: https://cygwin.com/cygwin-api/func-cygwin-conv-path.html
// Src: https://github.com/cygwin/cygwin/blob/718a15ba50e0d01c79800bd658c2477f9a603540/winsup/cygwin/path.cc#L3902
Expand Down Expand Up @@ -55,7 +53,7 @@ pub(crate) fn absolute(path: &Path) -> io::Result<PathBuf> {
Ok(PathBuf::from(OsString::from_vec(buffer)))
})
.map(|path| {
if path.prefix().is_some() {
if path.components().0.prefix().is_some() {
return path;
}

Expand All @@ -81,7 +79,7 @@ pub(crate) fn absolute(path: &Path) -> io::Result<PathBuf> {

pub(crate) fn is_absolute(path: &Path) -> bool {
if path.as_os_str().as_encoded_bytes().starts_with(b"\\") {
path.has_root() && path.prefix().is_some()
path.has_root() && path.components().0.prefix().is_some()
} else {
path.has_root()
}
Expand Down
12 changes: 12 additions & 0 deletions library/std/src/sys/path/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,29 +19,41 @@ macro_rules! path_separator_bytes {

cfg_select! {
target_os = "windows" => {
mod prefixed_paths;
mod windows;
mod windows_prefix;
pub use prefixed_paths::*;
pub use windows::*;
}
all(target_vendor = "fortanix", target_env = "sgx") => {
mod nonprefixed_paths;
mod sgx;
pub use nonprefixed_paths::*;
pub use sgx::*;
}
target_os = "solid_asp3" => {
mod prefixed_paths;
mod unsupported_backslash;
pub use prefixed_paths::*;
pub use unsupported_backslash::*;
}
target_os = "uefi" => {
mod prefixed_paths;
mod uefi;
pub use prefixed_paths::*;
pub use uefi::*;
}
target_os = "cygwin" => {
mod cygwin;
mod prefixed_paths;
mod windows_prefix;
pub use cygwin::*;
pub use prefixed_paths::*;
}
_ => {
mod nonprefixed_paths;
mod unix;
pub use nonprefixed_paths::*;
pub use unix::*;
}
}
Loading
Loading