bootstrap: add bootstrap step to run intrinsic-test in CI by xonx4l · Pull Request #156356 · rust-lang/rust

xonx4l · 2026-05-09T10:35:55Z

This PR ports library/stdarch/crates/intrinsic-test crate into the bootstrap test runner as a step, so that we can run the intrinsic-test suite via x.py test.

Changes -:
Ports intrinsic-test from the stdarch crate into the bootstrap system as a new test step so it runs inside the existing
x86_64-gnu and aarch64-gnu CI jobs .
Added intrinsic-test in src/bootstrap/src/core/build_steps/test.rs .
Registers intrinsic-test as a bootstrap tool in tool.rs .
Installs clang, lld, and Intel SDE in the respective Dockerfiles.

r? @Kobzol

try-job: x86_64-gnu

rustbot · 2026-05-09T10:35:59Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

folkertdev · 2026-05-10T14:23:54Z

+    fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
+        run.path("library/stdarch/crates/intrinsic-test")
+    }


the intrinsic tests should also run when any of the source in core_arch changes (unless I'm misinterpreting what this function does).

View changes since the review

No you are not misinterpreting :) . You're so right I have added the core_arch path so it triggers . Thanks for the review.

folkertdev · 2026-05-10T14:25:46Z

+RUN curl -L http://ci-mirrors.rust-lang.org/sde-external-10.8.0-2026-03-15-lin.tar.xz -o /tmp/sde.tar.xz \
+  && mkdir -p /intel-sde \
+  && tar -xJf /tmp/sde.tar.xz --strip-components=1 -C /intel-sde \
+  && rm /tmp/sde.tar.xz


this doesn't need an instant fix, but we bump the version of this tool occasionally, so ideally we'd sync that version between the repositories.

View changes since the review

Kobzol

Thank you!

I wonder what to do about the required dependencies. GCC/Clang is fine, but the SDE emulator seems problematic. We have a lot of CI jobs that will run the intrinsics test and I don't think it is great if we install it on all of them. Of course it is also not great if it is required when running tests locally.

I think that we should make this test be non-default for now, and run it explicitly on selected CI jobs.

View changes since this review

Kobzol · 2026-05-27T07:53:03Z

+
+        let crates_link = out_dir.join("crates");
+        if !crates_link.exists() {
+            std::os::unix::fs::symlink(builder.src.join("library/stdarch/crates"), &crates_link)


This won't work on non-Linux OSes. Why do we need this symlink?

There are existing functions in bootstrap to create symlinks, see symlink_dir.

we need symlink because the generated Cargo.toml files depend on core_arch via a relative path. We generate into the build directory to avoid writing into the submodule so that path doesn't exist there. The symlink points back at the real stdarch crates so it resolves.

xonx4l · 2026-05-27T17:57:49Z

Thank you!

I wonder what to do about the required dependencies. GCC/Clang is fine, but the SDE emulator seems problematic. We have a lot of CI jobs that will run the intrinsics test and I don't think it is great if we install it on all of them. Of course it is also not great if it is required when running tests locally.

I think that we should make this test be non-default for now, and run it explicitly on selected CI jobs.

View changes since this review

Yes , non-default and run it explicitly on selected CI jobs is better way to handle instead on every CI jobs .

Kobzol · 2026-05-30T12:56:45Z

Let's run this test explicitly in the ‎x86_64-gnu CI job, as a start. The Dockerfile will need to run something like x test intrinsic-test.

xonx4l · 2026-06-01T11:44:59Z

Let's run this test explicitly in the ‎x86_64-gnu CI job, as a start. The Dockerfile will need to run something like x test intrinsic-test.

@Kobzol As I added the x86_64-gnu Dockerfile invocation you suggested and ran ./x test library/stdarch/crates/intrinsic-test locally . It failed giving this error.

warning: hidden lifetime parameters in types are deprecated
--> library/stdarch/crates/intrinsic-test/src/common/indentation.rs:20:37
|
20 | fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
| ----------^^^^^^^^^
| |
| expected lifetime parameter
|
= note: -W elided-lifetimes-in-paths implied by -W rust-2018-idioms
= help: to override -W rust-2018-idioms add #[allow(elided_lifetimes_in_paths)]
help: indicate the anonymous lifetime
|
20 | fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
| ++++

error: intrinsic-test (bin "intrinsic-test") generated 1 warning
error: warnings are denied by build.warnings configuration
Build completed unsuccessfully in 0:00:07

Kobzol · 2026-06-01T14:32:51Z

You can just fix the warning, the change will be later synced back to stdarch.

Kobzol · 2026-06-21T16:02:09Z

Looks like it works! Thank you! Let's try.

@bors r=kobzol,folkertdev

rust-bors · 2026-06-21T16:02:11Z

📌 Commit 9b6ab66 has been approved by kobzol,folkertdev

It is now in the queue for this repository.

@Kobzol

bootstrap: add bootstrap step to run intrinsic-test in CI This PR ports `library/stdarch/crates/intrinsic-test` crate into the bootstrap test runner as a step, so that we can run the intrinsic-test suite via x.py test. Changes -: Ports `intrinsic-test` from the stdarch crate into the bootstrap system as a new test step so it runs inside the existing `x86_64-gnu` and `aarch64-gnu` CI jobs . Added `intrinsic-test` in `src/bootstrap/src/core/build_steps/test.rs` . Registers `intrinsic-test` as a bootstrap tool in `tool.rs` . Installs `clang`, `lld`, and Intel SDE in the respective Dockerfiles. r? @Kobzol try-job: x86_64-gnu

rust-bors · 2026-06-21T16:26:03Z

💔 Test for 5697a1f failed: CI. Failed job:

auto - aarch64-gnu-debug (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-06-21T16:34:02Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: aarch64-gnu-debug
##[endgroup]
    Updating crates.io index
error: failed to get `adler2` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `adler2`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of ad/le/adler2 failed

Caused by:
  curl failed

Caused by:

Kobzol · 2026-06-21T18:13:39Z

@bors retry

@Kobzol

…ol,folkertdev bootstrap: add bootstrap step to run intrinsic-test in CI This PR ports `library/stdarch/crates/intrinsic-test` crate into the bootstrap test runner as a step, so that we can run the intrinsic-test suite via x.py test. Changes -: Ports `intrinsic-test` from the stdarch crate into the bootstrap system as a new test step so it runs inside the existing `x86_64-gnu` and `aarch64-gnu` CI jobs . Added `intrinsic-test` in `src/bootstrap/src/core/build_steps/test.rs` . Registers `intrinsic-test` as a bootstrap tool in `tool.rs` . Installs `clang`, `lld`, and Intel SDE in the respective Dockerfiles. r? @Kobzol try-job: x86_64-gnu

…uwer Rollup of 9 pull requests Successful merges: - #156356 (bootstrap: add bootstrap step to run intrinsic-test in CI) - #157711 (Move proc-macro dlopen from proc-macro-srv to rustc_metadata) - #157836 (rebuild LLVM when `bootstrap.toml` config changes) - #158214 (Don't try to remove assignments in SimplifyComparisonIntegral) - #158226 (miri subtree update) - #158108 (Update actions/download-artifact action to v8.0.1) - #158150 (Update backtrace submodule to pick up AIX related fixes.) - #158178 (Use the target checking infrastructure for the diagnostic attributes) - #158195 (Add me to some rotation groups)

@Kobzol

Rollup merge of #156356 - xonx4l:port-intrinsic-test, r=kobzol,folkertdev bootstrap: add bootstrap step to run intrinsic-test in CI This PR ports `library/stdarch/crates/intrinsic-test` crate into the bootstrap test runner as a step, so that we can run the intrinsic-test suite via x.py test. Changes -: Ports `intrinsic-test` from the stdarch crate into the bootstrap system as a new test step so it runs inside the existing `x86_64-gnu` and `aarch64-gnu` CI jobs . Added `intrinsic-test` in `src/bootstrap/src/core/build_steps/test.rs` . Registers `intrinsic-test` as a bootstrap tool in `tool.rs` . Installs `clang`, `lld`, and Intel SDE in the respective Dockerfiles. r? @Kobzol try-job: x86_64-gnu

…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#156356 (bootstrap: add bootstrap step to run intrinsic-test in CI) - rust-lang/rust#157711 (Move proc-macro dlopen from proc-macro-srv to rustc_metadata) - rust-lang/rust#157836 (rebuild LLVM when `bootstrap.toml` config changes) - rust-lang/rust#158214 (Don't try to remove assignments in SimplifyComparisonIntegral) - rust-lang/rust#158226 (miri subtree update) - rust-lang/rust#158108 (Update actions/download-artifact action to v8.0.1) - rust-lang/rust#158150 (Update backtrace submodule to pick up AIX related fixes.) - rust-lang/rust#158178 (Use the target checking infrastructure for the diagnostic attributes) - rust-lang/rust#158195 (Add me to some rotation groups)

Mark-Simulacrum · 2026-07-13T12:39:37Z

+        // intrinsic-test shells out to `cargo` and `rustfmt` make bootstrap's
+        // managed binaries findable by prepending their dirs to PATH.
+        let rustfmt_path = builder.config.initial_rustfmt.clone().unwrap_or_else(|| {
+            eprintln!("intrinsic-test: rustfmt is required but not available on this channel");


This is going to break on beta/stable channels (as it says) -- is the intent to not run this test in CI on those channels? I'll drop it temporarily but we should land something on main that avoids breaking CI (as seen here - #159072 (comment)).

Good catch. I think we can simply print a warning and then skip the test (just return) from this function. @xonx4l Can you please send a PR that does that? Thanks!

Okay got it , OTW. Thanks @Mark-Simulacrum for the catch!

Here opened the PR -: #159265 .

cuviper · 2026-07-14T19:53:06Z

I wonder what to do about the required dependencies. GCC/Clang is fine, but the SDE emulator seems problematic. We have a lot of CI jobs that will run the intrinsics test and I don't think it is great if we install it on all of them. Of course it is also not great if it is required when running tests locally.
I think that we should make this test be non-default for now, and run it explicitly on selected CI jobs.

Yes , non-default and run it explicitly on selected CI jobs is better way to handle instead on every CI jobs .

I just ran into a failure while locally running ./x test library:

  could not execute process `/intel-sde/sde64 [...]`

I think this test command would be the typical recommendation for standard library contributors, so do we need to do something more explicit to exclude intrinsic-test by default?

Kobzol · 2026-07-14T21:14:52Z

Oh, I didn't realize that this would trigger during x test library, that is indeed unfortunate.

@xonx4l, could you please change should_run to run.alias("intrinsic-test"), to avoid triggering this test when people use x test library? Thanks! The CI jobs will also have to be modified, unless we land #159011 first.

cuviper · 2026-07-14T21:22:19Z

That other PR is going to make all ./x test include intrinsic-test? (and thus require /intel-sde?)

Kobzol · 2026-07-14T21:28:38Z

Yes, that's the plan. But it will be executed only at the very end, and I don't know anyone who actually runs the whole x test pipeline locally, I think we discussed this on Zulip some time ago and even the most patient people admitted that they Ctrl+C the tests after some time 😆

But if you think it's problematic, we can always just skip running the test if SDE isn't available.

Kobzol · 2026-07-14T21:32:17Z

Actually, I think it would be indeed better to follow a scheme that we already use elsewhere in bootstrap.

Allow configuring build.sde path, to avoid hardcoding it, and make it be opt in
If you run x test intrinsic-test and SDE is not configured, produce a loud error
If you run just x test and SDE is not configured, print a warning and skip the test

What do you think?

cuviper · 2026-07-14T21:36:06Z

I don't know anyone who actually runs the whole x test pipeline locally

It's not exactly local, but I do run that in our Fedora/RHEL rpmbuild, and I don't think it's feasible to get SDE in there.

The opt-in build.sde sounds like a much better way to go!

cuviper · 2026-07-14T21:37:00Z

I do also run ./x test locally though -- I guess I'm more patient than most (and missed that zulip thread).

rustbot assigned Kobzol May 9, 2026

rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label May 9, 2026