-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Added command-line argument support for wasm32-wali-linux-musl
#156062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| pub use super::common::Args; | ||
|
|
||
| /// One-time global initialization. | ||
| pub unsafe fn init(argc: isize, argv: *const *const u8) { | ||
| unsafe { imp::init(argc, argv) } | ||
| } | ||
|
|
||
| /// Returns the command line arguments | ||
| pub fn args() -> Args { | ||
| imp::args() | ||
| } | ||
|
|
||
| mod imp { | ||
| use super::Args; | ||
| use crate::ffi::{CString, OsString}; | ||
| use crate::os::raw::{c_uint as WaliArgIdx, c_uint}; | ||
| use crate::os::unix::prelude::*; | ||
| use crate::sync::OnceLock; | ||
|
|
||
| #[link(wasm_import_module = "wali")] | ||
| unsafe extern "C" { | ||
| pub fn __cl_get_argc() -> WaliArgIdx; | ||
| pub fn __cl_get_argv_len(offset: WaliArgIdx) -> c_uint; | ||
| pub fn __cl_copy_argv(buf: *mut i8, offset: WaliArgIdx) -> c_uint; | ||
| } | ||
|
|
||
| static ARGS: OnceLock<Vec<OsString>> = OnceLock::new(); | ||
|
|
||
| pub unsafe fn init(_argc: isize, _argv: *const *const u8) { | ||
| // Uses the WALI arguments API | ||
| ARGS.set(argc_argv()).ok(); | ||
| } | ||
|
|
||
| unsafe fn load_arg(idx: c_uint) -> OsString { | ||
| let arg_len = unsafe { __cl_get_argv_len(idx) }; | ||
| let arg_buf = CString::new(vec![b'x'; arg_len as usize]).unwrap(); | ||
| let ptr = arg_buf.into_raw(); | ||
| let arg_buf = unsafe { | ||
| __cl_copy_argv(ptr, idx); | ||
| CString::from_raw(ptr) | ||
| }; | ||
| let mut arg_buf = arg_buf.into_bytes_with_nul(); | ||
| let _ = arg_buf.pop(); | ||
| OsStringExt::from_vec(arg_buf) | ||
| } | ||
|
|
||
| fn argc_argv() -> Vec<OsString> { | ||
| let argc = unsafe { __cl_get_argc() }; | ||
| (0..argc).map(|x| unsafe { load_arg(x) }).collect() | ||
| } | ||
|
|
||
| pub fn args() -> Args { | ||
| let cached = ARGS.get().cloned().unwrap_or_default(); | ||
| Args::new(cached) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use
CString::into_bytesdirectly?