Skip to content

Move tests from tests/ui/issues/ to appropriate directories #155058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lokirithm wants to merge 2 commits into from
Closed

Move tests from tests/ui/issues/ to appropriate directories #155058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bdfad1
Move two tests to appropriate directories
lokirithm Apr 9, 2026
d2574d4
Add issues links at the top and update stderr file
lokirithm Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/ui/issues/issue-3874.rs → tests/ui/binding/ref-in-let-lhs-in-field.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//! regression test for <https://github.com/rust-lang/rust/issues/3874>
//@ build-pass
#![allow(dead_code)]

Expand Down
1 change: 1 addition & 0 deletions tests/ui/issues/issue-4972.rs → ...box/deref-borrowed-trait-object-in-box.rs
View file
Open in desktop

@lokirithm lokirithm Apr 10, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

A more minimal version for the second test could be, in my opinion:

trait MyTrait {
    fn dummy(&self) {}
}

struct TraitWrapper(Box<dyn MyTrait + 'static>);

fn get_tw_map(tw: &TraitWrapper) -> &dyn MyTrait {
    match *tw {
        TraitWrapper(box ref map) => map,
    }
}

pub fn main() {}

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//! regression test for <https://github.com/rust-lang/rust/issues/4972>
#![feature(box_patterns)]

trait MyTrait {
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/issues/issue-4972.stderr → ...deref-borrowed-trait-object-in-box.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0033]: type `Box<(dyn MyTrait + 'static)>` cannot be dereferenced
--> $DIR/issue-4972.rs:13:25
--> $DIR/deref-borrowed-trait-object-in-box.rs:14:25
|
LL | TraitWrapper::A(box ref map) => map,
| ^^^^^^^^^^^ type `Box<(dyn MyTrait + 'static)>` cannot be dereferenced
Expand Down
Loading