[beta] reverts and backports by cuviper · Pull Request #154999 · rust-lang/rust

cuviper · 2026-04-08T17:54:55Z

This reverts two dbg! changes to avoid regressions¹² in the upcoming 1.95 release:

std: avoid tearing dbg! prints std: avoid tearing dbg! prints #149869
don't drop arguments' temporaries in dbg! don't drop arguments' temporaries in dbg! #154074
- ... which was previously backported in [beta] backports #154725

This also reverts a stabilization over a late issue³ of semantics:

Stabilize assert_matches Stabilize assert_matches #137487

And a few other backport/reverts from main:

Revert performing basic const checks in typeck on stable Revert performing basic const checks in typeck on stable #154930 / [beta] Revert performing basic const checks in typeck on stable #155033
Revert "-Znext-solver Remove the forced ambiguity hack from search graph" Revert "-Znext-solver Remove the forced ambiguity hack from search graph" #154712
Clarify that core::range ranges do not have special syntax Clarify that core::range ranges do not have special syntax #155002

Clippy is backporting 2 ICE fixes and 1 perf regression (via #155051):

Fix ICE in match_same_arms rust-clippy#16685 already backported in [stable] 1.94.1 release #154211 to stable. This makes sure that it doesn't regress again in beta/next stable
Fix ICE in swap_binop() rust-clippy#16659 The ICE that is being fixed here was introduced in the 1.95 release cycle
Optimize allow_unwrap_types evaluation to eliminate performance regression rust-clippy#16652 Perf regression introduced in the 1.95 release cycle.

This reverts commit 1374038.

This reverts commit 4f50466.

…mulacrum" This reverts commit cc666ba, reversing changes made to 2da5959.

rustbot · 2026-04-08T17:54:59Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

rustbot · 2026-04-08T17:55:01Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 11 candidates

This reverts commit 2f3b952.

rustbot · 2026-04-08T21:19:14Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

…hack, r=lcnr" This reverts commit c108ad5, reversing changes made to 485f76b. (cherry picked from commit 22faa52)

I'm ignoring the fact that there's a feature to change the behavior of the syntax. I just want to help prevent confusing the people reading the docs. (cherry picked from commit 092f0ca)

… have special syntax I'm ignoring the fact that there's a feature to change the behavior of the syntax. I just want to help prevent confusing the people reading the docs. (cherry picked from commit eef4363)

rustbot · 2026-04-09T15:49:04Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

cuviper · 2026-04-09T16:31:15Z

Time is short for beta, so let's get this queued up...

@bors r+ rollup=never p=10

rust-bors · 2026-04-09T16:31:18Z

📌 Commit 6ae5693 has been approved by cuviper

It is now in the queue for this repository.

[beta] reverts and backports This reverts two `dbg!` changes to avoid regressions[^1][^2] in the upcoming 1.95 release: - std: avoid tearing `dbg!` prints #149869 - don't drop arguments' temporaries in `dbg!` #154074 - ... which was previously backported in #154725 This also reverts a stabilization over a late issue[^3] of semantics: - Stabilize `assert_matches` #137487 And a few other backport/reverts from `main`: - Revert performing basic const checks in typeck on stable #154930 / #155033 - Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph" #154712 - Clarify that core::range ranges do not have special syntax #155002 [^1]: #153850 [^2]: #154988 [^3]: #154406

rust-bors · 2026-04-09T17:10:52Z

💔 Test for 2eccf47 failed: CI. Failed job:

auto - arm-android (web logs, enhanced plaintext logs)

flip1995 · 2026-04-09T17:12:40Z

Also posting this here:

[beta] Clippy backport #155051

Not sure if you want to include this in this PR or merge it separately.

JonathanBrouwer · 2026-04-09T17:15:15Z

Spurious
@bors retry

cuviper · 2026-04-09T17:16:18Z

Hmm, well that failure will give me a moment to pull in the clippy backports too.

@bors r-

The wrong `TypeckResults` was used in the fallback equality function passed by the `match_same_arms` and `filter_map` lints. Previously, those fallback functions had no way of using the proper `TypeckResults`. Those (one per expression being compared) are now passed to the registered fallback function. changelog: [`match_same_arms`]: fix internal compiler error Fixes rust-lang/rust-clippy#16678 Fixes rust-lang/rust-clippy#16686   ### Summary Notes - [Beta nomination](rust-lang/rust-clippy#16685 (comment)) by [samueltardieu](https://github.com/samueltardieu) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details*

Make `swap_binop()` a method of `HirEqInterExpr`, and use the proper typeck to check the type of an expression. changelog: none (fix of a regression, should be backported) Fixes rust-lang/rust-clippy#16505   ### Summary Notes - [Beta-nomination](rust-lang/rust-clippy#16659 (comment)) by [samueltardieu](https://github.com/samueltardieu) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details*

…gression (rust-lang#16652) Fixes rust-lang/rust-clippy#16605 This PR addresses the 6.2% compilation performance regression introduced by the original `allow_unwrap_types` implementation (which natively allocated AST strings on every `unwrap` call via `bumpalo`). The implementation has been refactored to pre-resolve types securely without a performance penalty: **Pre-Resolution Cache via `LateLintPass`**: Instead of executing `ty.to_string()` and `lookup_path_str` inside the immediate `unwrap_expect_used` hot check for every method call encountered, `allow-unwrap-types` configuration strings are now parsed exactly *once* per crate compilation during the `LateLintPass::check_crate` hook in `clippy_lints/src/methods/mod.rs`. **`DefId` Native Storage**: The parsed `DefId` representations are stored in-memory using highly efficient caching maps directly on the main `Methods` struct: - `unwrap_allowed_ids: FxHashSet<DefId>`: Allows instant O(1) lookups for standard types. - `unwrap_allowed_aliases: Vec<DefId>`: Tracks type aliases requiring signature substitution checking later. **Execution Relief**: Inside `unwrap_expect_used::check()`, string manipulation is completely removed and `ty::Adt` checking uses lightning-fast `.contains(&adt.did())` operations to categorically avoid regression allocation loops. This implementation strongly parallels the pre-resolution type-routing logic in `clippy_config::types::create_disallowed_map` without altering the core `clippy.toml` config requirements.   ### Summary Notes - [Beta-nomination](rust-lang/rust-clippy#16652 (comment)) by [samueltardieu](https://github.com/samueltardieu) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details*   changelog: none

rustbot · 2026-04-09T17:19:53Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- aad47fb
- 524789f
- 0c9d5f0
- c79919a
- b6da6b8

cuviper · 2026-04-09T17:21:12Z

@bors r+

rust-bors · 2026-04-09T17:21:16Z

📌 Commit b6da6b8 has been approved by cuviper

It is now in the queue for this repository.

cuviper added 3 commits April 8, 2026 09:45

Revert "update diagnostic for variables moved by dbg!"

bca08d8

This reverts commit 1374038.

Revert "don't drop arguments' temporaries in dbg!"

cb5a913

This reverts commit 4f50466.

Revert "Rollup merge of rust-lang#149869 - joboet:torn-dbg, r=Mark-Si…

aad47fb

…mulacrum" This reverts commit cc666ba, reversing changes made to 2da5959.

rustbot assigned davidtwco Apr 8, 2026

This comment has been minimized.

Sign in to view

cuviper mentioned this pull request Apr 8, 2026

don't leak internal temporaries from dbg! #154994

Open

Revert "Stabilize assert_matches"

d0b5e61

This reverts commit 2f3b952.

cuviper changed the title ~~[beta] revert dbg! tearing changes~~ [beta] reverts Apr 8, 2026

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Apr 8, 2026

cuviper mentioned this pull request Apr 8, 2026

Tracking issue for release notes of #137487: Stabilize assert_matches #152227

Open

jieyouxu mentioned this pull request Apr 9, 2026

Add initial 1.95.0 blog rust-lang/blog.rust-lang.org#1836

Open

cuviper mentioned this pull request Apr 9, 2026

[beta] Revert performing basic const checks in typeck on stable #155033

Open

oli-obk and others added 4 commits April 9, 2026 08:34

Revert performing basic const checks in typeck on stable

2c2e33a

Revert "Rollup merge of rust-lang#149904 - ShoyuVanilla:ns-remove-sg-…

524789f

…hack, r=lcnr" This reverts commit c108ad5, reversing changes made to 485f76b. (cherry picked from commit 22faa52)

Clarify that core::range::RangeInclusive does not have special syntax

2b3d5e6

I'm ignoring the fact that there's a feature to change the behavior of the syntax. I just want to help prevent confusing the people reading the docs. (cherry picked from commit 092f0ca)

Clarify that core::range::{Range,RangeFrom,RangeToInclusive} do not…

6ae5693

… have special syntax I'm ignoring the fact that there's a feature to change the behavior of the syntax. I just want to help prevent confusing the people reading the docs. (cherry picked from commit eef4363)

rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Apr 9, 2026

cuviper changed the title ~~[beta] reverts~~ [beta] reverts and backports Apr 9, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 9, 2026

rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2026

Jarcho and others added 3 commits April 9, 2026 10:17

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 9, 2026

Uh oh!

Conversation

cuviper commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Footnotes

Uh oh!

rustbot commented Apr 8, 2026

Uh oh!

rustbot commented Apr 8, 2026

Uh oh!

This comment has been minimized.

rustbot commented Apr 8, 2026

Uh oh!

rustbot commented Apr 9, 2026

Uh oh!

This comment has been minimized.

cuviper commented Apr 9, 2026

Uh oh!

rust-bors bot commented Apr 9, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 9, 2026

Uh oh!

flip1995 commented Apr 9, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Apr 9, 2026

Uh oh!

cuviper commented Apr 9, 2026

Uh oh!

rustbot commented Apr 9, 2026

Uh oh!

cuviper commented Apr 9, 2026

Uh oh!

rust-bors bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

cuviper commented Apr 8, 2026 •

edited

Loading