Skip to content

Remove BuiltinLintDiag#154912

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
GuillaumeGomez:migrate-diag
Apr 9, 2026
Merged

Remove BuiltinLintDiag#154912
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
GuillaumeGomez:migrate-diag

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez commented Apr 6, 2026

Part of #153099.

We're finally getting rid of BuiltinLintDiag! \o/

Next step, AttributeLint. :3

r? @JonathanBrouwer

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 6, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Apr 6, 2026
@bors
Auto merge of #154912 - GuillaumeGomez:migrate-diag, r=<try>
91d403a 
Remove `BuiltinLintDiag`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 6, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 6, 2026

☀️ Try build successful (CI)
Build commit: 91d403a (91d403af565436d90bf71f389df1702ea2ebb4ff, parent: a92a99ef1479a9987b0ef76a064c2bd8e779babd)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 6, 2026

Finished benchmarking commit (91d403a): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.4%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 6.0% [6.0%, 6.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.4% [-4.9%, -4.1%] 3
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 487.739s -> 488.37s (0.13%)
Artifact size: 395.17 MiB -> 395.16 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 6, 2026
JonathanBrouwer
JonathanBrouwer approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup=iffy
Rollup=iffy because of the minor perf effect, which should be easy to pick out of a rollup since it's only one secondary test

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 8, 2026

📌 Commit caeaf19 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 8, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 8, 2026
@bors
Auto merge of #155011 - JonathanBrouwer:rollup-9GJWM3g, r=JonathanBro…
d0442e2 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154912 (Remove `BuiltinLintDiag`)
 - #154598 (test `#[naked]` with `#[link_section = "..."]` on windows)
 - #154719 (Hexagon inline asm: add reg_pair, vreg, vreg_pair, and qreg register classes)
 - #154057 (Parenthesize block-like expressions in index base of pretty printer)
 - #154893 (make `expected_literal` positive)
 - #155002 (Clarify that `core::range` ranges do not have special syntax)
@rust-bors rust-bors bot merged commit 1d0d172 into rust-lang:main Apr 9, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 9, 2026
rust-timer added a commit that referenced this pull request Apr 9, 2026
@rust-timer
Unrolled build for #154912
f962ca4 
Rollup merge of #154912 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer

Remove `BuiltinLintDiag`

Part of #153099.

We're finally getting rid of `BuiltinLintDiag`! \o/

Next step, `AttributeLint`. :3

r? @JonathanBrouwer
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 9, 2026
Open
3 tasks
@GuillaumeGomez GuillaumeGomez deleted the migrate-diag branch April 9, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @rustbot @JonathanBrouwer @rust-timer