Skip to content

Slightly refactor mplace<->ptr conversions#154894

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
WaffleLapkin:mplace_ptr_conversions
Apr 7, 2026
Merged

Slightly refactor mplace<->ptr conversions#154894
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
WaffleLapkin:mplace_ptr_conversions

Conversation

@WaffleLapkin
Copy link
Copy Markdown
Member

split off of #154327

r? RalfJung

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

RalfJung is not on the review rotation at the moment.
They may take a while to respond.

Copy link
Copy Markdown
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

r=me with these nits resolved and CI happy.

View changes since this review

@WaffleLapkin WaffleLapkin force-pushed the mplace_ptr_conversions branch from 985c533 to 407259b Compare April 6, 2026 15:41
@WaffleLapkin
Copy link
Copy Markdown
Member Author

@bors r=RalfJung

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 6, 2026

📌 Commit 407259b has been approved by RalfJung

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 6, 2026
…s, r=RalfJung

Slightly refactor mplace<->ptr conversions

split off of rust-lang#154327

r? RalfJung
rust-bors bot pushed a commit that referenced this pull request Apr 7, 2026
Rollup of 6 pull requests

Successful merges:

 - #154627 (Move `rustc_middle::mir::mono` to `rustc_middle::mono`)
 - #154729 (de-non_const some `Iterator` methods)
 - #154891 (implement `StructuralPartialEq` for `MaybeDangling`)
 - #154894 (Slightly refactor mplace<->ptr conversions)
 - #154751 (compiletest: Remove `rfail` support from incremental tests)
 - #154901 (Update books)
@rust-bors rust-bors bot merged commit 82bcdd1 into rust-lang:main Apr 7, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 7, 2026
rust-timer added a commit that referenced this pull request Apr 7, 2026
Rollup merge of #154894 - WaffleLapkin:mplace_ptr_conversions, r=RalfJung

Slightly refactor mplace<->ptr conversions

split off of #154327

r? RalfJung
@WaffleLapkin WaffleLapkin deleted the mplace_ptr_conversions branch April 7, 2026 11:42
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Apr 8, 2026
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#154627 (Move `rustc_middle::mir::mono` to `rustc_middle::mono`)
 - rust-lang/rust#154729 (de-non_const some `Iterator` methods)
 - rust-lang/rust#154891 (implement `StructuralPartialEq` for `MaybeDangling`)
 - rust-lang/rust#154894 (Slightly refactor mplace<->ptr conversions)
 - rust-lang/rust#154751 (compiletest: Remove `rfail` support from incremental tests)
 - rust-lang/rust#154901 (Update books)
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 8, 2026
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#154627 (Move `rustc_middle::mir::mono` to `rustc_middle::mono`)
 - rust-lang/rust#154729 (de-non_const some `Iterator` methods)
 - rust-lang/rust#154891 (implement `StructuralPartialEq` for `MaybeDangling`)
 - rust-lang/rust#154894 (Slightly refactor mplace<->ptr conversions)
 - rust-lang/rust#154751 (compiletest: Remove `rfail` support from incremental tests)
 - rust-lang/rust#154901 (Update books)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants