Rollup of 2 pull requests#154769
Closed
JonathanBrouwer wants to merge 10 commits intorust-lang:mainfrom
Closed
Conversation
…te-field-deref-fresh, r=estebank Improve shadowed private field diagnostics Fixes rust-lang#149546 I tried to extend the diagnostic to more scenarios, like method call, type mismatch errors. r? @estebank
…Brouwer Remove rustc_on_unimplemented's append_const_msg This does nothing because it is unreachable within the compiler. It also doesn't seem that useful since all the traits it was on are `const` now. Will make pr to rustc-dev-guide docs later.
rustbot
added
A-attributes
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
Create a similar rollup