Skip to content

Remove an unused StableHash impl.#154743

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
nnethercote:rm-two-unused-HashStable-impls
Apr 4, 2026
Merged

Remove an unused StableHash impl.#154743
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
nnethercote:rm-two-unused-HashStable-impls

Conversation

@nnethercote
Copy link
Copy Markdown
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 3, 2026
@nnethercote nnethercote force-pushed the rm-two-unused-HashStable-impls branch from 743c703 to c3d9f99 Compare April 3, 2026 12:01
@nnethercote nnethercote changed the title Remove two unused StableHash impls. Remove an unused StableHash impl. Apr 3, 2026
@nnethercote
Copy link
Copy Markdown
Contributor Author

I didn't think of specialization; the [hir::Attribute] impl is reachable.

I have updated the PR to reinstate that impl. It now just removes one impl.

@TaKO8Ki
Copy link
Copy Markdown
Member

TaKO8Ki commented Apr 3, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 3, 2026

📌 Commit c3d9f99 has been approved by TaKO8Ki

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 3, 2026
…le-impls, r=TaKO8Ki

Remove an unused `StableHash` impl.

r? @TaKO8Ki
rust-bors bot pushed a commit that referenced this pull request Apr 3, 2026
Rollup of 5 pull requests

Successful merges:

 - #153286 (various fixes for scalable vectors)
 - #153592 (Add  `min_adt_const_params` gate)
 - #154051 (use libm for acosh and asinh for f16, f32, and f64)
 - #154743 (Remove an unused `StableHash` impl.)
 - #154752 (Add comment to borrow-checker)
rust-bors bot pushed a commit that referenced this pull request Apr 3, 2026
Rollup of 7 pull requests

Successful merges:

 - #153286 (various fixes for scalable vectors)
 - #153592 (Add  `min_adt_const_params` gate)
 - #154675 (Improve shadowed private field diagnostics)
 - #154653 (Remove rustc_on_unimplemented's append_const_msg)
 - #154743 (Remove an unused `StableHash` impl.)
 - #154752 (Add comment to borrow-checker)
 - #154764 (Add tests for three ICEs that have already been fixed)
rust-bors bot pushed a commit that referenced this pull request Apr 3, 2026
Rollup of 7 pull requests

Successful merges:

 - #153286 (various fixes for scalable vectors)
 - #153592 (Add  `min_adt_const_params` gate)
 - #154675 (Improve shadowed private field diagnostics)
 - #154653 (Remove rustc_on_unimplemented's append_const_msg)
 - #154743 (Remove an unused `StableHash` impl.)
 - #154752 (Add comment to borrow-checker)
 - #154764 (Add tests for three ICEs that have already been fixed)
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 4, 2026
…le-impls, r=TaKO8Ki

Remove an unused `StableHash` impl.

r? @TaKO8Ki
rust-bors bot pushed a commit that referenced this pull request Apr 4, 2026
Rollup of 10 pull requests

Successful merges:

 - #154376 (Remove more BuiltinLintDiag variants - part 4)
 - #127534 (feat(core): impl Step for NonZero<u*>)
 - #153286 (various fixes for scalable vectors)
 - #153592 (Add  `min_adt_const_params` gate)
 - #154675 (Improve shadowed private field diagnostics)
 - #154703 (Fix trailing comma in lifetime suggestion for empty angle brackets)
 - #154653 (Remove rustc_on_unimplemented's append_const_msg)
 - #154743 (Remove an unused `StableHash` impl.)
 - #154752 (Add comment to borrow-checker)
 - #154764 (Add tests for three ICEs that have already been fixed)
rust-bors bot pushed a commit that referenced this pull request Apr 4, 2026
Rollup of 7 pull requests

Successful merges:

 - #153286 (various fixes for scalable vectors)
 - #153592 (Add  `min_adt_const_params` gate)
 - #154675 (Improve shadowed private field diagnostics)
 - #154653 (Remove rustc_on_unimplemented's append_const_msg)
 - #154743 (Remove an unused `StableHash` impl.)
 - #154752 (Add comment to borrow-checker)
 - #154764 (Add tests for three ICEs that have already been fixed)
@rust-bors rust-bors bot merged commit ad8468c into rust-lang:main Apr 4, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 4, 2026
rust-timer added a commit that referenced this pull request Apr 4, 2026
Rollup merge of #154743 - nnethercote:rm-two-unused-HashStable-impls, r=TaKO8Ki

Remove an unused `StableHash` impl.

r? @TaKO8Ki
@nnethercote nnethercote deleted the rm-two-unused-HashStable-impls branch April 5, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants