Update cargo submodule by weihanglo · Pull Request #154734 · rust-lang/rust

weihanglo · 2026-04-02T22:41:25Z

15 commits in 888f675344eb1cf2308fd53183e667bdd2c58e51..a357df4c26fc14514e66aae2a269456b5545c7db
2026-03-30 16:59:25 +0000 to 2026-04-03 16:47:15 +0000

chore: downgrade to libz-sys@1.1.24 (chore: downgrade to libz-sys@1.1.24 cargo#16833)
feat: add frame-pointers profile option (feat: add frame-pointers profile option cargo#16742)
upgrade to gix@0.81.0 (upgrade to gix@0.81.0 cargo#16828)
refactor(network): use async for registry network operations (refactor(network): use async for registry network operations cargo#16745)
fix(compile): Don't hide hard warnings with build.warnings=allow (fix(compile): Don't hide hard warnings with build.warnings=allow cargo#16827)
chore: Upgrade incompatible dependencies (chore: Upgrade incompatible dependencies cargo#16825)
fix(compile): build.warnings=allow should not hide denied diagnostics (fix(compile): build.warnings=allow should not hide denied diagnostics cargo#16824)
fix(install): Ignore resolver.lockfile-path (fix(install): Ignore resolver.lockfile-path cargo#16823)
chore(deps): update compatible (chore(deps): update compatible cargo#16820)
refactor(compile): Consolidate output options (refactor(compile): Consolidate output options cargo#16821)
refactor: Export public dependencies from internal crates (refactor: Export public dependencies from internal crates cargo#16819)
refactor(progress): Make the code more approachable (refactor(progress): Make the code more approachable cargo#16813)
Simplified build script bin names in new layout (Simplified build script bin names in new layout cargo#16812)
fix: set CARGO env var during rustc -vV probe (fix: set CARGO env var during rustc -vV probe cargo#16811)
Split out cargo-util-terminal (Split out cargo-util-terminal cargo#16809)

rustbot · 2026-04-02T22:41:29Z

Some changes occurred in src/tools/cargo

cc @ehuss

rustbot · 2026-04-02T22:41:30Z

⚠️ Warning ⚠️

Some commits in this PR modify submodules.

If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

weihanglo · 2026-04-02T22:42:15Z

rust-lang/cargo#16745 is huge enough so want to get this to nightly ASAP to get a longer test window before hitting stable.

weihanglo · 2026-04-02T23:01:39Z

@bors r+ rollup=never p=1

rust-bors · 2026-04-02T23:01:42Z

📌 Commit b4f3f26 has been approved by weihanglo

It is now in the queue for this repository.

Update cargo submodule 12 commits in 888f675344eb1cf2308fd53183e667bdd2c58e51..0c7d80bf5ad3b873a5dbf44e0185152890c6d18a 2026-03-30 16:59:25 +0000 to 2026-04-02 20:48:06 +0000 - refactor(network): use async for registry network operations (rust-lang/cargo#16745) - fix(compile): Don't hide hard warnings with build.warnings=allow (rust-lang/cargo#16827) - chore: Upgrade incompatible dependencies (rust-lang/cargo#16825) - fix(compile): build.warnings=allow should not hide denied diagnostics (rust-lang/cargo#16824) - fix(install): Ignore resolver.lockfile-path (rust-lang/cargo#16823) - chore(deps): update compatible (rust-lang/cargo#16820) - refactor(compile): Consolidate output options (rust-lang/cargo#16821) - refactor: Export public dependencies from internal crates (rust-lang/cargo#16819) - refactor(progress): Make the code more approachable (rust-lang/cargo#16813) - Simplified build script bin names in new layout (rust-lang/cargo#16812) - fix: set CARGO env var during rustc -vV probe (rust-lang/cargo#16811) - Split out `cargo-util-terminal` (rust-lang/cargo#16809) r? ghost

rust-bors · 2026-04-03T00:49:01Z

💔 Test for 9814779 failed: CI. Failed job:

auto - dist-x86_64-freebsd (web logs, enhanced plaintext logs)

This follows upstream's change in madler/zlib@1382e6611 due to EWOULDBLOCK is used since madler/zlib@81cc0bebe and `-D_POSIX_SOURCE` would hide `#define EWOULDBLOCK EAGAIN`. See <https://github.com/freebsd/freebsd-src/blob/3e9f4fd6fc50300d052d5619d82a14d3488483d5/sys/sys/errno.h#L92-L93> Actually I feel like _POSIX_C_SOURCE=200112L maybe redundant though let's just do whatever upstream does This was found in * <rust-lang/rust#154734> * <https://triage.rust-lang.org/gha-logs/rust-lang/rust/69786578177>

weihanglo · 2026-04-03T04:22:39Z

Going to try freebsd with my libz-sys change weihanglo/libz-sys@73817ec.

Since it is a relatively domain I am not really familiar with, I'll try more tier 2 with host tools platforms.

@bors try jobs=dist-x86_64-freebsd,dist-x86_64-illumos,dist-x86_64-netbsd,dist-x86_64-solaris,dist-x86_64-apple,dist-powerpc-linux-gnu,dist-riscv64-linux

Update cargo submodule try-job: dist-x86_64-freebsd try-job: dist-x86_64-illumos try-job: dist-x86_64-netbsd try-job: dist-x86_64-solaris try-job: dist-x86_64-apple try-job: dist-powerpc-linux-gnu try-job: dist-riscv64-linux

weihanglo · 2026-04-03T04:25:23Z

Oops. #154734 (comment) failed. Try again.

@bors try jobs=dist-x86_64-freebsd,dist-x86_64-illumos,dist-x86_64-netbsd,dist-x86_64-solaris,dist-x86_64-apple,dist-powerpc-linux,dist-riscv64-linux

Update cargo submodule try-job: dist-x86_64-freebsd try-job: dist-x86_64-illumos try-job: dist-x86_64-netbsd try-job: dist-x86_64-solaris try-job: dist-x86_64-apple try-job: dist-powerpc-linux try-job: dist-riscv64-linux

rust-bors · 2026-04-03T06:43:45Z

☀️ Try build successful (CI)
Build commit: 8c77a37 (8c77a3707198188bc872d9145a42878cb18cf425, parent: 55e86c996809902e8bbad512cfb4d2c18be446d9)

Update cargo submodule 15 commits in 888f675344eb1cf2308fd53183e667bdd2c58e51..a357df4c26fc14514e66aae2a269456b5545c7db 2026-03-30 16:59:25 +0000 to 2026-04-03 16:47:15 +0000 - chore: downgrade to libz-sys@1.1.24 (rust-lang/cargo#16833) - feat: add frame-pointers profile option (rust-lang/cargo#16742) - upgrade to gix@0.81.0 (rust-lang/cargo#16828) - refactor(network): use async for registry network operations (rust-lang/cargo#16745) - fix(compile): Don't hide hard warnings with build.warnings=allow (rust-lang/cargo#16827) - chore: Upgrade incompatible dependencies (rust-lang/cargo#16825) - fix(compile): build.warnings=allow should not hide denied diagnostics (rust-lang/cargo#16824) - fix(install): Ignore resolver.lockfile-path (rust-lang/cargo#16823) - chore(deps): update compatible (rust-lang/cargo#16820) - refactor(compile): Consolidate output options (rust-lang/cargo#16821) - refactor: Export public dependencies from internal crates (rust-lang/cargo#16819) - refactor(progress): Make the code more approachable (rust-lang/cargo#16813) - Simplified build script bin names in new layout (rust-lang/cargo#16812) - fix: set CARGO env var during rustc -vV probe (rust-lang/cargo#16811) - Split out `cargo-util-terminal` (rust-lang/cargo#16809)

weihanglo · 2026-04-06T23:31:01Z

BTW I've tried 20 times with and without the patch,

With MFLAGS patch, 0/20 hung.
Without, 9/20 hung

So thanks Arlo for the fix!

arlosi · 2026-04-07T04:43:21Z

Seems stuck in dist-x86_64-linux building LLVM. All other jobs succeeded.

Last lines of output are:

  -- Installing: /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/BinaryFormat/MsgPack.def
  -- Installing: /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/BinaryFormat/MsgPack.h
  -- Installing: /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/BinaryFormat/MsgPackDocument.h
  -- Installing: /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/BinaryFormat/MsgPackReader.h

By comparing to a successful run, there are still more files for the LLVM build to install.

Since the LLVM build seems unrelated to updating cargo:

@bors retry

rust-bors · 2026-04-07T04:43:25Z

❗ You can only retry pull requests that are approved and have a previously failed auto build.

Hint: There is currently a pending auto build on this PR. To cancel it, run @bors cancel.

weihanglo · 2026-04-07T04:45:00Z

@bors cancel

rust-bors · 2026-04-07T04:45:04Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/24055036989

The next pull request likely to be tested is #154734.

Update cargo submodule 15 commits in 888f675344eb1cf2308fd53183e667bdd2c58e51..a357df4c26fc14514e66aae2a269456b5545c7db 2026-03-30 16:59:25 +0000 to 2026-04-03 16:47:15 +0000 - chore: downgrade to libz-sys@1.1.24 (rust-lang/cargo#16833) - feat: add frame-pointers profile option (rust-lang/cargo#16742) - upgrade to gix@0.81.0 (rust-lang/cargo#16828) - refactor(network): use async for registry network operations (rust-lang/cargo#16745) - fix(compile): Don't hide hard warnings with build.warnings=allow (rust-lang/cargo#16827) - chore: Upgrade incompatible dependencies (rust-lang/cargo#16825) - fix(compile): build.warnings=allow should not hide denied diagnostics (rust-lang/cargo#16824) - fix(install): Ignore resolver.lockfile-path (rust-lang/cargo#16823) - chore(deps): update compatible (rust-lang/cargo#16820) - refactor(compile): Consolidate output options (rust-lang/cargo#16821) - refactor: Export public dependencies from internal crates (rust-lang/cargo#16819) - refactor(progress): Make the code more approachable (rust-lang/cargo#16813) - Simplified build script bin names in new layout (rust-lang/cargo#16812) - fix: set CARGO env var during rustc -vV probe (rust-lang/cargo#16811) - Split out `cargo-util-terminal` (rust-lang/cargo#16809)

weihanglo · 2026-04-07T04:46:06Z

Ah. I thought it told us to cancel 😰.

arlosi · 2026-04-07T04:57:37Z

Cancelling it caused more logs to make it through. Last log before it hung was:

  Executing benchmark cargo-0.87.1 (2/9)
  Preparing cargo-0.87.1
  Error: The operation was canceled.

Which does seem cargo related.

@bors r-

rust-bors · 2026-04-07T04:57:42Z

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/24064745484

ehuss · 2026-04-07T11:42:37Z

Which does seem cargo related.

I'm pretty sure this does not use the in-tree cargo. This is running a benchmark against an old clone of cargo (cargo-0.87.1) compiling that old cargo, using stage2 rustc and stage0 cargo.

weihanglo · 2026-04-07T12:59:06Z

Yeah, so let's just try again

@bors retry

rust-bors · 2026-04-07T12:59:10Z

❗ You can only retry pull requests that are approved and have a previously failed auto build.

weihanglo · 2026-04-07T12:59:41Z

@bors r+ rollup=never

rust-bors · 2026-04-07T12:59:45Z

📌 Commit 34e4100 has been approved by weihanglo

It is now in the queue for this repository.

JonathanBrouwer · 2026-04-07T14:13:37Z

@bors p=1
Resetting the scheduling

JonathanBrouwer · 2026-04-07T15:27:39Z

@bors p=6
Scheduling this in front of the rollup so the rollup try jobs get a bit more time

rust-bors · 2026-04-07T19:42:40Z

☀️ Test successful - CI
Approved by: weihanglo
Duration: 3h 9m 57s
Pushing ad4b935 to main...

github-actions · 2026-04-07T19:46:03Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c3bd628 (parent) -> ad4b935 (this PR)

Test differences

Show 18 test diffs

Stage 2

build::rustc_wrapper_vv_probe_has_cargo_env: [missing] -> pass (J0)
lockfile_path::config_install_ignores_lock_file_path: [missing] -> pass (J0)
lockfile_path::config_install_lock_file_path_must_present: pass -> [missing] (J0)
lockfile_path::config_install_respects_lock_file_path: pass -> [missing] (J0)
profiles::frame_pointers_default_overrides_parent: [missing] -> pass (J0)
profiles::frame_pointers_force_off: [missing] -> pass (J0)
profiles::frame_pointers_force_on: [missing] -> pass (J0)
profiles::frame_pointers_invalid_value: [missing] -> pass (J0)
profiles::frame_pointers_unspecified: [missing] -> pass (J0)
util::local_poll_adapter::tests::deferred_error: [missing] -> pass (J0)
util::local_poll_adapter::tests::deferred_success: [missing] -> pass (J0)
util::local_poll_adapter::tests::immediate_error: [missing] -> pass (J0)
util::local_poll_adapter::tests::immediate_success: [missing] -> pass (J0)
warning_override::always_show_error_diags: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, x86_64-gnu-aux, x86_64-msvc-ext1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ad4b9354009cb6bd5a9ff1b5f5a63a13ec98ebc9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-powerpc-linux: 1h 30m -> 1h 11m (-21.7%)
pr-check-1: 32m 31s -> 26m 15s (-19.3%)
aarch64-apple: 3h 28m -> 2h 51m (-17.8%)
dist-x86_64-apple: 1h 47m -> 2h 6m (+17.5%)
x86_64-gnu-tools: 1h 2m -> 53m 46s (-14.5%)
dist-aarch64-msvc: 1h 46m -> 1h 32m (-13.2%)
pr-check-2: 44m 42s -> 39m 13s (-12.3%)
aarch64-gnu-llvm-21-2: 53m 16s -> 46m 45s (-12.2%)
x86_64-gnu-gcc: 1h 12m -> 1h 3m (-11.6%)
x86_64-gnu-aux: 2h 28m -> 2h 12m (-11.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-07T20:24:07Z

Finished benchmarking commit (ad4b935): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Max RSS (memory usage)

Results (primary 4.8%, secondary -5.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.8%	[4.8%, 4.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.2%	[-5.2%, -5.2%]	1
All ❌✅ (primary)	4.8%	[4.8%, 4.8%]	1

Cycles

Results (secondary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	8
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	4
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.1%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.4%, 0.1%]	16

Bootstrap: 487.084s -> 488.293s (0.25%)
Artifact size: 395.18 MiB -> 395.52 MiB (0.08%)

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2026