Skip to content

Make substr_range and subslice_range return the new Range type#154707

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
nik-contrib:substr-new-range
Apr 5, 2026
Merged

Make substr_range and subslice_range return the new Range type#154707
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
nik-contrib:substr-new-range

Conversation

@nik-rev
Copy link
Copy Markdown
Contributor

@nik-rev nik-rev commented Apr 2, 2026

Makes the unstable substr_slice and substr_range functions return the new core::range::Range type, instead of the old core::ops::Range.

Unblocks the stabilization of #![feature(substr_range)], see #141266 (comment)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 2, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm

@rust-log-analyzer

This comment has been minimized.

@nik-rev nik-rev force-pushed the substr-new-range branch from 05c57d6 to f8d1132 Compare April 2, 2026 09:03
@nik-rev nik-rev force-pushed the substr-new-range branch from f8d1132 to 8b06612 Compare April 2, 2026 09:10
@Mark-Simulacrum
Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 4, 2026

📌 Commit 8b06612 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2026
rust-bors bot pushed a commit that referenced this pull request Apr 4, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #147552 ([Debugger Visualizers] Optimize lookup behavior)
 - #154052 (float: Fix panic at max exponential precision)
 - #154706 (fix compilation of time/hermit.rs)
 - #154707 (Make `substr_range` and `subslice_range` return the new `Range` type)
 - #154767 (triagebot: roll library reviewers for `{coretests,alloctests}`)
 - #154797 (bootstrap: Include shorthand aliases in x completions)
@rust-bors rust-bors bot merged commit 617fdd8 into rust-lang:main Apr 5, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 5, 2026
rust-timer added a commit that referenced this pull request Apr 5, 2026
Rollup merge of #154707 - nik-contrib:substr-new-range, r=Mark-Simulacrum

Make `substr_range` and `subslice_range` return the new `Range` type

Makes the unstable `substr_slice` and `substr_range` functions return the new `core::range::Range` type, instead of the old `core::ops::Range`.

Unblocks the [stabilization](#141266) of `#![feature(substr_range)]`, see #141266 (comment)
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Apr 5, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#147552 ([Debugger Visualizers] Optimize lookup behavior)
 - rust-lang/rust#154052 (float: Fix panic at max exponential precision)
 - rust-lang/rust#154706 (fix compilation of time/hermit.rs)
 - rust-lang/rust#154707 (Make `substr_range` and `subslice_range` return the new `Range` type)
 - rust-lang/rust#154767 (triagebot: roll library reviewers for `{coretests,alloctests}`)
 - rust-lang/rust#154797 (bootstrap: Include shorthand aliases in x completions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants