Skip to content

Semantic checks of impl restrictions#154661

Open
CoCo-Japan-pan wants to merge 12 commits intorust-lang:mainfrom
CoCo-Japan-pan:impl-restriction-check
Open

Semantic checks of impl restrictions#154661
CoCo-Japan-pan wants to merge 12 commits intorust-lang:mainfrom
CoCo-Japan-pan:impl-restriction-check

Conversation

@CoCo-Japan-pan
Copy link
Copy Markdown
Contributor

@CoCo-Japan-pan CoCo-Japan-pan commented Apr 1, 2026 •
edited by rustbot
Loading

View all comments

This PR implements semantic checks for impl restrictions proposed in the Restrictions RFC (Tracking Issue #105077), and linked to a GSOC idea/proposal.

It lowers the resolved paths of impl restrictions from the AST to HIR and into TraitDef, and integrates the checks into the coherence phase by extending check_impl. As parsing (#152943) and path resolution (#153556) have already been implemented, this PR provides a working implementation of impl restrictions.

r? @Urgau
cc @jhpratt

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 1, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 1, 2026
@CoCo-Japan-pan CoCo-Japan-pan changed the title Impl restriction check impl restriction check Apr 1, 2026
@CoCo-Japan-pan CoCo-Japan-pan changed the title impl restriction check Semantic checks of impl restrictions Apr 1, 2026
Urgau
Urgau reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Urgau Urgau left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising. Left some preliminary comments.

View changes since this review

@Urgau Urgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2026
Urgau
Urgau reviewed Apr 5, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau left review comments

Assignees

@Urgau Urgau

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CoCo-Japan-pan @rustbot @Urgau