Add --quiet flag to suppress verbose run-make output for passing tests by Ayuse · Pull Request #154587 · rust-lang/rust

Ayuse · 2026-03-30T13:38:14Z

Adds --quiet flag to ./x test and compiletest
- ./x test --no-capture --quiet suppresses verbose subprocess output for passing run-make tests
- Failed tests always print their output regardless of --quiet
- Default behavior (verbose) is unchanged
This addresses the request from @bjorn3 which needs --no-capture (due to panic=abort) but doesn't want output
dumped for every passing test.

Fixes Retain ability to not verbose-dump cmd/output for successful tests even when --nopcature for cg_clif #154069

Test plan
- ./x test tests/run-make/bare-outfile --no-capture --force-rerun — verbose output for passing test
- ./x test tests/run-make/bare-outfile --no-capture --quiet --force-rerun — no verbose output for passing test
- Failing test still dumps output with --quiet

rustbot · 2026-03-30T13:38:17Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

The run-make-support library was changed

cc @jieyouxu

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-03-30T13:38:20Z

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu, wesleywiser

rustbot · 2026-03-30T13:46:52Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

When using `--no-capture` with `panic=abort` test suites, every passing test dumps its full command output, flooding the terminal. This adds a `--quiet` flag so that `./x test --no-capture --quiet` suppresses that output for passing tests while still showing output for failures.

Ayuse · 2026-03-30T14:44:54Z

r? @jieyouxu

jieyouxu

Thanks, two things

View changes since this review

jieyouxu · 2026-04-05T07:53:08Z

src/tools/run-make-support/src/util.rs

+    cmd.inspect(|std_cmd| {
+        eprintln!("{std_cmd:?}");
+    });
+    eprintln!("output status: `{}`", output.status());
+    eprintln!("=== STDOUT ===\n{}\n\n", output.stdout_utf8());
+    eprintln!("=== STDERR ===\n{}\n\n", output.stderr_utf8());
+    if !cmd.get_context().is_empty() {
+        eprintln!("Context:\n{}", cmd.get_context());
+    }


Question: wait, why is the body of verbose_print_command inlined here?

jieyouxu · 2026-04-05T07:56:06Z

src/bootstrap/src/core/config/flags.rs

+        /// suppress verbose subprocess output for successful run-make tests (useful with
+        /// --no-capture for panic=abort test suites like cg_clif)
+        quiet: bool,


Suggestion: I thought about this flag name a bit more. With #154616 in mind, I want to reserve --quiet for the more general operation of "suppressing certain bootstrap build output". I don't want to use --quiet for the more niche use cases of suppressing run-make verbose subprocess output.

Can you change this flag and config name to sth more like --verbose-run-make-subprocess-output? I would expect that:

It is normally true (preserve previous default), but

For cg_clif we want to explicitly set --verbose-run-make-subprocess-output=false (in a follow-up PR).

I'm fully aware that:

The flag name is extremely specific, but that's my intention: when and if we need to recycle this flag somewhere else, I want us to re-evaluate the two places if it makes sense to recycle it as-is.

The flag name is really long. Also intentional, because this usage is quite niche (cg_clif/cg_* backend specific). General rule of thumb for flag name length is proportional to how often/common we anticipate it to be used.

rustbot · 2026-04-05T07:58:23Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

jieyouxu · 2026-04-05T07:59:30Z

src/bootstrap/src/core/config/flags.rs

+        /// suppress verbose subprocess output for successful run-make tests (useful with
+        /// --no-capture for panic=abort test suites like cg_clif)
+        quiet: bool,


Suggestion: please also document the new ./x test flag (prob. --verbose-run-make-subprocess-output) in rustc-dev-guide (fine to do so in the subtree in this PR)

rustbot assigned wesleywiser Mar 30, 2026

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2026

This comment has been minimized.

Sign in to view

Add CONFIG_CHANGE_HISTORY entry for --quiet flag

d7cd840

Ayuse force-pushed the compiletest-quiet-run-make branch from ee8706b to d7cd840 Compare March 30, 2026 14:04

rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Mar 30, 2026

This comment has been minimized.

Sign in to view

Ayuse added 2 commits March 30, 2026 15:14

Regenerate shell completions for --quiet flag

5b69598

Fix formatting for optflag quiet

55a9182

rustbot assigned jieyouxu and unassigned wesleywiser Mar 30, 2026

jieyouxu mentioned this pull request Mar 31, 2026

Add --quiet flag to x.py and bootstrap to suppress output #154616

Open

jieyouxu requested changes Apr 5, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2026

jieyouxu reviewed Apr 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add --quiet flag to suppress verbose run-make output for passing tests#154587

Add --quiet flag to suppress verbose run-make output for passing tests#154587
Ayuse wants to merge 4 commits intorust-lang:mainfrom
Ayuse:compiletest-quiet-run-make

Ayuse commented Mar 30, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Ayuse commented Mar 30, 2026

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

Uh oh!

jieyouxu Apr 5, 2026

Uh oh!

jieyouxu Apr 5, 2026 •

edited

Loading

Uh oh!

rustbot commented Apr 5, 2026

Uh oh!

jieyouxu Apr 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Ayuse commented Mar 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Ayuse commented Mar 30, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

jieyouxu Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Apr 5, 2026

Uh oh!

jieyouxu Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Ayuse commented Mar 30, 2026 •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu Apr 5, 2026 •

edited

Loading