Fix invalid type suggestion for item nested in function#154540
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 30, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
chenyukang
changed the title
Contributor
|
I'm pretty sure there are many other suggestions where we should be using this macro. We should figure out a way of automating it for the @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2026
…uwer Rollup of 11 pull requests Successful merges: - #154074 (don't drop arguments' temporaries in `dbg!`) - #154328 (rustdoc: add missing {os,target,target_env} values for cfg pretty printer) - #154540 (Fix invalid type suggestion for item nested in function) - #154549 (Add regression test for recursive lazy type alias normalization ICE) - #153373 (Fix LegacyKeyValueFormat report from docker build: powerpc) - #154322 (feat: reimplement `hash_map!` macro) - #154416 (Add `IoSplit` diagnostic item for `std::io::Split`) - #154486 (std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16) - #154508 (Fix ambiguous parsing in bootstrap.py) - #154518 (Panic in Hermit clock_gettime) - #154530 (update zulip link in `std` documentation)
rust-timer
added a commit
that referenced
this pull request
Mar 30, 2026
Rollup merge of #154540 - chenyukang:yukang-fix-146786-unusable-path-suggestion, r=estebank Fix invalid type suggestion for item nested in function Fixes #146786 I also tried to add the `omit_parent` logic in pretty formatter here: https://github.com/chenyukang/rust/blob/69b6d26d05006dca7556abc555fb0e029ecf1f4e/compiler/rustc_middle/src/ty/print/pretty.rs#L2240-L2295 so that we don't need to add `should_omit_parent_def_path` and `reset_path`. but seems there will be duplicate print code with `default_print_def_path`. maybe r? @estebank
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Mar 30, 2026
…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#154074 (don't drop arguments' temporaries in `dbg!`) - rust-lang/rust#154328 (rustdoc: add missing {os,target,target_env} values for cfg pretty printer) - rust-lang/rust#154540 (Fix invalid type suggestion for item nested in function) - rust-lang/rust#154549 (Add regression test for recursive lazy type alias normalization ICE) - rust-lang/rust#153373 (Fix LegacyKeyValueFormat report from docker build: powerpc) - rust-lang/rust#154322 (feat: reimplement `hash_map!` macro) - rust-lang/rust#154416 (Add `IoSplit` diagnostic item for `std::io::Split`) - rust-lang/rust#154486 (std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16) - rust-lang/rust#154508 (Fix ambiguous parsing in bootstrap.py) - rust-lang/rust#154518 (Panic in Hermit clock_gettime) - rust-lang/rust#154530 (update zulip link in `std` documentation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146786
I also tried to add the
omit_parentlogic in pretty formatter here:https://github.com/chenyukang/rust/blob/69b6d26d05006dca7556abc555fb0e029ecf1f4e/compiler/rustc_middle/src/ty/print/pretty.rs#L2240-L2295
so that we don't need to add
should_omit_parent_def_pathandreset_path.but seems there will be duplicate print code with
default_print_def_path.maybe r? @estebank