Skip to content

triagebot: add reminder for bumping CI LLVM stamp #154494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Mar 29, 2026
+9 −0
Merged

triagebot: add reminder for bumping CI LLVM stamp #154494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,15 @@ cc = ["@m-ou-se"]
[mentions."compiler/rustc_ast_lowering/src/format.rs"]
cc = ["@m-ou-se"]

[mentions."src/ci/github-actions/jobs.yml"]
Copy link
Copy Markdown
Member

@Mark-Simulacrum Mark-Simulacrum Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could also just include this file (or others) in our cache key...

Copy link
Copy Markdown
Member Author

@jieyouxu jieyouxu Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work too, I'll do that in a follow up

Copy link
Copy Markdown
Member

@RalfJung RalfJung Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, most changes to that file don't affect LLVM...

Copy link
Copy Markdown
Member Author

@jieyouxu jieyouxu Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... Yeah. It's a tradeoff between changes to that unnecessarily invalidating llvm versus potential risks of forgetting CI LLVM stamp bumps. I'm kinda leaning towards "just this reminder for now".

message = """
> [!WARNING]
>
> If you are changing how CI LLVM is built or linked, make sure to bump
> `src/bootstrap/download-ci-llvm-stamp`.
"""
cc = ["@jieyouxu"]

# Content-based mentions

[mentions."#[miri::intrinsic_fallback_is_spec]"]
Expand Down
Loading