Skip to content

triagebot: Mention 'subtree' in clippy message#154465

Open
clubby789 wants to merge 1 commit intorust-lang:mainfrom
clubby789:clippy-msg
Open

triagebot: Mention 'subtree' in clippy message#154465
clubby789 wants to merge 1 commit intorust-lang:mainfrom
clubby789:clippy-msg

Conversation

@clubby789
Copy link
Copy Markdown
Contributor

#154396 (comment)

This makes it more obvious a subtree is being changed, similarly to Miri and rustc-dev-guide

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 27, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 27, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@xtqqczze
Copy link
Copy Markdown
Contributor

Could we mention 'subtree' for all subtrees please.

Git subtrees that have ever existed:

compiler/rustc_codegen_cranelift
compiler/rustc_codegen_gcc
compiler/rustc_smir
library/portable-simd
src/tools/clippy
src/tools/miri
src/tools/rust-analyzer
src/tools/rustfmt

Josh subtrees:

library/compiler-builtins
library/stdarch
src/tools/rust-analyzer
src/tools/miri
src/doc/rustc-dev-guide

Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This itself is nice, the suggestion for other subtrees seems reasonable too, but up to you, not going to block on that.

r=me with or without other subtrees

@rustbot author

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 28, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants