Skip to content

Rustdoc rejects html emits with json output #154421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Mar 28, 2026
Merged

Rustdoc rejects html emits with json output #154421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/librustdoc/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,18 @@ impl Options {
}
}

if output_format == OutputFormat::Json {
if let Some(emit_flag) = emit.iter().find_map(|emit| match emit {
EmitType::HtmlStaticFiles => Some("html-static-files"),
EmitType::HtmlNonStaticFiles => Some("html-non-static-files"),
EmitType::DepInfo(_) => None,
}) {
dcx.fatal(format!(
"the `--emit={emit_flag}` flag is not supported with `--output-format=json`",
));
}
}

let to_check = matches.opt_strs("check-theme");
if !to_check.is_empty() {
let mut content =
Expand Down
2 changes: 2 additions & 0 deletions tests/rustdoc-ui/output-format-json-emit-html.html_non_static.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
error: the `--emit=html-non-static-files` flag is not supported with `--output-format=json`

2 changes: 2 additions & 0 deletions tests/rustdoc-ui/output-format-json-emit-html.html_static.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
error: the `--emit=html-static-files` flag is not supported with `--output-format=json`

8 changes: 8 additions & 0 deletions tests/rustdoc-ui/output-format-json-emit-html.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
//@ revisions: html_static html_non_static
//@ check-fail
//@[html_static] compile-flags: -Z unstable-options --output-format=json --emit=html-static-files
//@[html_non_static] compile-flags: -Z unstable-options --output-format=json --emit=html-non-static-files
//[html_static]~? ERROR the `--emit=html-static-files` flag is not supported with `--output-format=json`
//[html_non_static]~? ERROR the `--emit=html-non-static-files` flag is not supported with `--output-format=json`

pub struct Foo;
5 changes: 5 additions & 0 deletions tests/rustdoc-ui/show-coverage-json-emit-html-non-static.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
//@ compile-flags: -Z unstable-options --show-coverage --output-format=json --emit=html-non-static-files
//@ check-fail
//~? ERROR the `--emit=html-non-static-files` flag is not supported with `--output-format=json`

pub struct Foo;
2 changes: 2 additions & 0 deletions tests/rustdoc-ui/show-coverage-json-emit-html-non-static.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
error: the `--emit=html-non-static-files` flag is not supported with `--output-format=json`

Loading