Tweak irrefutable let else warning output#154325
Open
WeiTheShinobi wants to merge 1 commit intorust-lang:mainfrom
Open
Tweak irrefutable let else warning output#154325WeiTheShinobi wants to merge 1 commit intorust-lang:mainfrom
WeiTheShinobi wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in match checking cc @Nadrieril |
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
f9c1661 to
94d6023
Compare
This comment has been minimized.
This comment has been minimized.
94d6023 to
254a0c7
Compare
This comment has been minimized.
This comment has been minimized.
254a0c7 to
adc87de
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153454
Greeting!
This PR tweak diagnostic output for
irrefutable-let-elsepatterns and adds a check forlet a = Some(b) else {...}Thanks for the review!