Skip to content

doc: linker-plugin-based LTO: update list of good combinations#154284

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
zamazan4ik:patch-1
Mar 24, 2026
Merged

doc: linker-plugin-based LTO: update list of good combinations#154284
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
zamazan4ik:patch-1

Conversation

@zamazan4ik
Copy link
Copy Markdown
Contributor

This PR is similar to #146827 . I just ran the Python script as was recommended in this comment. Also updated the LOWER_BOUND in the script to skip a bit redundant work in the Python script.

@nnethercote pinging you as a reviewer here since the last time you did it too ;)

Copilot AI review requested due to automatic review settings March 24, 2026 01:10
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, compiler
  • @ehuss, compiler expanded to 70 candidates
  • Random selection from 12 candidates

This comment was marked as spam.

@zamazan4ik
Copy link
Copy Markdown
Contributor Author

Related issue - #154285 (but this PR does not fix the issue)

@nnethercote
Copy link
Copy Markdown
Contributor

FYI: we don't use Co-pilot reviews in this project.

@zamazan4ik
Copy link
Copy Markdown
Contributor Author

FYI: we don't use Co-pilot reviews in this project.

Sorry for that, it was my corporate settings for automatic code review. Fixed it. Thanks!

Copy link
Copy Markdown
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, thanks! @bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 24, 2026

📌 Commit 3f67327 has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 24, 2026
doc: linker-plugin-based LTO: update list of good combinations

This PR is similar to rust-lang#146827 . I just ran the Python script as was [recommended](rust-lang#146827 (review)) in this comment. Also updated the LOWER_BOUND in the script to skip a bit redundant work in the Python script.

@nnethercote pinging you as a reviewer here since the last time you did it too ;)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 24, 2026
doc: linker-plugin-based LTO: update list of good combinations

This PR is similar to rust-lang#146827 . I just ran the Python script as was [recommended](rust-lang#146827 (review)) in this comment. Also updated the LOWER_BOUND in the script to skip a bit redundant work in the Python script.

@nnethercote pinging you as a reviewer here since the last time you did it too ;)
rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #149218 (Make PinCoerceUnsized require Deref)
 - #154094 (add neon load/store assembly test)
 - #154142 (Delegation: eliminate usage of AST from generics creation)
 - #154276 (allow `incomplete_features` in more tests)
 - #154284 (doc: linker-plugin-based LTO: update list of good combinations)
 - #154286 (Cherry-pick 1.94.1 release notes)
 - #154303 (Remove more `BuiltinLintDiag` variants - part 2)
rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154094 (add neon load/store assembly test)
 - #154142 (Delegation: eliminate usage of AST from generics creation)
 - #154276 (allow `incomplete_features` in more tests)
 - #154284 (doc: linker-plugin-based LTO: update list of good combinations)
 - #154286 (Cherry-pick 1.94.1 release notes)
 - #154303 (Remove more `BuiltinLintDiag` variants - part 2)
@rust-bors rust-bors bot merged commit eb7fa12 into rust-lang:main Mar 24, 2026
14 of 15 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants