Use common Timestamp impl in Hermit (attempt 2)#154234
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 28, 2026
Merged
Use common Timestamp impl in Hermit (attempt 2)#154234rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
O-hermit
stepancheg
force-pushed
the
hermit-timespec
branch
2 times, most recently
from
878bcf6 to
a5006e0
Compare
Collaborator
|
|
rustbot
added
S-waiting-on-review
Contributor
Author
|
r? Mark-Simulacrum |
This comment has been minimized.
This comment has been minimized.
stepancheg
force-pushed
the
hermit-timespec
branch
from
a5006e0 to
178882d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Mark-Simulacrum
requested changes
Mar 27, 2026
|
|
||
| fn clock_gettime(clock: hermit_abi::clockid_t) -> Timespec { | ||
| let mut t = hermit_abi::timespec { tv_sec: 0, tv_nsec: 0 }; | ||
| let _ = unsafe { hermit_abi::clock_gettime(clock, &raw mut t) }; |
Member
There was a problem hiding this comment.
Why are we ignoring the error here? In unix/time.rs we panic if there's an error, probably should match that here?
cvt(unsafe { clock_gettime64(clock, t.as_mut_ptr()) }).unwrap();
Contributor
Author
There was a problem hiding this comment.
It was ignored before, so I did not include it in this PR which moves files and does not change semantics.
rust/library/std/src/sys/time/hermit.rs
Line 13 in fda6d37
Should I include unwrap in this PR?
Member
There was a problem hiding this comment.
Let's merge this and if you can file a followup (maybe check for other similar discrepancies too) that would be good. Thanks!
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2026
Rollup of 9 pull requests Successful merges: - #154357 (uefi: extend comment for TcpStream Send impl) - #154410 (Clean up the API for opening/checking incremental-compilation files ) - #154081 (format safety doc of Rc/Arc::from_raw/from_raw_in) - #154110 (Change "error finalizing incremental compilation" text and emit it as a note, not a warning) - #154196 (Make `Ipv6Addr::multicast_scope()` exhaustive) - #154221 (`vec::as_mut_slice()`: use lowercase "isize" in safety comment) - #154234 (Use common Timestamp impl in Hermit (attempt 2)) - #154396 (chore(deps): update rust crate tar to v0.4.45) - #154488 (Revert "Unstable book options parser")
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2026
Rollup of 9 pull requests Successful merges: - #154357 (uefi: extend comment for TcpStream Send impl) - #154410 (Clean up the API for opening/checking incremental-compilation files ) - #154081 (format safety doc of Rc/Arc::from_raw/from_raw_in) - #154110 (Change "error finalizing incremental compilation" text and emit it as a note, not a warning) - #154196 (Make `Ipv6Addr::multicast_scope()` exhaustive) - #154221 (`vec::as_mut_slice()`: use lowercase "isize" in safety comment) - #154234 (Use common Timestamp impl in Hermit (attempt 2)) - #154396 (chore(deps): update rust crate tar to v0.4.45) - #154488 (Revert "Unstable book options parser")
rust-timer
added a commit
that referenced
this pull request
Mar 28, 2026
Rollup merge of #154234 - stepancheg:hermit-timespec, r=Mark-Simulacrum Use common Timestamp impl in Hermit (attempt 2) The goal is to have less code to maintain, so to be able to make changes easier. Previous attempt #148847 was asked to postpone because there was restructure of code, which is complete now. r? joboet
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 29, 2026
…mulacrum Panic in Hermit clock_gettime Follow-up to rust-lang#154234. r? @Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to have less code to maintain, so to be able to make changes easier.
Previous attempt #148847 was asked to postpone because there was restructure of code, which is complete now.
r? joboet