refactor rustc_hir_typeck/src/op.rs

[malezjaa]

Fixes #64297

This is a refactoring PR with no logic or behaviour changes. I tried to improve readability of op.rs, which had a few very large functions using some suboptimal syntax. I broke these up into smaller helpers.

[rustbot]

r? @adwinwhite

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 69 candidates
• Random selection from 13 candidates

[Kivooeo]

This is a fairly large PR -- could you help reviewers by adding some context to the description? It would be great to have a summary of what was changed, the key decisions made and the reasoning behind them, and ideally a breakdown into separate commits to make it easier to review piece by piece.

[malezjaa]

Updated the description. There weren't really any key decisions to make since this is a refactor with no behaviour changes. As for separate commits, splitting style changes after the fact would be tedious and I'm not sure it would add much value for reviewers.

[adwinwhite]

@malezjaa I'm really sorry that I didn't get to this quickly. Thank you for trying to clean this up.
This change is still very desirable. I will do the review in a timely manner if you're still willing to working on it. That said, if you don't want to continue with this PR, that's completely okay.

[malezjaa]

I am also sorry for closing this so quickly. I’ll try to resolve these merge conflicts as soon as I can.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[adwinwhite]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.