Remove divergence check from check_expr_array#154031
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Mar 27, 2026
Merged
Remove divergence check from check_expr_array#154031rust-bors[bot] merged 2 commits intorust-lang:mainfrom
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
cc @chenyukang (as you added this check originally in #147548) |
Member
|
r? @chenyukang |
Member
|
@bors r=chenyukang |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 26, 2026
…rray-ice, r=chenyukang Remove divergence check from check_expr_array Fixes rust-lang#153695. `check_expr_array` currently assumes it should only be entered with` self.diverges == Diverges::Maybe`, but that assumption does not appear to hold in all valid cases. A never-pattern parameter can seed a function or closure body with inherited `Diverges::Always`, and exprs in that body are still typecked.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 26, 2026
…rray-ice, r=chenyukang Remove divergence check from check_expr_array Fixes rust-lang#153695. `check_expr_array` currently assumes it should only be entered with` self.diverges == Diverges::Maybe`, but that assumption does not appear to hold in all valid cases. A never-pattern parameter can seed a function or closure body with inherited `Diverges::Always`, and exprs in that body are still typecked.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Rollup of 7 pull requests Successful merges: - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #154031 (Remove divergence check from check_expr_array) - #154418 (move many tests out of `ui/unsafe`) - #153662 (Suggest fully qualified path on method name collision) - #153675 (simd_add/sub/mul/neg: document overflow behavior) - #154110 (Change "error finalizing incremental compilation" text and emit it as a note, not a warning) - #154430 (Create GPU target notification group)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Mar 27, 2026
…rray-ice, r=chenyukang Remove divergence check from check_expr_array Fixes rust-lang#153695. `check_expr_array` currently assumes it should only be entered with` self.diverges == Diverges::Maybe`, but that assumption does not appear to hold in all valid cases. A never-pattern parameter can seed a function or closure body with inherited `Diverges::Always`, and exprs in that body are still typecked.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Rollup of 7 pull requests Successful merges: - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #154031 (Remove divergence check from check_expr_array) - #154418 (move many tests out of `ui/unsafe`) - #154441 (bootstrap: force a CI LLVM stamp bump) - #153662 (Suggest fully qualified path on method name collision) - #153675 (simd_add/sub/mul/neg: document overflow behavior) - #154430 (Create GPU target notification group)
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Rollup of 6 pull requests Successful merges: - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #154031 (Remove divergence check from check_expr_array) - #154418 (move many tests out of `ui/unsafe`) - #154441 (bootstrap: force a CI LLVM stamp bump) - #153675 (simd_add/sub/mul/neg: document overflow behavior) - #154430 (Create GPU target notification group)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153695.
check_expr_arraycurrently assumes it should only be entered withself.diverges == Diverges::Maybe, but that assumption does not appear to hold in all valid cases. A never-pattern parameter can seed a function or closure body with inheritedDiverges::Always, and exprs in that body are still typecked.