Add bootstrap step for stdarch-verify

[xonx4l]

View all comments

This PR hooks library/stdarch/crates/stdarch-verify crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test.

Changes :
-> Added StdarchVerify in src/bootstrap/src/core/build_steps/test.rs
-> Added test::StdarchVerify in src/bootstrap/src/core/builder/mod.rs

Tests:
-> Running ./x.py test library/stdarch/crates/stdarch-verify builds compiler and std successfully.
-> All three integration tests Passes:
tests/arm.rs
tests/mips.rs
tests/x86-intel.rs
-> Doc tests for stdarch_verify also Passes.

r? @Kobzol

[rustbot]

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

[Kobzol]

The test step looks good, thank you!

I'm not sure if it's the best approach to create separate bootstrap steps for each of the stdarch test jobs though 🤔 rust-lang/stdarch#1655 (comment) mentioned the possibility of running all of the stdarch tests in a single rust-lang/rust CI job, though I'm not sure if that is practical or possible. So it would be good to come up with some larger plan for how this all will be handled.

That being said, this is a nice little incremental improvement, so let's test if it works fine on all our CI jobs. Left one nit.

View changes since this review

[xonx4l]

The test step looks good, thank you!

I'm not sure if it's the best approach to create separate bootstrap steps for each of the stdarch test jobs though 🤔 rust-lang/stdarch#1655 (comment) mentioned the possibility of running all of the stdarch tests in a single rust-lang/rust CI job, though I'm not sure if that is practical or possible. So it would be good to come up with some larger plan for how this all will be handled.

That being said, this is a nice little incremental improvement, so let's test if it works fine on all our CI jobs. Left one nit.

View changes since this review

I have idea focussed towards this route only (run the whole stdarch testsuite under a single rust-lang/rust runner and eventually fully migrate stdarch into rust-lang/rust) as mentioned by amanieu’s . For this PR I Kept the scope small so we can get one piece (stdarch-verify) hooked into bootstrap and then can see how it behaves on CI. And in Follow-ups I have idea to go through the practical and possible route . which is to me is shaping and designing intrinsic-test and core_arch in a way that they are hooked with better data on runtime and flakiness. Then we can reshape (Maybe refactor) the bootstrap steps into single bootstrap step under one job . what you think? I hope that makes sense.

Thank you!

[Kobzol]

@bors squash

[rust-bors]

🔨 4 commits were squashed into a085b68.

[Kobzol]

@bors r+ rollup=iffy

[rust-bors]

📌 Commit a085b68 has been approved by Kobzol

It is now in the queue for this repository.

[JonathanBrouwer]

@bors try jobs=x86_64-gnu-distcheck

[rust-bors]

💔 Test for 0225b04 failed: CI. Failed job:

• try - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

[xonx4l]

@rustbot ready

[JonathanBrouwer]

@bors try jobs=x86_64-gnu-distcheck

[rust-bors]

💔 Test for a54dfec failed: CI. Failed job:

• try - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

[JonathanBrouwer]

@bors try jobs=x86_64-gnu-distcheck

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rust-bors]

💔 Test for 16f7a1b failed: CI. Failed job:

• try - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[rust-log-analyzer]

The job pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

                 "children": [
                   {
                     "children": [
                       {
                         "directories": [],
                         "files": [
                           "analyzer-decls.h",
                           "malloc-macro.h",
                           "sarif-path-role.h"
                         ],
                         "license": {
                           "copyright": [
                             "2000-2024 Free Software Foundation, Inc"
                           ],
                           "spdx": "GPL-2.0-only"
                         },
                         "type": "group"
                       }
                     ],
                     "license": {
                       "copyright": [
                         "2007-2011 Atheros Communications Inc",
-                        "2011-2012, 2017 Qualcomm Atheros, Inc",
+                        "2011-2012,2017 Qualcomm Atheros, Inc",
                         "2016-2017 Erik Stromdahl <erik.stromdahl@gmail.com>"
                       ],
                       "spdx": "ISC"
                     },
                     "name": "c-c++-common/analyzer",
                     "type": "directory"
                   }
                 ],
                 "license": {
                   "copyright": [
                     "2000-2024 Free Software Foundation, Inc"
                   ],
                   "spdx": "GPL-2.0-only"
                 },
                 "name": "gcc/testsuite",
                 "type": "directory"
               },
               {
                 "license": {
                   "copyright": [
                     "2000-2024 Free Software Foundation, Inc"
                   ],
                   "spdx": "GCC-exception-3.1"
                 },
                 "name": "libstdc++-v3/config/os/aix/os_defines.h",
                 "type": "file"
               }
             ],
             "license": {
               "copyright": [
                 "1997-2024 Free Software Foundation, Inc"
               ],
               "spdx": "GPL-3.0-or-later"
             },
             "name": "src/gcc",
             "type": "directory"
           },
           {
             "children": [
               {
                 "license": {
                   "copyright": [
                     "The Rust Project Developers (see https://thanks.rust-lang.org)"
                   ],
                   "spdx": "Apache-2.0 OR MIT"
                 },
                 "name": "noscript.css",
                 "type": "file"
               },
               {
                 "license": {
                   "copyright": [
                     "Nicolas Gallagher and Jonathan Neal"
                   ],
                   "spdx": "MIT"
                 },
                 "name": "normalize.css",
                 "type": "file"
               }
             ],
             "license": {
               "copyright": [
                 "2016 Ike Ku, Jessica Stokes and Leon Guan",
                 "The Rust Project Developers (see https://thanks.rust-lang.org)"
               ],
               "spdx": "Apache-2.0 OR MIT"
             },
             "name": "src/librustdoc/html/static/css",
             "type": "directory"
           },
           {
             "children": [
               {
                 "license": {
                   "copyright": [
                     "The Rust Project Developers (see https://thanks.rust-lang.org)"
                   ],
                   "spdx": "Apache-2.0 OR MIT"
                 },
                 "name": "README.txt",
                 "type": "file"
               },
               {
                 "directories": [],
                 "files": [
                   "FiraMono-Medium.woff2",
                   "FiraMono-Regular.woff2",
                   "FiraSans-Italic.woff2",
                   "FiraSans-LICENSE.txt",
                   "FiraSans-Medium.woff2",
                   "FiraSans-MediumItalic.woff2",
                   "FiraSans-Regular.woff2"
                 ],
                 "license": {
                   "copyright": [
-                    "2014 Mozilla Foundation",
-                    "2014 Telefonica S.A"
+                    "2014, Mozilla Foundation",
+                    "2014, Telefonica S.A"
                   ],
                   "spdx": "OFL-1.1"
                 },
                 "type": "group"
               },
               {
                 "directories": [],
                 "files": [
                   "NanumBarunGothic-LICENSE.txt",
                   "NanumBarunGothic.ttf.woff2"
                 ],
                 "license": {
                   "copyright": [
                     "2010 NAVER Corporation"
                   ],
                   "spdx": "OFL-1.1"
                 },
                 "type": "group"
               }
             ],
             "license": {
               "copyright": [
-                "2010, 2012, 2014-2023 Adobe Systems Incorporated"
+                "2010, 2012, 2014-2023, Adobe Systems Incorporated"
               ],
               "spdx": "OFL-1.1"
             },
             "name": "src/librustdoc/html/static/fonts",
             "type": "directory"
           },
           {
             "license": {
               "copyright": [
                 "2003-2019 University of Illinois at Urbana-Champaign",
                 "The Rust Project Developers (see https://thanks.rust-lang.org)"
               ],
               "spdx": "Apache-2.0 WITH LLVM-exception AND (Apache-2.0 OR MIT)"
             },
             "name": "compiler/rustc_llvm/llvm-wrapper/SymbolWrapper.cpp",
             "type": "file"
           },
           {
             "children": [],
             "license": {
               "copyright": [
                 "2014 Alex Crichton",
                 "The Rust Project Developers (see https://thanks.rust-lang.org)"
               ],
               "spdx": "Apache-2.0 OR MIT"
             },
             "name": "library/backtrace",
             "type": "directory"
           },
           {
---
               "copyright": [
                 "2019 The Crossbeam Project Developers",
                 "The Rust Project Developers (see https://thanks.rust-lang.org)"
               ],
               "spdx": "Apache-2.0 OR MIT"
             },
             "name": "library/std/src/sync/mpmc",
             "type": "directory"
           },
           {
             "license": {
               "copyright": [
                 "2016 The Fuchsia Authors",
                 "The Rust Project Developers (see https://thanks.rust-lang.org)"
               ],
               "spdx": "BSD-2-Clause AND (Apache-2.0 OR MIT)"
             },
             "name": "library/std/src/sys/sync/mutex/fuchsia.rs",
             "type": "file"
           },
           {
             "children": [],
             "license": {
               "copyright": [
                 "Rust on Embedded Devices Working Group",
                 "The Rust Project Developers (see https://thanks.rust-lang.org)"
               ],
               "spdx": "Apache-2.0 OR CC-BY-SA-4.0 OR MIT"
             },
             "name": "src/doc/embedded-book",
             "type": "directory"
           },
           {
             "children": [],
             "license": {
               "copyright": [
                 "2014 Jorge Aparicio",
                 "The Rust Project Developers (see https://thanks.rust-lang.org)"
               ],
               "spdx": "Apache-2.0 OR MIT"
             },
             "name": "src/doc/rust-by-example",
             "type": "directory"
           },
           {
             "license": {
               "copyright": [
                 "2014-2021 Knut Sveidqvist"
               ],
               "spdx": "MIT"
             },
             "name": "src/doc/rustc-dev-guide/mermaid.min.js",
             "type": "file"
           },
           {
             "children": [],
             "license": {
               "copyright": [
                 "2003-2019 University of Illinois at Urbana-Champaign",
                 "2003-2019 by the contributors listed in CREDITS.TXT (https://github.com/rust-lang/llvm-project/blob/7738295178045041669876bf32b0543ec8319a5c/llvm/CREDITS.TXT)",
                 "2010 Apple Inc"
               ],
               "spdx": "Apache-2.0 WITH LLVM-exception AND NCSA"
             },
             "name": "src/llvm-project",
             "type": "directory"
           },
           {
             "children": [],
             "license": {
               "copyright": [
                 "The syscalls Project Developers"
               ],
               "spdx": "BSD-2-Clause"
             },
             "name": "vendor",
             "type": "directory"
           }
         ],
         "license": {
           "copyright": [
             "The Rust Project Developers (see https://thanks.rust-lang.org)"
           ],
           "spdx": "Apache-2.0 OR MIT"
         },
         "name": ".",
         "type": "directory"
       }
     ],
---
   0: <anyhow::Error>::msg::<alloc::string::String>
   1: collect_license_metadata::main
   2: std::sys::backtrace::__rust_begin_short_backtrace::<fn() -> core::result::Result<(), anyhow::Error>, core::result::Result<(), anyhow::Error>>
   3: std::rt::lang_start::<core::result::Result<(), anyhow::Error>>::{closure#0}
   4: <&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync as core::ops::function::FnOnce<()>>::call_once
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/core/src/ops/function.rs:287:21
   5: std::panicking::catch_unwind::do_call::<&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync, i32>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:581:40
   6: std::panicking::catch_unwind::<i32, &dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:544:19
   7: std::panic::catch_unwind::<&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync, i32>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panic.rs:359:14
   8: std::rt::lang_start_internal::{closure#0}
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/rt.rs:175:24
   9: std::panicking::catch_unwind::do_call::<std::rt::lang_start_internal::{closure#0}, isize>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:581:40
---

--- BACKTRACE vvv
   0: <bootstrap::utils::exec::DeferredCommand>::finish_process
             at /checkout/src/bootstrap/src/utils/exec.rs:939:17
   1: <bootstrap::utils::exec::DeferredCommand>::wait_for_output::<&bootstrap::utils::exec::ExecutionContext>
             at /checkout/src/bootstrap/src/utils/exec.rs:831:21
   2: <bootstrap::utils::exec::ExecutionContext>::run
             at /checkout/src/bootstrap/src/utils/exec.rs:741:45
   3: <bootstrap::utils::exec::BootstrapCommand>::run::<&bootstrap::core::builder::Builder>
             at /checkout/src/bootstrap/src/utils/exec.rs:339:27
   4: <bootstrap::core::build_steps::test::CollectLicenseMetadata as bootstrap::core::builder::Step>::run
             at /checkout/src/bootstrap/src/core/build_steps/test.rs:4246:13
   5: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::test::CollectLicenseMetadata>
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1580:36
   6: <bootstrap::core::build_steps::test::CollectLicenseMetadata as bootstrap::core::builder::Step>::make_run
             at /checkout/src/bootstrap/src/core/build_steps/test.rs:4232:21
   7: <bootstrap::core::builder::StepDescription>::maybe_run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:476:13
   8: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
             at /checkout/src/bootstrap/src/core/builder/cli_paths.rs:232:18
   9: <bootstrap::core::builder::Builder>::run_step_descriptions
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1123:9
  10: <bootstrap::core::builder::Builder>::execute_cli
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1102:14
  11: <bootstrap::Build>::build
             at /checkout/src/bootstrap/src/lib.rs:799:25
  12: bootstrap::main
             at /checkout/src/bootstrap/src/bin/main.rs:130:11
  13: <fn() as core::ops::function::FnOnce<()>>::call_once
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/core/src/ops/function.rs:250:5
  14: std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/sys/backtrace.rs:166:18
  15: std::rt::lang_start::<()>::{closure#0}
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/rt.rs:206:18
  16: <&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync as core::ops::function::FnOnce<()>>::call_once
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/core/src/ops/function.rs:287:21
  17: std::panicking::catch_unwind::do_call::<&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync, i32>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:581:40
  18: std::panicking::catch_unwind::<i32, &dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:544:19
  19: std::panic::catch_unwind::<&dyn core::ops::function::Fn<(), Output = i32> + core::panic::unwind_safe::RefUnwindSafe + core::marker::Sync, i32>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panic.rs:359:14
  20: std::rt::lang_start_internal::{closure#0}
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/rt.rs:175:24
  21: std::panicking::catch_unwind::do_call::<std::rt::lang_start_internal::{closure#0}, isize>
             at /rustc/ad726b5063362ec9897ef3d67452fc5606ee70fa/library/std/src/panicking.rs:581:40
---
  28: __libc_start_main
  29: _start


Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:15
  local time: Sat Apr  4 15:30:44 UTC 2026
  network time: Sat, 04 Apr 2026 15:30:45 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"