Conversation
|
|
6dbf494 to
758baed
Compare
|
changes to the core type system cc @lcnr |
This comment has been minimized.
This comment has been minimized.
| if self.tcx().is_lang_item(def_id, LangItem::Sized) { | ||
| return Default::default(); | ||
| } | ||
| if self.tcx().is_lang_item(def_id, LangItem::ConstParamTy) |
There was a problem hiding this comment.
I wouldn't expect this to actually do anything 🤔 do you have an example that needs this code? otherwise we should drop this
There was a problem hiding this comment.
Without it Vec<[u8]> works :< (const_param_ty_unchecked-unsupported.rs pass); I am not completely sure here but without scoping for ConstParamTys it seem to skip all obligations of inner type, not only ConstParamTy related. So ill formed type also pass (even with register_wf_obligations in wfcheck).
There was a problem hiding this comment.
can you double check this, and if it is definitely a problem can you try look into why wf::obligations isn't returning anything when proving the wf goal in wfcheck 🤔 I don't understand what's going on here and won't have time to actively look into it myself. Feel free to reach out on zulip while looking into this
tests/ui/const-generics/adt_const_params/const_param_ty_unchecked.rs
Outdated
Show resolved
Hide resolved
758baed to
38f2b3e
Compare
This comment has been minimized.
This comment has been minimized.
38f2b3e to
335585b
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
its fine locally... :_< |
Add
const_param_ty_uncheckedinternal feature gate to skipConstParamTy_trait enforcement on type. Provides an escape hatch for writing tests and examples that use const generics without needing to ensure all fields implementConstParamTy_.r? BoxyUwU