Move `freeze_*` methods to `OpenOptionsExt2` by ChrisDenton · Pull Request #153491 · rust-lang/rust

ChrisDenton · 2026-03-06T11:45:17Z

Move the unstable freeze_last_access_time and freeze_last_write_time from OpenOptionsExt to a new OpenOptionsExt2 trait. This should fix #153486.

rustbot · 2026-03-06T11:45:23Z

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, joboet

joboet · 2026-03-06T12:49:30Z

r? libs-api
But I wonder whether it would make sense to retroactively make all these extension traits sealed. I can't imagine that there are too many people that implement this...

Darksonn · 2026-03-09T06:45:27Z

Is the intent to make a stable point release for this?

jieyouxu · 2026-03-10T01:54:57Z

Given that as mentioned

As far as I can tell, crates affected by this have no way to fix this build error without a breaking change because it's impossible to provide an implementation of the unstable method freeze_last_access_time.

Nominating for 1.95 beta / 1.94.1 stable backports for T-libs/T-libs-api judgement call.
@rustbot label: +beta-nominated +stable-nominated

joshtriplett · 2026-03-10T01:56:38Z

Seems reasonable. Could you please add a (non-doc) comment to OpenOptionsExt saying to add new methods to OpenOptionsExt2 instead?

ChrisDenton · 2026-03-10T09:53:59Z

But I wonder whether it would make sense to retroactively make all these extension traits sealed. I can't imagine that there are too many people that implement this...

As far as I can make out so far, only tokio implements this one specifically (and only in their benchmarking). Still it is a breaking change. And ultimately my preference would be to deprecate extension traits entirely in favour of having inherent methods with portability lints to ensure their usage is properly gated. But that might be far off.

Seems reasonable. Could you please add a (non-doc) comment to OpenOptionsExt saying to add new methods to OpenOptionsExt2 instead?

@joshtriplett done.

Mark-Simulacrum · 2026-03-22T12:06:09Z

I'm going to assume the beta/stable accepts are also libs-api approval for this change. I suppose it's technically non-breaking since the moved methods are unstable anyway (so just fixing).

@bors r+ rollup

rust-bors · 2026-03-22T12:06:11Z

📌 Commit fb65707 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…k-Simulacrum Move `freeze_*` methods to `OpenOptionsExt2` Move the unstable `freeze_last_access_time` and `freeze_last_write_time` from `OpenOptionsExt` to a new `OpenOptionsExt2` trait. This should fix rust-lang#153486.

[stable] 1.94.1 release This backports: * [STABLE] library: wasm32-wasip1-threads has functional pthreads #153634 * Move freeze_* methods to OpenOptionsExt2 #153491 * [Clippy] Fix ICE in match_same_arms rust-lang/rust-clippy#16685 Cargo: * [stable 1.94] Fix symlink_and_directory when running in a long target dir name (rust-lang/cargo#16777) * Fix symlink_and_directory when running in a long target dir name (rust-lang/cargo#16775) * [stable 1.94] Update tar to 0.4.45 (rust-lang/cargo#16769) * test: Remove unused docker ip_address (rust-lang/cargo#16636) * Increase cache_lock test timeout (rust-lang/cargo#16545) * chore: Updated compiler errors for Rust 1.93 (rust-lang/cargo#16543) * test(build-std): Update error message (rust-lang/cargo#16658) * fix: `--remap-path-scope` stabilized in 1.95-nightly (rust-lang/cargo#16536) * fix(script): surpress `unused_features` lint for embedded (rust-lang/cargo#16714) * test(git): Mark a test as non-deterministic (rust-lang/cargo#16706) * test(replace): Mark a test as non-deterministic (rust-lang/cargo#16700)

…k-Simulacrum Move `freeze_*` methods to `OpenOptionsExt2` Move the unstable `freeze_last_access_time` and `freeze_last_write_time` from `OpenOptionsExt` to a new `OpenOptionsExt2` trait. This should fix rust-lang#153486.

…uwer Rollup of 22 pull requests Successful merges: - #122668 (Add APIs for dealing with titlecase) - #152543 (privacy: Fix type privacy holes in RPITITs) - #153107 (Optimize BTreeMap::append() using CursorMut) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - #153931 (remove usages of to-be-deprecated numeric constants) - #150630 (Unknown -> Unsupported compression algorithm) - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - #153582 (Simplify find_attr! for HirId usage) - #153623 (std: move `sys::pal::os` to `sys::paths`) - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - #153936 (Skip stack_start_aligned for immediate-abort) - #154011 (implement `BinaryHeap::as_mut_slice`) - #154167 (ui/lto: move and rename two tests from issues/) - #154174 (allow `incomplete_features` in most UI tests) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move]) - #154201 (Use enums to clarify `DepNodeColorMap` color marking )

…uwer Rollup of 21 pull requests Successful merges: - #152543 (privacy: Fix type privacy holes in RPITITs) - #153107 (Optimize BTreeMap::append() using CursorMut) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - #153931 (remove usages of to-be-deprecated numeric constants) - #150630 (Unknown -> Unsupported compression algorithm) - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - #153582 (Simplify find_attr! for HirId usage) - #153623 (std: move `sys::pal::os` to `sys::paths`) - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - #153936 (Skip stack_start_aligned for immediate-abort) - #154011 (implement `BinaryHeap::as_mut_slice`) - #154167 (ui/lto: move and rename two tests from issues/) - #154174 (allow `incomplete_features` in most UI tests) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move]) - #154201 (Use enums to clarify `DepNodeColorMap` color marking )

CodesInChaos · 2026-03-23T12:13:53Z

I'd rather give the methods a default implementation than force users to use OpenOptionsExt2.

ChrisDenton · 2026-03-23T16:22:04Z

I'd rather give the methods a default implementation than force users to use OpenOptionsExt2.

You should bring that up on the tracking issue. That's not something I'd want to backport to stable.

…k-Simulacrum Move `freeze_*` methods to `OpenOptionsExt2` Move the unstable `freeze_last_access_time` and `freeze_last_write_time` from `OpenOptionsExt` to a new `OpenOptionsExt2` trait. This should fix rust-lang#153486.

[beta] backports - Update cargo - #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`

…uwer Rollup of 21 pull requests Successful merges: - rust-lang/rust#152543 (privacy: Fix type privacy holes in RPITITs) - rust-lang/rust#153107 (Optimize BTreeMap::append() using CursorMut) - rust-lang/rust#153312 (Packages as namespaces part 1) - rust-lang/rust#153534 (Remove a flaky `got_timeout` assert from two channel tests) - rust-lang/rust#153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - rust-lang/rust#153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - rust-lang/rust#153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - rust-lang/rust#153931 (remove usages of to-be-deprecated numeric constants) - rust-lang/rust#150630 (Unknown -> Unsupported compression algorithm) - rust-lang/rust#153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - rust-lang/rust#153582 (Simplify find_attr! for HirId usage) - rust-lang/rust#153623 (std: move `sys::pal::os` to `sys::paths`) - rust-lang/rust#153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - rust-lang/rust#153936 (Skip stack_start_aligned for immediate-abort) - rust-lang/rust#154011 (implement `BinaryHeap::as_mut_slice`) - rust-lang/rust#154167 (ui/lto: move and rename two tests from issues/) - rust-lang/rust#154174 (allow `incomplete_features` in most UI tests) - rust-lang/rust#154175 (Add new alias for Guillaume Gomez email address) - rust-lang/rust#154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - rust-lang/rust#154188 (Update the tracking issue for #[diagnostic::on_move]) - rust-lang/rust#154201 (Use enums to clarify `DepNodeColorMap` color marking )

From the [blog post](https://blog.rust-lang.org/2026/03/26/1.94.1-release/) ## What's in 1.94.1 Rust 1.94.1 resolves three regressions that were introduced in the 1.94.0 release. - [Fix std::thread::spawn on wasm32-wasip1-threads](rust-lang/rust#153634) - [Remove new methods added to std::os::windows::fs::OpenOptionsExt](rust-lang/rust#153491) The new methods were unstable, but the trait itself is not sealed and so cannot be extended with non-default methods. - [Clippy: fix ICE in match_same_arms](rust-lang/rust-clippy#16685) - [Cargo: downgrade curl-sys to 0.4.83](rust-lang/cargo#16787) This fixes certificate validation error for some users on some versions of FreeBSD. See [this issue](rust-lang/cargo#16357) for more details. And a security fix: - [Cargo: Update tar to 0.4.45](rust-lang/cargo#16769) This resolves [CVE-2026-33055](https://www.cve.org/CVERecord?id=CVE-2026-33055) and [CVE-2026-33056](https://www.cve.org/CVERecord?id=CVE-2026-33056). Users of crates.io are not affected. See [blog](https://blog.rust-lang.org/2026/03/21/cve-2026-33056/) for more details.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [rust](https://github.com/rust-lang/rust) | patch | `1.94.0` → `1.94.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>rust-lang/rust (rust)</summary> ### [`v1.94.1`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-1941-2026-03-26) [Compare Source](rust-lang/rust@1.94.0...1.94.1) \=========================== <a id="1.94.1"></a> - [Fix `std::thread::spawn` on wasm32-wasip1-threads](rust-lang/rust#153634) - [Remove new methods added to `std::os::windows::fs::OpenOptionsExt`](rust-lang/rust#153491) The new methods were unstable, but the trait itself is not sealed and so cannot be extended with non-default methods. - [Clippy: fix ICE in `match_same_arms`](rust-lang/rust-clippy#16685) - [Cargo: update tar to 0.4.45](rust-lang/cargo#16769) This resolves CVE-2026-33055 and CVE-2026-33056. Users of crates.io are not affected. See [blog](https://blog.rust-lang.org/2026/03/21/cve-2026-33056/) for more details. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [rust](https://github.com/rust-lang/rust) | patch | `1.94.0` → `1.94.1` | --- ### Release Notes <details> <summary>rust-lang/rust (rust)</summary> ### [`v1.94.1`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-1941-2026-03-26) [Compare Source](rust-lang/rust@1.94.0...1.94.1) \=========================== <a id="1.94.1"></a> - [Fix `std::thread::spawn` on wasm32-wasip1-threads](rust-lang/rust#153634) - [Remove new methods added to `std::os::windows::fs::OpenOptionsExt`](rust-lang/rust#153491) The new methods were unstable, but the trait itself is not sealed and so cannot be extended with non-default methods. - [Clippy: fix ICE in `match_same_arms`](rust-lang/rust-clippy#16685) - [Cargo: update tar to 0.4.45](rust-lang/cargo#16769) This resolves CVE-2026-33055 and CVE-2026-33056. Users of crates.io are not affected. See [blog](https://blog.rust-lang.org/2026/03/21/cve-2026-33056/) for more details. </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland, Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://harton.dev/project-neon/neonfs/pulls/86 Co-authored-by: Renovate Bot <bot@harton.nz> Co-committed-by: Renovate Bot <bot@harton.nz>

rustbot assigned joboet Mar 6, 2026

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 6, 2026

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 6, 2026

rustbot assigned Amanieu and unassigned joboet Mar 6, 2026

rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Mar 10, 2026

ChrisDenton force-pushed the openoptionsext2 branch from eabd1ff to 8199edb Compare March 10, 2026 09:47

Move freeze_* methods to OpenOptionsExt2

fb65707

ChrisDenton force-pushed the openoptionsext2 branch from 8199edb to fb65707 Compare March 10, 2026 09:52

cuviper added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Mar 18, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2026

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 4 pull requests #154209

Closed

Mark-Simulacrum mentioned this pull request Mar 22, 2026

[stable] 1.94.1 release #154211

Merged

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 3 pull requests #154212

Closed

Mark-Simulacrum removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Mar 22, 2026

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 13 pull requests #154219

Closed

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 23 pull requests #154226

Closed

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 22 pull requests #154227

Closed

JonathanBrouwer mentioned this pull request Mar 23, 2026

Rollup of 21 pull requests #154255

Merged

rust-bors bot merged commit 5b2cad5 into rust-lang:main Mar 23, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 23, 2026

ChrisDenton deleted the openoptionsext2 branch March 23, 2026 16:22

ehuss mentioned this pull request Mar 25, 2026

[beta] backports #154346

Merged

ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026

ehuss modified the milestones: 1.96.0, 1.95.0, 1.94.1 Mar 25, 2026

CleanCut mentioned this pull request Mar 26, 2026

Bump to Rust 1.94.1 Oxen-AI/Oxen#384

Merged

xtqqczze mentioned this pull request Mar 27, 2026

remove Rust 1.94.0 workarounds tokio-rs/tokio#7987

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move `freeze_*` methods to `OpenOptionsExt2`#153491

Move `freeze_*` methods to `OpenOptionsExt2`#153491
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
ChrisDenton:openoptionsext2

ChrisDenton commented Mar 6, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Mar 6, 2026

Uh oh!

joboet commented Mar 6, 2026

Uh oh!

Darksonn commented Mar 9, 2026

Uh oh!

jieyouxu commented Mar 10, 2026

Uh oh!

joshtriplett commented Mar 10, 2026

Uh oh!

ChrisDenton commented Mar 10, 2026

Uh oh!

Mark-Simulacrum commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

CodesInChaos commented Mar 23, 2026

Uh oh!

Uh oh!

ChrisDenton commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

ChrisDenton commented Mar 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 6, 2026

Uh oh!

joboet commented Mar 6, 2026

Uh oh!

Darksonn commented Mar 9, 2026

Uh oh!

jieyouxu commented Mar 10, 2026

Uh oh!

joshtriplett commented Mar 10, 2026

Uh oh!

ChrisDenton commented Mar 10, 2026

Uh oh!

Mark-Simulacrum commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

CodesInChaos commented Mar 23, 2026

Uh oh!

Uh oh!

ChrisDenton commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ChrisDenton commented Mar 6, 2026 •

edited by rustbot

Loading